Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Paweł Gałązka
    @pawelgalazka
    yup I was thinking about prepending
    overwriting in the terms that adding to the user ENV runjs path
    Justin Bennett
    @zephraph
    Well, checkout the latest change I committed.
    Paweł Gałązka
    @pawelgalazka
    build is failing
    Justin Bennett
    @zephraph
    Yeah, I just noticed that. heh, I redefined path.
    _>
    It's fixed now.
    Hey... what is options.stdio used for?
    It's not in the documentation for child_process.
    Or at least, I didn't see it.
    Paweł Gałązka
    @pawelgalazka
    I'm assuming that for incoming stream
    Justin Bennett
    @zephraph
    Ahh, I see. Hmm.
    Paweł Gałązka
    @pawelgalazka
    alright pr looks good, if you could only squash commits to remove unnecessary ones (like the first one)
    Justin Bennett
    @zephraph
    Will do.
    Justin Bennett
    @zephraph
    Give me a sec, I jacked up my local environment somehow.
    Paweł Gałązka
    @pawelgalazka
    ok
    Justin Bennett
    @zephraph
    I think it's good to go now.
    Paweł Gałązka
    @pawelgalazka
    alright, merged
    Justin Bennett
    @zephraph
    Cool.
    I'm going to try to tackle the babel piece now.
    Paweł Gałązka
    @pawelgalazka
    yup, I think that as soon as we will get that fix and providing some more tests I will release 2.1.1 version
    Justin Bennett
    @zephraph
    Sounds good.
    Hey, would you mind making me a collaborator? I can just do this work in a branch. It'll be a little bit easier for us to work directly together.
    Justin Bennett
    @zephraph
    Also, to keep up with semantic versioning, I'd recommend changing to 2.2 for the next version. The babel piece is more than just a bug fix, there's a new feature bundled in with that too. Technically speaking it removes the direct babel dependency so it's also somewhat of a breaking change...
    I guess we can work through that when we get there.
    Paweł Gałązka
    @pawelgalazka
    alright I added you as collaborator
    Justin Bennett
    @zephraph
    Thanks!
    Paweł Gałązka
    @pawelgalazka
    agree with the versioning
    Justin Bennett
    @zephraph
    Okay, so there are two branches.
    I added a better-exceptions branch that just has the changes suggested for exception handling.
    And I added a babel compat branch.
    Paweł Gałązka
    @pawelgalazka
    alright, if you are ready with those just do pr
    Justin Bennett
    @zephraph
    Just did.
    Babel-compat probably isn't finished. It's just up for discussion.
    Paweł Gałązka
    @pawelgalazka
    ok
    Justin Bennett
    @zephraph
    Heh, sorry to bombard you with stuff today. I'm looking at using this library for our build process at work, but it needs to be buttoned up a bit. Took the day off to see what I could get done.
    Paweł Gałązka
    @pawelgalazka
    no problem, it's good to have feedback
    Justin Bennett
    @zephraph
    I'm also using webpack, but it's so so damn complex. And I have a hard problem to solve but absolutely no one has tried to help this far. It's a bit frustrating.
    Paweł Gałązka
    @pawelgalazka
    how did you know about runjs ? reddit ?
    Paweł Gałązka
    @pawelgalazka
    Alright I will go offline now but I will take a look at updates tomorrow my time
    Justin Bennett
    @zephraph
    All right man, sounds good. Have a good one.
    Paweł Gałązka
    @pawelgalazka
    @zephraph I've released v2.2.0 version I've tested it quite a lot, but you can also play with it if you can
    Justin Bennett
    @zephraph
    Cool man, sounds good.
    Victor Garcia
    @portenez

    I’m getting:

    Error: stdout maxBuffer exceeded
    at Socket.<anonymous> (child_process.js:259:14)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:177:18)
    at Socket.Readable.push (_stream_readable.js:135:10)
    at Pipe.onread (net.js:542:20)

    on a long running process spawned using run(‘’, { async: true })

    suppodsedly the process is not pringint anything to stdout. Any ideas of what could be done to avoid this?

    Victor Garcia
    @portenez
    it seems like the command is actually printing stuff, is there any way to avoid the issue above? for a long running command that keeps printing stuff?
    Paweł Gałązka
    @pawelgalazka
    @portenez sorry for late answer, yeah so that was a known bug, should be ok now with 3.2.0 version
    api changed a bit though, run will only return executed command value only when stdio: 'pipe' option provided
    Victor Garcia
    @portenez
    @pawelgalazka dzięki, I did try updating, but had to roll back because of some breaking changes. The solution was to stop logging to the stdout from the process. We’re going to try updating to version 3.2 some time in the intermediate future. I’d like to do it sooner, but the breaking changes make it not completely straight fwd.
    Paweł Gałązka
    @pawelgalazka
    @portenez no worries :) with which version did you guys stuck ?
    Victor Garcia
    @portenez
    @pawelgalazka, We’re at version 2.5.1. The breaking change was the double dash —key pair. We are in some cases fwd the arguments directly to some commands. It’s easy to fix, but we do need to change a few things to make it work.