kentcdodds on v5.0.0
kentcdodds on deprecate
kentcdodds on master
fix: officially deprecate the p… (compare)
VM63 react.js:2277 Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs printWarning @ VM63 react.js:2277 lowPriorityWarning @ VM63 react.js:2296 get @ VM63 react.js:275 (anonymous) @ VM67 glamorous.umd.js:341 (anonymous) @ VM67 glamorous.umd.js:4 (anonymous) @ VM67 glamorous.umd.js:5
React.versionis greater than 15.5 (also loaded via React's stand-alone distributable), it tries and fails to call
require('prop-types'), and then it falls back to
React.PropTypes, triggering the warning
ThemeProvider, eg. having a toggle button that changes the
themefrom light to dark, and then all components that rely on that theme will update? Right now, I can change the theme prop just fine for my top level ThemeProvider, but it doesn't trigger the components to re-render (probably because it is passed as context), so I don't actually see the new changes.
npm start validatefails. Test are failing (6) and I wanted to see if I am missing something before opening an issue. I'm certain there is something I missed, but nothing is standing out as of now. Thanks.
npm start testyields a more descriptive error message. I suspect there is something environment that is not setup on my machine in some way (a globally installed package, etc.). Whatever the cause is, it would be at least good to document the outcome for others; surely I'm not the only one with this problem.
<Link prop='a choice'>vs