Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 25 2020 14:47
    vesparny removed as member
  • Jan 23 2020 17:14
    kentcdodds removed as member
  • May 07 2019 12:50
    bjoernricks removed as member
  • Dec 06 2018 20:35
    TejasQ commented #419
  • Dec 06 2018 20:06
    kentcdodds commented #419
  • Dec 06 2018 20:04
    kentcdodds commented #419
  • Dec 06 2018 19:58

    kentcdodds on v5.0.0

    (compare)

  • Dec 06 2018 19:55

    kentcdodds on deprecate

    (compare)

  • Dec 06 2018 19:55
    kentcdodds closed #419
  • Dec 06 2018 19:55

    kentcdodds on master

    fix: officially deprecate the pā€¦ (compare)

  • Dec 06 2018 19:55
    kentcdodds closed #433
  • Dec 06 2018 19:54
    kentcdodds opened #433
  • Dec 06 2018 19:54

    kentcdodds on deprecate

    fix: officially deprecate the pā€¦ (compare)

  • Dec 06 2018 19:52

    kentcdodds on update-stuff

    (compare)

  • Dec 06 2018 19:51

    kentcdodds on master

    chore: update all things so it ā€¦ (compare)

  • Dec 06 2018 19:51
    kentcdodds closed #432
  • Dec 06 2018 19:48
    codecov[bot] commented #432
  • Dec 06 2018 19:45
    kentcdodds synchronize #432
  • Dec 06 2018 19:45

    kentcdodds on update-stuff

    chore: update all things so it ā€¦ (compare)

  • Dec 06 2018 19:40
    kentcdodds opened #432
Callum Denby
@CallumDenby
All other glamorous components render fine, just that one.
Luke John
@luke-john
Hey @CallumDenby , I've just tried to replicate the issue and don't seem to be able to. the following reproduction in safari appears to work fine for me https://codesandbox.io/s/jp15y2qkv5. if your able to set up a codesandbox reproduction or share the whole code that is leading to the issue I'd be happy to have another look.
Callum Denby
@CallumDenby
Hi @luke-john, I haven't managed to replicate the issue but I found a work around being to just style the div, it seemed to only be the glamorous.a component in use so I just wrapped it.
const Link = ({ href, children }) =>
  <Div css={{
    padding: '5px',
  }}>
    <a href={href}>
      {children}
    </a>
  </Div>
Mordy Tikotzky
@tikotzky
@kentcdodds the link to "the chat" in the codesandbox https://help.glamorous.rocks/ is pointing to https://gitter.im/kentcdodds/glamorous it should be updated to point to here (https://gitter.im/paypal/glamorous)
Mordy Tikotzky
@tikotzky
Hi all, Is it possible to extend the CssProperties allow certain properties to take additional values?
My use case is to allow color and background color css properties to accept a "Color" type as a valid value
(I should specify that this is using TypeScript)
here is a sandbox showing the issue https://codesandbox.io/s/rk8von4wo
Daniel Park
@gimli01
hey guys!
was wondering if anyone knows how to use a glamorous component with React Router Link\
Adrian Perez
@blackxored
hey guys, i just published a post on how to make glamorous work with native elements, (h1, div, etc.), check it out https://adrianperez.codes/glamorous-in-next-js-with-native-elements-styling/
Kent C. Dodds
@kentcdodds
Daniel Park
@gimli01
so i'm trying to change the styling based on props.location
is there a way to do child component selectors?
or do i have to pass a prop down to every child that needs to be changed
i'm doing somehting like this right now
export default glamorous.nav(
{
position: 'absolute',
display: 'flex',
left: 0,
right: 0,
top: 0,
margin: 0,
height: '90px',
justifyContent: 'space-between',
alignItems: 'center',
zIndex: 1000,
},
({ type, theme }) => ({
backgroundColor: type === 'primary' ? null : theme.white,
boxShadow: type === 'primary' ? null : theme.boxShadow,
'& div > ul > li > a': {
color: type === 'primary' ? theme.white : theme.blue,
fontWeight: '400',
letterSpacing: '1px',
},
}),
);
export default glamorous.nav(
{
position: 'absolute',
display: 'flex',
left: 0,
right: 0,
top: 0,
margin: 0,
height: '90px',
justifyContent: 'space-between',
alignItems: 'center',
zIndex: 1000,
},
({ type, theme }) => ({
backgroundColor: type === 'primary' ? null : theme.white,
boxShadow: type === 'primary' ? null : theme.boxShadow,
'& div > ul > li > a': {
color: type === 'primary' ? theme.white : theme.blue,
fontWeight: '400',
letterSpacing: '1px',
},
}),
);
```
oops
new to gitter
sorry about that
but it'd be much easier if i could just do child selectors from the parent nav component
instead of passing props down to every single component that needso tbe changed
Junyoung Clare Jang
@Ailrun
paypal/glamorous#419
Andrew Blick
@blicksky
Hey, would someone be able to help me understand why themes don't seem to be passed through glamorous to custom components? I set up a test case here: https://codesandbox.io/s/017659o850
Royston Shufflebotham
@RoystonS
Hi all. Just noticed (from a flurry of issue closing activity) that glamorous is not long for this world. Shame, but I agree that duplication makes no sense. @kentcdodds , have you figured out how to use rtl-css-js with emotion yet?
Kent C. Dodds
@kentcdodds
I haven't tried it yet @RoystonS, but I did ask Kye (creator of emotion) and I remember him showing me an example at one point. I can't remember where that is though. You could probably jump in their slack and get an answer pretty quickly.
Royston Shufflebotham
@RoystonS
Thanks very much, Kent.
Royston Shufflebotham
@RoystonS
Looks like emotion does plugins via stylis, which doesn't work with CSS-in-JS objects. I've managed to get emotion working with rtl-css-js, but it requires exposing convertProperty from rtl-css-js so that each individual CSS rule can be processed.
Kent C. Dodds
@kentcdodds
Thanks @RoystonS. If there's anything that I can do in rtl-css-js to make it easier let me know.
And if you can share what you're doing in that deprecation issue that would be very helpful!
Royston Shufflebotham
@RoystonS
Btw, we've just completed the migration of our codebase. About 110 modules, so probably about 400 glamorous components of various sizes, all moved over to emotion. Biggest painpoints were a) withProps (the recompose variant is way more painful to work with than the glamorous one), b) typing (the emotion TypeScript types are a little 'immature').
Here's what I've ended up with for rtl-css-js: https://gist.github.com/RoystonS/15e9fcd6aed5c67eb203d01936bd110a
(That's not terribly efficient, but it works for now.)