These are chat archives for paypal/squbs

18th
Nov 2016
Anil Gursel
@anilgursel
Nov 18 2016 14:56
@akara Please see https://www.codacy.com/app/akara-sucharitakul/squbs/file/4470966869/issues/source?bid=2834325&fileBranchId=3921478#l83. Is there a specific reason why we do not use Try(underlying.getString(path)).toOption? Do we really care if the exception is something other than ConfigException.Missing ?
Anil Gursel
@anilgursel
Nov 18 2016 21:54
@akara Please see paypal/squbs#335
Anil Gursel
@anilgursel
Nov 18 2016 22:55
added another commit to paypal/squbs#334 to add tests for metrics on the server side, it will not be squashed.. This was waiting for extraction to happen first..
for this PR, Codacy complains about try/catch; however, that code is pre-existing, I just moved that around.. But, my question above still holds, why cannot we do Try(underlying.getString(path)).toOption?
Regarding #335, I also would like to add JMX beans for security configuration.. That might be a different PR though..