These are chat archives for paypal/squbs

20th
Mar 2017
Anil Gursel
@anilgursel
Mar 20 2017 20:01

@akara Please see paypal/squbs#420.. All comments are addressed, except

Also, FiniteDuration is a Scala artifact. It is common to use a Long in ms instead of a FiniteDuration as timeout.

I have not squashed on purpose to make review easier.. Once you give a thumbs up I will squash
Anil Gursel
@anilgursel
Mar 20 2017 21:17
@akara Just did the review on PRs..
Akara Sucharitakul
@akara
Mar 20 2017 22:24
Thanks! Catching up.
Akara Sucharitakul
@akara
Mar 20 2017 22:30
@anilgursel The Github documentation https://guides.github.com/features/mastering-markdown/ have not changed the header format just yet. I'm trying to search whether this is a bug. Such a change would have very widespread implications.
Akara Sucharitakul
@akara
Mar 20 2017 22:37
The timing doesn't jibe, but I found this: chjj/marked#201
It says that we should leave a space between the hashtag and the header text.
Create a branch from my own repo https://github.com/akara/squbs/blob/header-test/README.md and tried it out. Works!
So it needs to be done for ALL our docs!
Anil Gursel
@anilgursel
Mar 20 2017 23:40
:(