These are chat archives for paypal/squbs

14th
Apr 2017
Akara Sucharitakul
@akara
Apr 14 2017 00:27
@anilgursel Yes I did. Sorry for the delay addressing this.
Anil Gursel
@anilgursel
Apr 14 2017 15:10
@akara I know it is kind of late, but it occured to me while working on a task yesterday.. The new Resolver chain, we use java.net.URI because we assumed it would be used for non-http stuff as well; however, with the new design HttpEndpoint is separate, for other endpoints, a custom one will be created. Accordingly, I wonder if we should instead use akka.http.scaladsl.model.Uri and javadsl one..
Akara Sucharitakul
@akara
Apr 14 2017 15:33
Can you please point me to that? I used java.net.URI for tests but it was never meant to be defined for the Resolver. Implementations like HttpEndpoint can choose what to use. The current choice is java.net.URI.
Anil Gursel
@anilgursel
Apr 14 2017 15:33
Sorry, I meant HttpEndpoint using java.net.URI
previously, we had single Endpoint, not we have variarities and as you said, implementqtions can choose..
Should HttpEndopint use java.net.URI or akka.http.scaladsl/javadsl…Uri? when we had single Endpoint, it would be used for non-http as well.. that was the reason of using java.net.URI..
Akara Sucharitakul
@akara
Apr 14 2017 15:40
Principally, no problem. Just need to figure out the benefits/drawbacks as opposed to time. Also, what would we break if we make this change in 0.9.1 or 1.0?
Anil Gursel
@anilgursel
Apr 14 2017 15:40
it should not affect end users, I would say.
can be done in both 0.9.1 or 1.0.0, unless the user is directly using HttpEndpoint for defining its own resolver, for instance.
Akara Sucharitakul
@akara
Apr 14 2017 15:41
Then I'd push it out, given the current delivery schedule.
Anil Gursel
@anilgursel
Apr 14 2017 15:51
I agree. But, let me create an issue.