Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Łukasz Haze
    @lhaze
    @jakos, my dear friend, how are you doing? How is the review #30 for me and #28 of yours?
    Can't wait to move forward.
    Jakub Kostrzewa
    @jakos
    I will review #30 today.
    Łukasz Haze
    @lhaze
    👍
    Łukasz Haze
    @lhaze
    How are you feeling with your issues, @jakos? I don't want you to get tired of one single subject. So if you're feeling bored with Dependency Injection, I can switch with you: I'll take DI and you'll get an issue from some other project. There are some marked help wanted. Nota bene: those without the label either need defining DoD or I will know better what to do with some old code.
    Łukasz Haze
    @lhaze
    Ping, @jakos
    Łukasz Haze
    @lhaze
    Howrya, @jakos! I know it was you who solve #27, but I'm blocked and can't wait. Look at my change pcah/python-clean-architecture@dd391b7, especially at the DI module and tests for the repo component. That's an unfinished but working example of DI doing its job. No use of Inject descriptor yet, but kwargs are there. Notice I've changed expectations on component constructor to constructor(container, **kwargs). I've had to. I might reduce it to only kwargs or make a base class Component with __init__ to remind everyone about that.
    Looking forward your reply :)
    Łukasz Haze
    @lhaze
    PS. The last remark also means that every Component (i.e. something managed by DI Container) has to accept **kwargs, just because other implementations might need a kwarg.
    Łukasz Haze
    @lhaze
    @jakos May I ask you to use "Rebase and merge" policy when merging one-commit PRs? The "Create a merge commit" makes sense when a (living) feature branch is joined with current development branch or merging further upstream. A long living branch. But the additional merge commits for these one-commit branches are only making noise.
    Jakub Kostrzewa
    @jakos
    @lhaze OK. I didn't notice that there are other options in drop down menu. Can we change default policy to "rebase and merge"?
    Łukasz Haze
    @lhaze
    Ok, I'll check it.
    Łukasz Haze
    @lhaze
    Hello to all watchers and stargazers. Long time no hear. The channel is mute most of the time, because of our life commitments, but the works progress steadily. We've just published version 0.0.2. While it is still far being full-featured alpha, changes that have been made are significant. Take a look at the CHANGES.md & ROADMAP.md if you're courious.