Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Anders Jenbo
    @AJenbo
    Hope this is useful :)
    pdepend/pdepend#385
    Marc Würth
    @ravage84
    Certainly, it is. At worst, just a base for discussion.
    Anders Jenbo
    @AJenbo
    Kyle
    @kylekatarnls
    Thanks.
    Anders Jenbo
    @AJenbo
    I would like to suggest that we move to not using FQN in the phpDoc and instead import the relevant classes. Most will already be imported and this will make it less likely that one is not updated if it's namespace changes.
    For consistency I would also suggest that we use shorthands for scalar types int/bool vs integer/boolean.
    Anders Jenbo
    @AJenbo
    Lastly although it might not be consistent I think it would be a good idea to use ClassName[] for hinting array types over array<ClassName>, when the key type is unknown, since it's supported by more tools.
    Kyle
    @kylekatarnls
    I'm OK. We will take care of this after pdepend/pdepend#383 to avoid conflicts.
    Marc Würth
    @ravage84
    Sounds OK to me
    Anders Jenbo
    @AJenbo
    Nice, I can probably automate some of the style changes. Yeah lest get #383 in as the next one.
    Anders Jenbo
    @AJenbo
    Is there any way I can help move #383 forward? Maybe split it up in smaller PRs? I'm asking since I expect that I will start needing 7.1 supportfor phpmd in about two weeks time.
    Marc Würth
    @ravage84
    @AJenbo no, I guess it up to me to take some time to go through it
    But thanks for asking
    Anders Jenbo
    @AJenbo
    Ok cool, I'll apply some patience then :)
    Anders Jenbo
    @AJenbo
    Awsome to see that #383 has been merged :)
    I'll try and do fixes some more of the issues detected by PHPStan in a few weeks.
    Marc Würth
    @ravage84
    Cool
    Vladimir Panivko
    @sveneld
    Hello
    IMHO this issue phpmd/phpmd#739 is related to pdepend
    Am I right?
    Tobias van Beek
    @tvbeek
    I need to dive into the issue to be sure. But the first look is that you are correct.
    Vladimir Panivko
    @sveneld
    thanks
    Vladimir Panivko
    @sveneld
    pdepend/pdepend#466
    file cache ttl feature
    Marc Würth
    @ravage84

    @sveneld

    IMHO this issue phpmd/phpmd#739 is related to pdepend
    Am I right?

    Yes, very likely.

    Vladimir Panivko
    @sveneld
    ok, i will create issue in pdepend
    Vladimir Panivko
    @sveneld
    Kyle
    @kylekatarnls
    Thanks for your help @sveneld :+1:
    Anders Jenbo
    @AJenbo
    Look like TravisCI stalled while processing my PR. Would someone we willing to restart the failed job?
    pdepend/pdepend#483
    Kyle
    @kylekatarnls
    Yep, happened sometimes. We just restart them and it passes.
    Anders Jenbo
    @AJenbo
    I really hate how unstable TravisCI is, can't understand why it's the industry standard at this point.
    Kyle
    @kylekatarnls
    It is because it's the one free for Open-Source, and because of that it's also overloaded. :)
    Anders Jenbo
    @AJenbo
    I prefer using CircleCI it's both faster and more stable, and has better Docker integration.
    Kyle
    @kylekatarnls
    1 job at a time, that's an important disavantage.
    Anders Jenbo
    @AJenbo
    image.png
    Don't know where you read that but I'm using it in DevilutionX and there it's running 4 in parallel each with access to multiple threads:
    I belive TravisCI is also limited to 4 jobs at a time.
    Kyle
    @kylekatarnls
    It's written here: https://circleci.com/pricing/
    Anders Jenbo
    @AJenbo
    :o guess they should update there sales pitch :)
    Arh that's for private, not OSS
    Kyle
    @kylekatarnls
    What are their offer for OSS?
    You're sure you're on the could service? Or you're using the self-hosted version?
    Anders Jenbo
    @AJenbo
    No we use the OSS cloud solution
    One difference is that TravisCI offers free Mac servers for OSS, but you can only get Mac builds if you pay for CircleCI. But that isn't really a problem for Pdepend
    But for DevilutionX we have to use a combination of CircleCI, TravisCI and AppVeyor and that still doesn't cover us for Haiku and BSD :/
    Back on topic :) I have solved all PHPStan level 3 & 4 issues on my local system. But will wait with a PR until the current ones are merged as it will be easier to clean up and avoid conflicts that way.
    Kyle
    @kylekatarnls
    Excellent! 🎉
    Anders Jenbo
    @AJenbo
    I think TravisCI also stalled on running pdepend/pdepend#484 after your addition
    Anders Jenbo
    @AJenbo
    Only one job failed this time :D
    It's "Peer fingerprint did not match" again :/
    Marc Würth
    @ravage84

    @AJenbo

    I really hate how unstable TravisCI is, can't understand why it's the industry standard at this point.

    To my perception it only got worse in the last months. Coincidentially when GH introduced and pushed GH Actions. What a coincidence?

    Anders Jenbo
    @AJenbo
    Grats on releasing 2.8.0
    DamianAbr
    @DamianAbr
    Hello, can someone explain to me why in the tables the value of CYCLO is greater than 50?
    It should not go from 0 to 50 and if it is greater than 50, is it a very high risk code?
    Kyle
    @kylekatarnls
    Hello which table? Can you provide a link?