These are chat archives for pest-parser/pest

19th
Dec 2017
Dragoș Tiselice
@dragostis
Dec 19 2017 09:02
@jamesotron There seems to be a bug with comment containing other rules. Fixed and pushed beta 17. Hope this is the last beta. 2 PRs to merge and we're launching 1.0.
Daniel Collin
@emoon
Dec 19 2017 09:24
nice :)
Vincent Prouillet
@Keats
Dec 19 2017 17:17
I guess the release is now stuck on the lifetime PR? I'm not really sure where the perf regression is coming from either :(
Dragoș Tiselice
@dragostis
Dec 19 2017 17:23
@Keats The regression requires a bit of work to figure out. The only solution I see feasible here is to simply write multiple identical microbenchmarks in both branches in order to identify the exact problem.
I'll probably go for it myself soon if no progress is made.
Vincent Prouillet
@Keats
Dec 19 2017 17:35
it doesn't seem like it's making a lot of progress so you should probably try if you have time
James Harton
@jamesotron
Dec 19 2017 20:37
@dragostis thanks! I’ll pull the new version today and give it a go.
James Harton
@jamesotron
Dec 19 2017 21:26
@dragostis just to confirm, beta 17 fixed that bug.
James Harton
@jamesotron
Dec 19 2017 22:22
How come compiling pest_derive takes so long to compile? It can take over a minute on my quad-core Mac.
James Harton
@jamesotron
Dec 19 2017 22:56
Also how do I get those great panic messages that you show in the readme? All I get is "called Result::unwrap() on an Err"
James Harton
@jamesotron
Dec 19 2017 23:01
NVM
The Err type implements Display.