by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 09 20:14
    adybka opened #349
  • Jun 18 11:17
    CLAassistant commented #348
  • Jun 18 11:17

    dependabot-preview[bot] on nuget

    (compare)

  • Jun 18 11:17
    dependabot-preview[bot] closed #345
  • Jun 18 11:17
    dependabot-preview[bot] commented #345
  • Jun 18 11:17
    dependabot-preview[bot] labeled #348
  • Jun 18 11:17
    dependabot-preview[bot] opened #348
  • Jun 18 11:17

    dependabot-preview[bot] on nuget

    Bump Akka from 1.4.6 to 1.4.8 … (compare)

  • Jun 10 11:16
    CLAassistant commented #347
  • Jun 10 11:16

    dependabot-preview[bot] on nuget

    (compare)

  • Jun 10 11:16
    dependabot-preview[bot] closed #342
  • Jun 10 11:15
    dependabot-preview[bot] commented #342
  • Jun 10 11:15

    dependabot-preview[bot] on nuget

    Bump Microsoft.Extensions.Confi… (compare)

  • Jun 10 11:15
    dependabot-preview[bot] labeled #347
  • Jun 10 11:15
    dependabot-preview[bot] opened #347
  • May 27 11:17
    CLAassistant commented #346
  • May 27 11:17
    dependabot-preview[bot] labeled #346
  • May 27 11:17
    dependabot-preview[bot] opened #346
  • May 27 11:17

    dependabot-preview[bot] on nuget

    Bump ApprovalTests from 5.2.4 t… (compare)

  • May 27 11:17
    CLAassistant commented #345
Aaron Stannard
@Aaronontheweb
that error means it couldn't find one of them
Maciek Misztal
@mmisztal1980
which constructor argument of the PerfBenchmarkAttribute is it? I'm not seeing it :/
I did put it on the CounterThroughputAssertionAttribute though
Maciek Misztal
@mmisztal1980
nope, not seeing it :/
Both test methods are using different counter names
Aaron Stannard
@Aaronontheweb
the setup gets used for both
setup --> benchmark == 1:1
both counter names must be present on all benchmarks used with that setup
Maciek Misztal
@mmisztal1980
so I should use a single Benchmarked method per class then?
cause both methods use different counters
Aaron Stannard
@Aaronontheweb
you can declare both counters and not use one of them
or you could refactor them into separate classes
with a common abstract base class
Maciek Misztal
@mmisztal1980
exploring this option right now
Arjen Smits
@Danthar
I adopted the NBench target from the akka.net build script for my own use. https://github.com/akkadotnet/akka.net/blob/dev/build.fsx#L341
However nbench is not writing the test results
to the output directory
But, when i manually call the nbenchrunner with the exact same arguments, as the build script is using. It does work
Arjen Smits
@Danthar
I eliminated any code that might delete the testresults afterwards, and running script as admin makes no difference..
Arjen Smits
@Danthar
Btw solved my issue. Was something strange on my computer env. Reinstalled the entire machine (had more issues then just this). And the problem magically disappeared.
Aaron Stannard
@Aaronontheweb
@/all FYI, NBench now runs great on Mono: petabridge/NBench#134 - you can see some of the Mono v. .NET 4.6.2 benchmarks in the link above
Bart de Boer
@boekabart
@Aaronontheweb not sure which is the link above
Aaron Stannard
@Aaronontheweb
err
I meant the link in the comment @boekabart
Bart de Boer
@boekabart
Ah, mouseover helped :) Thanks
balanikas
@balanikas
Hi, when I run nbench and my code during setup tries to load assembly resources (SomeAssembly.resources.dll), it tries to load in en-US culture, which fails. Where does en-US come from, can it be changed? loading the resources with invariant culture works.
Aaron Stannard
@Aaronontheweb
@balanikas that's a good question
might be an issue with some default that we have built into the NBench.Runner
Nick Chamberlain
@heynickc
@balanikas thanks for letting us know, I'll put a github issue in about it
balanikas
@balanikas
thanks @heynickc :)
balanikas
@balanikas
@heynickc do u need more info from me for the github issue? Just let me know
Nick Chamberlain
@heynickc
@balanikas I added this issue: petabridge/NBench#213. Feel free to add any comments that might help. Thanks
balanikas
@balanikas
thx! I just commented
Aaron Stannard
@Aaronontheweb
@balanikas thanks! that's a very helpful suggestion - we'd also welcome a pull request if you're interested in contributing
balanikas
@balanikas
is there anyway to disable the prewarmup phase? my tests look like "prepare db, contexts, service containers, filesystem, etc" -> "run test" -> "cleanup". I would like to run all that just once.
Aaron Stannard
@Aaronontheweb
yes there is
@balanikas there's a DisableWarmup attribute on the Benchmark attribute
which will shut that off
balanikas
@balanikas
@Aaronontheweb I finally switched to benchmarkdotnet, because i needed some features that are missing in nbench. But I will keep an eye on nbench for the future :)
Aaron Stannard
@Aaronontheweb
@balanikas no problem! would you mind letting us know what you're missing?
so we can make NBench better?
balanikas
@balanikas
@Aaronontheweb highly customizable jobs, support for test parameters (the Params attribute), export to xml, csv, and some other things too, like for example the benchmark switcher. But I really like the assertion attributes that nbench has. Maybe i am wrong and nbench can do more than i realize. But it seems benchmarkdotnet is a bit more mature at this point.
Aaron Stannard
@Aaronontheweb
@balanikas that's great feedback - NBench is mature but definitely doesn't have those features yet
NBench was mostly designed to benchmark concurrent and network code with assertions to back them up
we use it on the Akka.NET project for critical parts of our system
Shawn Dube
@shawndube
#259 Any workarounds to get this working? drop the project down to 2.1 doesn't seem to work (although im new so maybe calling it incorrectly)
Shawn Dube
@shawndube
just noticed last message was 1.5 years ago! ill ask in the github issue.
Aaron Stannard
@Aaronontheweb
@shawndube yeah the room hasn't been as busy lately
but we'll take a look at fixing that - ran into that issue myself
Georgii Afanasev
@gmaf
Hello everyone! Really like what I've read about NBench. We want to use it in our project.
But I see that github development is not really active.
Can we start using it and be sure it would be compatible with netcore 3.0 and future releases of dotnet core?
Aaron Stannard
@Aaronontheweb
@gmaf yep, we will be updating it to support .NET Core 3.0