SELECT ARRAY[1,2,3,4,5 ..... 1000000] AS sources, ARRAY[1000000, ...... 5,4,3,2,1] as targets
The master branch has been updated, so you need to update the working branch
Steps:
If you haven't started coding:
git fetch gsoc
git checkout gsoc/<your branch>
git checkout -b <branch name>
git fetch upstream
git rebase upstream/master
git push --set-upstream origin <branch name>
And make a PR from <branch name> to gsoc/<your branch>
If you already started coding on branch: <branch name>
git checkout <branch name>
git fetch upstream
git rebase upstream/master
git push
And make a PR from <branch name> to gsoc/<your branch>
I will check those PR (in my) tonight
Why the same build passes on appveyor and fails on travis-ci.
@rajhim2 I don't have any idea how it passes on appveyor, however, there's an error in your added files.
In the file src/kargersContraction/kargersContraction.c
, the function's name shall be in all lowercase, as PostgreSQL converts all unquoted names to lowercase (_pgr_kargerscontraction
instead of _pgr_kargersContraction
).
You need to change this in all the three lines:
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L43
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L44
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L116
Why the same build passes on appveyor and fails on travis-ci.
@rajhim2 I don't have any idea how it passes on appveyor, however, there's an error in your added files.
In the file
src/kargersContraction/kargersContraction.c
, the function's name shall be in all lowercase, as PostgreSQL converts all unquoted names to lowercase (_pgr_kargerscontraction
instead of_pgr_kargersContraction
).You need to change this in all the three lines:
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L43
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L44
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L116
Thank you @krashish8 ! It worked like a charm.
Once that
From the console terminal:
# make sure that you are in the correct branch
git checkout combinationsSQL
# update to latest main repo contents
git fetch upstream
# Put your work on top of what develop
git rebase upstream/develop
Once you have updated the repo, the following that I forgot to mention on our last meeting must be done:
in doc/src/release_notes.rst
in the corresponding 3.1.0 release notes add
.. rubric:: New functions
* pgr_dijkstra(combinations)
From the github website:
I was adding the boost functionality to the function pgr_depthFirstSearch
(pgRouting/GSoC-pgRouting#38) I was implementing.
For this I was supposed to use boost::depth_first_search - for directed graphs, and boost::undirected_dfs - for undirected graphs.
In the current implementation, I have used pgrouting::UndirectedGraph
(#L117) and called boost::depth_first_search
, yet the function gives the correct result, as expected, for the undirected graph. The documentation for boost::depth_first_search
says the graph Graph& g
should be directed, however in the current implementation, I use undirected graph with it, and it is working alright.
Moreover, in the pgrouting, we have the functions pgr_primDFS and pgr_kruskalDFS, both of which work only for Undirected Graphs, but in the implementation, I see that the function calls the boost::depth_first_search
which is supposed to take only Directed Graphs as input.
As the current implementation works good on calling boost::depth_first_search
for both directed and undirected graphs, I don't consider the need to use boost::undirected_dfs
as everything is working fine.
Anyone has any idea why does the boost::depth_first_search
still works for undirected graphs?