by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 05:15

    cvvergara on translations_release-notes-po--master_es

    (compare)

  • 05:15

    cvvergara on master

    Apply translations in es trans… Merge branch 'master' into tran… Merge pull request #1372 from p… (compare)

  • 05:15
    cvvergara closed #1372
  • 03:35
    cvvergara synchronize #1372
  • 03:35

    cvvergara on translations_release-notes-po--master_es

    Translate /locale/en/LC_MESSAGE… Merge pull request #1371 from p… Merge branch 'master' into tran… (compare)

  • 03:35

    cvvergara on translations_index-po--master_es

    (compare)

  • 03:35

    cvvergara on master

    Translate /locale/en/LC_MESSAGE… Merge pull request #1371 from p… (compare)

  • 03:35
    cvvergara closed #1371
  • 03:22
    cvvergara labeled #1371
  • 03:22
    cvvergara milestoned #1371
  • 03:20
    cvvergara milestoned #1372
  • 03:20
    cvvergara review_requested #1372
  • 02:56
    transifex-integration[bot] opened #1372
  • 02:56

    transifex-integration[bot] on translations_release-notes-po--master_es

    Apply translations in es trans… (compare)

  • 02:56

    transifex-integration[bot] on translations_release-notes-po--master_es

    (compare)

  • 02:53
    transifex-integration[bot] opened #1371
  • 02:53

    transifex-integration[bot] on translations_index-po--master_es

    Translate /locale/en/LC_MESSAGE… (compare)

  • 02:53

    transifex-integration[bot] on translations_index-po--master_es

    (compare)

  • 02:40

    cvvergara on translations_contraction-family-po--master_es

    (compare)

  • 02:40

    cvvergara on cvvergara-patch-1

    (compare)

Ashish Kumar
@krashish8
Okay. Thanks!
Vicky Vergara
@cvvergara
@krashish8 @rajhim2 @prakashupes please review pgRouting/pgrouting#1349
Vicky Vergara
@cvvergara

Topic: updating your working branch

The master branch has been updated, so you need to update the working branch

  • work on your GSoC-pgRouting clone
  • suppose remotes are:
    • origin your GSoC-pgRouting fork
    • upstream pgRouting repo
    • gsoc the GSoC-pgRouting repo

Steps:

  • If you haven't started coding:

    git fetch gsoc
    git checkout gsoc/<your branch> 
    git checkout -b <branch name>
    git fetch upstream
    git rebase upstream/master
    git push --set-upstream origin <branch name>

    And make a PR from <branch name> to gsoc/<your branch>

  • If you already started coding on branch: <branch name>

    git checkout <branch name>
    git fetch upstream
    git rebase upstream/master
    git push

    And make a PR from <branch name> to gsoc/<your branch>

I will check those PR (in my) tonight

end of topic

Vicky Vergara
@cvvergara
@rajhim2 why are you reverting the merge of the PR on the main repository
Ashish Kumar
@krashish8
@cvvergara I think we should force push in case "If you already started coding on branch: <branch name>"
git push -f
This is because rebasing would reorder the commits history, therefore the remote branch can't be fast-forwarded to local, without a force push.
Vicky Vergara
@cvvergara
yeah I forgot the -f, but that doesnt try to revert the master branch of the main repository
@krashish8 can you make the PR
Ashish Kumar
@krashish8
@cvvergara Done!
Vicky Vergara
@cvvergara
Thanks, The merge will be done before mailing a report next weekend
The opened PR will allow to follow your work
Ashish Kumar
@krashish8
Okay, understood!
Himanshu Raj
@rajhim2

@rajhim2 why are you reverting the merge of the PR on the main repository

It was clicked by mistake mam.

Ashish Kumar
@krashish8
@cvvergara There are some extra commits made by transfix-integration [bot]. So, we should rebase the master branch of pgrouting repository again, right? (repeating the above steps)
Himanshu Raj
@rajhim2
Can anyone please explain me why is this build failing. https://travis-ci.org/github/rajhim2/GSoC-pgRouting/jobs/689126458 This repository is on my profile rajhim2.
Himanshu Raj
@rajhim2
The command "if [ "$DOCUMENTATION" == "OFF" ] && [ "$BUILD_TYPE" == "Debug" ]; then bash ./ci/travis/doc-quieries_test.sh $POSTGRESQL_VERSION postgres; fi" exited with 1.
Daniel Kastl
@dkastl
Thank you @cvvergara !
Next I think it's on my to encourage a few more pgRouting businesses to financially contribute:
https://funding.communitybridge.org/projects/pgrouting
Rajat Shinde
@omshinde
Thank you @cvvergara . Congratulations to the team. :)
Vicky Vergara
@cvvergara
Next meeting: tuesday May 26 at 2pm UTC = 9am in Mexico = 7:30pm in India
Himanshu Raj
@rajhim2
Why the same build passes on appveyor and fails on travis-ci.
Ashish Kumar
@krashish8

Why the same build passes on appveyor and fails on travis-ci.

@rajhim2 I don't have any idea how it passes on appveyor, however, there's an error in your added files.

In the file src/kargersContraction/kargersContraction.c, the function's name shall be in all lowercase, as PostgreSQL converts all unquoted names to lowercase (_pgr_kargerscontraction instead of _pgr_kargersContraction).

You need to change this in all the three lines:

https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L43
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L44
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L116

Himanshu Raj
@rajhim2

Why the same build passes on appveyor and fails on travis-ci.

@rajhim2 I don't have any idea how it passes on appveyor, however, there's an error in your added files.

In the file src/kargersContraction/kargersContraction.c, the function's name shall be in all lowercase, as PostgreSQL converts all unquoted names to lowercase (_pgr_kargerscontraction instead of _pgr_kargersContraction).

You need to change this in all the three lines:

https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L43
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L44
https://github.com/rajhim2/GSoC-pgRouting/blob/him/src/kargersContraction/kargersContraction.c#L116

Thank you @krashish8 ! It worked like a charm.

Himanshu Raj
@rajhim2
Mahmoud will open 1 issue:
For the functionality request of the pgr_dijkstra with the combinations sql
the issue has an example
step 2) Other issue (maybe there is already one that talks about using ctlr-C and in the comment put the possible solution.
Then once we located both issues, Mahmoud will open a PR with tilte "Closes #xx and closes #yyy" with a small comment on the message
After that, @cvvergara will open an issue about using the method for stoping execution on each function.
Himanshu Raj
@rajhim2
Open issues about the code that Mahmoud made
For example: "Normal" flag is not needed
other example: To create pgr_dikstraCost with combinations
Himanshu Raj
@rajhim2
doc/src/pgRouting-introduction.rst
Vicky Vergara
@cvvergara

Topic: @mahmsakr preparation for PR

Once that

  • Contributor name has been added to modified files
  • Contributor name is on the license of new files
  • Contributor name is been added to the Contributors List

From the console terminal:

# make sure that you are in the correct branch
git checkout combinationsSQL
# update to latest main repo contents
git fetch upstream
# Put your work on top of what develop
git rebase upstream/develop

Once you have updated the repo, the following that I forgot to mention on our last meeting must be done:

  • in doc/src/release_notes.rst in the corresponding 3.1.0 release notes add

    .. rubric:: New functions
    
    * pgr_dijkstra(combinations)
  • Commit and push

From the github website:

  • make a PR to develop branch

    end of topic

Vicky Vergara
@cvvergara

@rajhim2

Why the same build passes on appveyor and fails on travis-ci.

appveyor does not perform the tests it only compiles the tests travis besides compiling does the testing.

Vicky Vergara
@cvvergara
Vicky Vergara
@cvvergara
G=(E,V)
Ashish Kumar
@krashish8

I was adding the boost functionality to the function pgr_depthFirstSearch (pgRouting/GSoC-pgRouting#38) I was implementing.
For this I was supposed to use boost::depth_first_search - for directed graphs, and boost::undirected_dfs - for undirected graphs.

In the current implementation, I have used pgrouting::UndirectedGraph(#L117) and called boost::depth_first_search, yet the function gives the correct result, as expected, for the undirected graph. The documentation for boost::depth_first_search says the graph Graph& g should be directed, however in the current implementation, I use undirected graph with it, and it is working alright.

Moreover, in the pgrouting, we have the functions pgr_primDFS and pgr_kruskalDFS, both of which work only for Undirected Graphs, but in the implementation, I see that the function calls the boost::depth_first_search which is supposed to take only Directed Graphs as input.

As the current implementation works good on calling boost::depth_first_search for both directed and undirected graphs, I don't consider the need to use boost::undirected_dfs as everything is working fine.

Anyone has any idea why does the boost::depth_first_search still works for undirected graphs?

Vicky Vergara
@cvvergara
Yes, I have an idea, because you are using this general graph class that I created so you get the graph that you need:
https://docs.pgrouting.org/doxy/3.0/classpgrouting_1_1graph_1_1Pgr__base__graph.html
So, with the if-then-else you need to make sure you are calling to the correct boost function
Vicky Vergara
@cvvergara

TOPIC: Interruptions

(Not for the GSoC students)
The branch https://github.com/mahmsakr/pgrouting/tree/combinationsSQL is almost ready and to merge the interruptions to that branch the following has to be done:
Use the website
Vicky Vergara
@cvvergara
update interruptions branch to current content on main repo develop branch
git remote add upstream https://github.com/pgRouting/pgrouting
git fetch upstream
git checkout interruptions
git rebase upstream/develop
git push

end of topic

Elias Pajares
@EPajares
potentialfix_pgrouting_issue#584..pdf

Dear pgrouting-community,

we are big fans of your work! And are especially using the driving-distance feature of the pgrouting library.
There is one known issue with this function though, that is summarized in the issue #584.
With the help of @vjeranc I was exploring possibilities to fix this.
In this attempt we were having some preliminary results that are summarized in the PDF attached.
We wanted to contact you because so far the best fix for us seemed to be a custom dijkstra-function as we were not managing to fix this using Boost.
Therefore, we wanted to hear your opinion on that. Is this something that could be accepted? Looking forward to discuss with you.

Best,

Elias

Vicky Vergara
@cvvergara

@EPajares Hi, starting a discussion:
For simplicity suppose there is a graph G(E,V) where E= {(u,v,cost=10)} AND V={u,v} and a driving distance of 4 departing from
u=======+----------------------------v
then between vertex u & v at the "+" its where the driving distance is reached
From the documentation this are the possible columns

RETURNS SET OF (seq, [start_vid,] node, edge, cost, agg_cost)

What would the result be with this graph?