Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 25 14:10
    bkrit edited #2120
  • Sep 25 14:10
    bkrit edited #2120
  • Sep 25 14:02

    bkrit on develop

    [alpha_shape] fixing PLSQL Merge pull request #2145 from b… (compare)

  • Sep 25 14:02
    bkrit closed #2145
  • Sep 25 12:32
    dkastl commented #2145
  • Sep 25 12:29
    bkrit commented #2145
  • Sep 25 12:19
    dkastl commented #2145
  • Sep 25 12:12
    bkrit milestoned #2145
  • Sep 25 12:12
    bkrit labeled #2145
  • Sep 25 12:12
    bkrit assigned #2145
  • Sep 25 12:12
    bkrit review_requested #2145
  • Sep 25 12:11
    bkrit opened #2145
  • Sep 25 02:55
    mohitsaxenaknoldus commented #2135
  • Sep 24 23:33
    cvvergara converted_to_draft #2085
  • Sep 24 23:28

    shonnungar on develop

    [contraction] fixing PLSQL Merge pull request #2144 from s… (compare)

  • Sep 24 23:28
    shonnungar closed #2144
  • Sep 24 23:19
    shonnungar assigned #2144
  • Sep 24 23:19
    shonnungar milestoned #2144
  • Sep 24 23:19
    shonnungar labeled #2144
  • Sep 24 23:18
    shonnungar edited #2144
Ashish Kumar
@krashish8

I mean the user may want to do that. It entirely depends upon the user.

As an example, for the graph coloring algorithm, if the graph contains an isolated vertex, it should also have some color assigned to it.

Example: coloring a map, such that two neighbouring states have different color. If the map contains an island state, it should also have some color assigned to it.
Vicky Vergara
@cvvergara
The island is not isolated
Vicky Vergara
@cvvergara
Portugal, Spain, Mexico, USA, Cuba (using the first letter)
P-S, M-U, M-C, U-C that would be the graph representing neighbours
Ashish Kumar
@krashish8
Fine. Got it!
Vicky Vergara
@cvvergara
Now the answer to your initial question.
To have an isolated vertex use ´0´ the edge will be added so the vertex.
 id | source | target | cost | reverse_cost 
----+--------+--------+------+--------------
  1 |      1 |      1 |   0 |           -1
(1 row)
Ashish Kumar
@krashish8
Okay. Thanks, got it!
Vicky Vergara
@cvvergara

As part of the Bolsena code spring:

In around 20 minutes will be working checking the PR #1361 with the author, you are welcome to join
Vicky Vergara
@cvvergara

Topic: PR #1361 review

Mohamed Bakli
@mbakli
Many thanks for adding me.
Vicky Vergara
@cvvergara
Hello @mbakli thanks for coming, we are going to review your PR
Mohamed Bakli
@mbakli
I am ready.
Vicky Vergara
@cvvergara

Plan of the week:

  • detect issues
  • fix issues
  • make one commit
  • merge to master
  • prepare master for v3.0.1
  • cherry pick the commit apply to develop
  • add the interruption code in the new functionality
  • move develop to master and release v.3.1.0
I will be doing prepare master for v3.0.1 you dont have to worry about that one

detect issues

One thing that needs to be done is add the appropriate licence to the new file you added
Mohamed Bakli
@mbakli
Ok
commit and push when done
(and tell me when done)
We have a style code checker, that follows some guidelines from https://google.github.io/styleguide/cppguide.html
we need to check
Vicky Vergara
@cvvergara
To check from the root of the repository do:
bash tools/scripts/code_checker.sh > marks.txt
You will see in the terminal that the file you created needs
INCLUDE_CPP_COMMON_INTERRUPTIONH
instead of
PGROUTING_INTERRUPTION_H
@mbakli I need to go fix a server crash, please do those things I will check them when I come back
Mohamed Bakli
@mbakli
@cvvergara I am doing them now
Mohamed Bakli
@mbakli
I did @cvvergara.
Mohamed Bakli
@mbakli
OK @cvvergara
travis seems to be working, I dont know why the other does not work
Mohamed Bakli
@mbakli
It should work.
Vicky Vergara
@cvvergara
I got this errors from the code checker:
include/cpp_common/interruption.h:27:  #ifndef header guard has wrong style, please use: INCLUDE_CPP_COMMON_INTERRUPTION_H_  [build/header_guard] [5]
include/cpp_common/interruption.h:39:  #endif line should be "#endif  // INCLUDE_CPP_COMMON_INTERRUPTION_H_"  [build/header_guard] [5]
include/cpp_common/interruption.h:35:  Include the directory when naming .h files  [build/include] [4]
include/cpp_common/interruption.h:36:  Include the directory when naming .h files  [build/include] [4]
include/cpp_common/interruption.h:39:  At least two spaces is best between code and comments  [whitespace/comments] [2]
include/cpp_common/interruption.h:39:  Should have a space between // and comment  [whitespace/comments] [4]
sec fixing format
you are missing an uderscore at the end of INCLUDE_CPP_COMMON_INTERRUPTION_H_

The files instead of

#include "postgres.h"

Use

#include <postgres.h>
Mohamed Bakli
@mbakli
OK
Vicky Vergara
@cvvergara
format for inline comments:
code(space)(space)//(space)comment
So fix the line that starts like
#endif  // IN
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
I still get this
include/cpp_common/interruption.h:39: At least two spaces is best between code and comments
you only have one space
Mohamed Bakli
@mbakli
What about now?
Vicky Vergara
@cvvergara
that change is not needed so do (I suppose here that you have upstream pointing to the main repo)
git checkout upstream/master CMakeLists.txt
commit and push
Mohamed Bakli
@mbakli
error: pathspec 'upstream/master' did not match any file(s) known to git
Vicky Vergara
@cvvergara
ah, ok, so you dont have upstream pointing to main repo

change this:

 set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>" include/cpp_common/interruption.h)

to

set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>")