Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Oct 25 18:17
    krashish8 opened #2202
  • Oct 25 18:17
    krashish8 opened #2201
  • Oct 25 14:53
    cvvergara milestoned #2170
  • Oct 25 14:53
    cvvergara milestoned #2188
  • Oct 25 14:52
    cvvergara labeled #2188
  • Oct 25 14:47
    cvvergara labeled #1872
  • Oct 25 14:47
    cvvergara unlabeled #1872
  • Oct 25 14:46
    cvvergara milestoned #2060
  • Oct 25 14:45
    cvvergara unlabeled #2060
  • Oct 25 14:45
    cvvergara milestoned #1968
  • Oct 25 14:44
    cvvergara milestoned #2056
  • Oct 25 14:44
    cvvergara milestoned #2073
  • Oct 25 14:44
    cvvergara milestoned #2075
  • Oct 25 14:44
    cvvergara milestoned #2077
  • Oct 25 14:43
    cvvergara milestoned #2079
  • Oct 25 14:43
    cvvergara milestoned #2081
  • Oct 25 14:43
    cvvergara milestoned #2099
  • Oct 25 14:42
    cvvergara milestoned #2104
  • Oct 25 14:42
    cvvergara milestoned #2106
  • Oct 25 14:41
    cvvergara milestoned #2123
Vicky Vergara
@cvvergara
I will be doing prepare master for v3.0.1 you dont have to worry about that one

detect issues

One thing that needs to be done is add the appropriate licence to the new file you added
Mohamed Bakli
@mbakli
Ok
commit and push when done
(and tell me when done)
We have a style code checker, that follows some guidelines from https://google.github.io/styleguide/cppguide.html
we need to check
Vicky Vergara
@cvvergara
To check from the root of the repository do:
bash tools/scripts/code_checker.sh > marks.txt
You will see in the terminal that the file you created needs
INCLUDE_CPP_COMMON_INTERRUPTIONH
instead of
PGROUTING_INTERRUPTION_H
@mbakli I need to go fix a server crash, please do those things I will check them when I come back
Mohamed Bakli
@mbakli
@cvvergara I am doing them now
Mohamed Bakli
@mbakli
I did @cvvergara.
Mohamed Bakli
@mbakli
OK @cvvergara
travis seems to be working, I dont know why the other does not work
Mohamed Bakli
@mbakli
It should work.
Vicky Vergara
@cvvergara
I got this errors from the code checker:
include/cpp_common/interruption.h:27:  #ifndef header guard has wrong style, please use: INCLUDE_CPP_COMMON_INTERRUPTION_H_  [build/header_guard] [5]
include/cpp_common/interruption.h:39:  #endif line should be "#endif  // INCLUDE_CPP_COMMON_INTERRUPTION_H_"  [build/header_guard] [5]
include/cpp_common/interruption.h:35:  Include the directory when naming .h files  [build/include] [4]
include/cpp_common/interruption.h:36:  Include the directory when naming .h files  [build/include] [4]
include/cpp_common/interruption.h:39:  At least two spaces is best between code and comments  [whitespace/comments] [2]
include/cpp_common/interruption.h:39:  Should have a space between // and comment  [whitespace/comments] [4]
sec fixing format
you are missing an uderscore at the end of INCLUDE_CPP_COMMON_INTERRUPTION_H_

The files instead of

#include "postgres.h"

Use

#include <postgres.h>
Mohamed Bakli
@mbakli
OK
Vicky Vergara
@cvvergara
format for inline comments:
code(space)(space)//(space)comment
So fix the line that starts like
#endif  // IN
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
I still get this
include/cpp_common/interruption.h:39: At least two spaces is best between code and comments
you only have one space
Mohamed Bakli
@mbakli
What about now?
Vicky Vergara
@cvvergara
that change is not needed so do (I suppose here that you have upstream pointing to the main repo)
git checkout upstream/master CMakeLists.txt
commit and push
Mohamed Bakli
@mbakli
error: pathspec 'upstream/master' did not match any file(s) known to git
Vicky Vergara
@cvvergara
ah, ok, so you dont have upstream pointing to main repo

change this:

 set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>" include/cpp_common/interruption.h)

to

set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>")
on the CMakeLists.txt of the root of the repo
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
Follow the style and add the 3.0.1 release notes in this file
https://github.com/pgRouting/pgrouting/blob/master/doc/src/release_notes.rst
Mohamed Bakli
@mbakli
Done. Is it correct?
Vicky Vergara
@cvvergara
You missed the table of contents entry
.. changelog start

* :ref:`changelog_3_0_1`
* :ref:`changelog_3_0_0`
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
Now we are going to regenerate the NEWS file that is at the root of the repository with this command from the root of the repo:
tools/release-scripts/notes2news.pl
if you do a git status you should see that the file NEWS changed
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
ok, so now lets wait until the pendnig CI finish
Mohamed Bakli
@mbakli
OK, thanks
Vicky Vergara
@cvvergara
or