Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Nov 18 06:58
    dkastl closed #2218
  • Nov 18 06:58
    dkastl commented #2218
  • Nov 18 03:47

    github-actions[bot] on gh-pages

    Update users documentation for … (compare)

  • Nov 18 03:43

    cvvergara on develop

    Organize pgtap tests (#2217) *… (compare)

  • Nov 18 03:43
    cvvergara closed #2217
  • Nov 18 03:31
    wmabcde opened #2218
  • Nov 18 03:03
    cvvergara assigned #2217
  • Nov 18 03:00
    cvvergara synchronize #2217
  • Nov 17 20:01
    cvvergara edited #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara review_requested #2217
  • Nov 17 20:01
    cvvergara milestoned #2217
  • Nov 17 20:01
    cvvergara labeled #2217
  • Nov 17 20:01
    cvvergara opened #2217
  • Nov 16 18:10

    cvvergara on gh-pages

    Adjusting index file and symlin… (compare)

  • Nov 16 18:02

    github-actions[bot] on gh-pages

    Update users documentation for … (compare)

Mohamed Bakli
@mbakli
OK
Vicky Vergara
@cvvergara
format for inline comments:
code(space)(space)//(space)comment
So fix the line that starts like
#endif  // IN
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
I still get this
include/cpp_common/interruption.h:39: At least two spaces is best between code and comments
you only have one space
Mohamed Bakli
@mbakli
What about now?
Vicky Vergara
@cvvergara
that change is not needed so do (I suppose here that you have upstream pointing to the main repo)
git checkout upstream/master CMakeLists.txt
commit and push
Mohamed Bakli
@mbakli
error: pathspec 'upstream/master' did not match any file(s) known to git
Vicky Vergara
@cvvergara
ah, ok, so you dont have upstream pointing to main repo

change this:

 set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>" include/cpp_common/interruption.h)

to

set(PGROUTING_OBJECTS ${PGROUTING_OBJECTS} "$<TARGET_OBJECTS:${subdir}>")
on the CMakeLists.txt of the root of the repo
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
Follow the style and add the 3.0.1 release notes in this file
https://github.com/pgRouting/pgrouting/blob/master/doc/src/release_notes.rst
Mohamed Bakli
@mbakli
Done. Is it correct?
Vicky Vergara
@cvvergara
You missed the table of contents entry
.. changelog start

* :ref:`changelog_3_0_1`
* :ref:`changelog_3_0_0`
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
Now we are going to regenerate the NEWS file that is at the root of the repository with this command from the root of the repo:
tools/release-scripts/notes2news.pl
if you do a git status you should see that the file NEWS changed
Mohamed Bakli
@mbakli
Done
Vicky Vergara
@cvvergara
ok, so now lets wait until the pendnig CI finish
Mohamed Bakli
@mbakli
OK, thanks
Vicky Vergara
@cvvergara
or
lets work on another branch
I am thinking
we will work on another branch
git checkout -b interruptions
Mohamed Bakli
@mbakli
OK, I did.
Vicky Vergara
@cvvergara
we are going to squash all the commits into one commit
for that purpose:
git remote add upstream https://github.com/pgRouting/pgrouting
git fetch upstream
to check that you have upstream pointing to pgRouting main repo:
git remote -v
To squash the commits I will tell you the command and what happens. then after that information you do it
git rebase -i upstream/master
That will open a file, and it has some instructions in form of comments that start with #
Mohamed Bakli
@mbakli
Yes I see
Vicky Vergara
@cvvergara
one of the instructions is
# s, squash = use commit, but meld into previous commit
you need to change the pick to squash in all the commits except the first one
Mohamed Bakli
@mbakli
Should I uncomment this line?
OK
Vicky Vergara
@cvvergara
when you save & close the file it will start applying the commits and things an happen:
  • a conflict (which I doubt) if this happens tell me
    and it will open another file where you are going to edit the commit message of the squashed commits
Mohamed Bakli
@mbakli
You mean change this line : # p, pick = use commit to # p, squash = use commit
Vicky Vergara
@cvvergara
Everything that is commented is ignored, so, no, dont uncomment, we dont need instructions on how to use git rebase in the text of the commit
pick 3f5a7a3cc Check interruption in include/dijkstra
squash c1e8d07cd Check interruption in include/dijkstra
squash f67c53d5a Check interruption in include/allpairs
...
Leave the instructions just as they are as comments
when the second file opens then you can make a larger commit message
Mohamed Bakli
@mbakli
To check if I understand well or not, I will only open the first file without changes, right?
Vicky Vergara
@cvvergara
you need to change the comands from pick to squash as in this example
pick 3f5a7a3cc Check interruption in include/dijkstra
squash c1e8d07cd Check interruption in include/dijkstra
squash f67c53d5a Check interruption in include/allpairs
...