pgRouting/pgrouting

Public chat group of the pgRouting repository.

Ashish Kumar

@krashish8

@cvvergara Why do we have this file: https://github.com/pgRouting/pgrouting/blob/master/.github/workflows/documentation.yml ?
The documentation check is already done by the file doc-check.yml.

Btw in documentation.yml

on:
  push:
    branches:
      - main
    tags:
      - '*'

The main branch does not exist yet, it is still the master branch

Vicky Vergara

@cvvergara

well, my attempt is to fail if documentation has a sphinx warning, (of course that was done before your action)
So, it might be more usefull on a PR when doc directory changes
the idea is test fails if the documentation has a warning,
aka treat documentation warnings as errors.

Ashish Kumar

@krashish8

So, it should be something like this?

on:
  pull_request:
    paths:
      - 'doc/**'
      - 'docqueries/**'
      - 'locale/**'

15 replies

Vicky Vergara

@cvvergara

translations can generate sphinx errors

Ashish Kumar

@krashish8

(Updated it)

Vicky Vergara

@cvvergara

more like on changes on po files, or on doc directory

I am confused, let me clear my mind

Ashish Kumar

@krashish8

Btw the changes on po files also lead to a change in the users documentation?

Vicky Vergara

@cvvergara

if doc changes, the shpinx can generate a warning if the change was badly done
if po file changes, then shpinx can generate a warning if the translation was badly done

treat those warnings as errors

That is the idea

make it on a Pull request

The only bad thing I found about actions, with "paths" is that the action can not be enforced

1 reply

I did the following on OSGeoLive:

A step to decide if the action is to be done
https://github.com/OSGeo/OSGeoLive-doc/blob/master/.github/workflows/linkcheck.yml#L22
and ...

Vicky Vergara

@cvvergara

You can not put required on an action that does not run all the time

Ashish Kumar

@krashish8

Oh okay

Vicky Vergara

@cvvergara

`if: env.PROCESS == 'true'``will do the step, and if it is false it will perfrom the step and it will show up as true on the action list

https://github.com/OSGeo/OSGeoLive-doc/actions/runs/582346627

did nothing
https://github.com/OSGeo/OSGeoLive-doc/runs/1937668846?check_suite_focus=true
made the checks:
https://github.com/OSGeo/OSGeoLive-doc/runs/1937668870?check_suite_focus=true

The did nothing "passed" :-)

Veenit Kumar

@Veenits123

Hi everyone, I am not able to edit /etc/postgresql/13/main/postgresql.conf file. I have searched online but didn't get any relevant solution. Please help. Thanks.

I want to change listen_addresses and port inside it.

Daniel Kastl

@dkastl

How do you try to edit? You usually need "sudo" to edit with admin rights.

Veenit Kumar

@Veenits123

It was solved already. Yes, I found I was missing "sudo". Thanks!!

Veenit Kumar

@Veenits123

After running this test tools/testers/doc_queries_generator.pl some tests are showing "FAIL"

Why is this happening, do we need to worry about that?

Thanks!!

Daniel Kastl

@dkastl

Well, the log messages may tell you more about what failed.

Veenit Kumar

@Veenits123

Here the stats :

'docqueries/version/test.conf' => [
                                               {
                                                 'comment' => 'pgr_createTopology, pgr_analyzegraph, and pgr_analyzeOneway tests for any versions.',
                                                 'docqueries/version/doc-full_version.test.sql' => 'FAILED: 8,9c8,9
< ---------+------------+--------------+-----------------+------------------------+------------------------------------------------+-----------+--------+------------
<  3.1.3   | Release    | 2021/01/22   | pgrouting-3.1.3 | Linux-5.4.0-62-generic | PostgreSQL 12.5 (Ubuntu 12.5-0ubuntu0.20.04.1) | GNU-8.4.0 | 1.71.0 | d8d4850af1
---
> ---------+------------+--------------+-----------------+------------------------+---------------------------------------------+-----------+--------+-----------
>  3.1.3   | Release    | 2021/02/23   | pgrouting-3.1.3 | Linux-5.4.0-58-generic | PostgreSQL 13.2 (Ubuntu 13.2-1.pgdg20.04+1) | GNU-9.3.0 | 1.71.0 | 3b5d8d318',
                                                 'docqueries/version/doc-version.test.sql' => 'Passed'
                                               }
                                             ],

Veenit Kumar

@Veenits123

Processing queries docqueries/version/doc-full_version     FAIL

Vicky Vergara

@cvvergara

That uses docqueries directory, which uses the current version to generate all the queries results you see on the documentation.

Of course it fails, on that particular "test" which is not a test, it is what you find in
1) you are compiling on 2021/02/23
2) the Linux you are using is Linux-5.4.0-58-generic
3) you are using postgres 13
4) your compiler is GNU-9.3.0
5) and the hash that was used to compile is 3b5d8d318

The real tests are on the pgtap directory

@Abhik1998 I dont see or answer private messages. they have to be public

Abhik Chakraborty

@Abhik1998

Sir, I have made the changes as commented on the issue

Vicky Vergara

@cvvergara

Thanks, will see them on Saturday

Abhik Chakraborty

@Abhik1998

Okay Cool

Veenit Kumar

@Veenits123

That uses docqueries directory, which uses the current version to generate all the queries results you see on the documentation.
Of course it fails, on that particular "test" which is not a test, it is what you find in
1) you are compiling on 2021/02/23
2) the Linux you are using is Linux-5.4.0-58-generic
3) you are using postgres 13
4) your compiler is GNU-9.3.0
5) and the hash that was used to compile is 3b5d8d318
The real tests are on the pgtap directory

Got it.

You mean this test :

createdb  -U <user> ___pgr___test___
sh ./tools/testers/pg_prove_tests.sh <user>
dropdb  -U <user> ___pgr___test___

I had run this already and everything is OK working fine.

Riya Singh

@riyasingh1004

@cvvergara I have completed all the tasks, can you check and tell if there is any change or mistake.

Vicky Vergara

@cvvergara

Hello students, I will see the tasks today (it is morning now)
I will use the issue on the main repo to check what looks complete.
I will not review the tasks, the tasks will be reviewed on the proposal.
review = check quality and correctness
see = without going into small details, verify that nothing is missing

Saurav Uppoor

@sauravUppoor

Hi @cvvergara , for the proposal I was thinking of implementing the boost::brandes_betweenness_centrality algorithm. However, considering the running time of the algorithm - O(V(V+E)logV) I am not sure if it will be feasible for large graphs. Do you think it will be a good idea to go ahead with this?

Vicky Vergara

@cvvergara

@sauravUppoor looks ok

Veenit Kumar

@Veenits123

Hi, @cvvergara already implemented Graph algorithms in pgRouting we have to consider this https://github.com/pgRouting/pgrouting/tree/master/src as reference ??

Thanks!

Vicky Vergara

@cvvergara

@Veenits123 No. What is in develop.

Veenit Kumar

@Veenits123

Hi, @cvvergara I am planning of implementing Edge Coloring (boost :: edge_coloring ) for Idea 2: "GRAPH C++ Boost graph algorithms" and I have some queries regarding it.
When should I ask them ??
Thanks!

Where communities thrive

People

Repo info

Activity