Phenomic/phenomic

Modern website compiler

Arthur Clemens

@ArthurClemens

Perhaps something has changed in the way blog posts are collected

MoOx

@MoOx

Not sure

Which version you upgraded from?

Arthur Clemens

@ArthurClemens

1.0.0-beta.0

MoOx

@MoOx

Did you checked all release notes ?

Arthur Clemens

@ArthurClemens

roughly

MoOx

@MoOx

Recently I switched webpack version

For collection I think something changed for queries on the client

But I don’t see anything that should show you an error about the socket

Maybe try to check releases notes more carefully :s

Arthur Clemens

@ArthurClemens

that helps :-)

Arthur Clemens

@ArthurClemens

I’ve found the breaking change of the location of content, so blog posts work again

ERR_CONNECTION_REFUSED seems to be a Chrome issue

Now I only have the error I get at build, mentioned above: Cannot read property 'data' of undefined

Arthur Clemens

@ArthurClemens

I’ve put a few console.logs in the @phenomic code to see where this data cannot be read. For some reason, 3 blogs posts result in a failed json (undefined).

Therefore json.data results in an error.

Arthur Clemens

@ArthurClemens

I will do some tests to find out why it trips over these files

Arthur Clemens

@ArthurClemens

Could it be that draft is a reserved word? I’ve been using that in the headers of those markdown files. Apparently Phenomic trips over these.

Arthur Clemens

@ArthurClemens

My posts with draft look like this:

---
title:        "Some title"
date:         "2017-04-11"
draft:        1
---

Content

MoOx

@MoOx

Maybe this is causing an issue

Will have a look later today

Arthur Clemens

@ArthurClemens

:thumbsup:

Another question: playing with a statically rendered site, I am struggling to get the main navigation to highlight the current page. Apparently at build time router.getCurrentLocation().pathname is always /, so I cannot derive which nav button to select as current.

perhaps this is more a react-router issue though

MoOx

@MoOx

I don't have any problem with that on my side

@ArthurClemens can you confirm that draft are killing static rendering?

I think I didn't finish this draft feature lol :/

Arthur Clemens

@ArthurClemens

draft as page prop does kill it with error Cannot read property 'data' of undefined

MoOx

@MoOx

yeah but no issue in dev mode right?

I think that's an easy fix, I guess I could fix it (I am in a train atm) and put a release later today

Arthur Clemens

@ArthurClemens

dev mode works fine

MoOx

@MoOx

ok thanks for the confirmation

I know what to do :)

Arthur Clemens

@ArthurClemens

I don't have any problem with that on my side

Perhaps you don’t use getCurrentLocation

MoOx

@MoOx

indeed

I use router.location.pathname without any problem

Arthur Clemens

@ArthurClemens

that works. Thanks!

BTW https://github.com/phenomic/phenomic/blob/a1d8baa3d9850e27a127f456d7f404368f04309d/examples/react-app-with-basename/App.js#L6 needs to have the right version of history (npm install history@3)

MoOx

@MoOx

react-router should brings the right version itself

so no need to specify it on your side

(r-r v3 use history v2 no?)

Arthur Clemens

@ArthurClemens

"react-router": "^3.2.1” and I got "history": "^3.3.0"

MoOx

@MoOx

right

you are right

https://github.com/ReactTraining/react-router/blob/528e28fa296c3898426623dccdbf7e0a67cefa68/package.json#L37

I guess we don't have anything to do from our side, if people mess with history version I cannot help :D

Arthur Clemens

@ArthurClemens

If I remove history from package.json, it is not automatically found: Can't resolve ‘history'

MoOx

@MoOx

hum weird

like very weird, it's a dep or r-r, so must be there

what npm are you using?

Where communities thrive

People

Repo info

Activity