All custom annotations used in demo must be present in https://github.com/php-annotations/php-annotations/tree/master/demo/annotations folder and registered within https://github.com/php-annotations/php-annotations/blob/master/demo/annotations/Package.php class.
Apparently we've forgot that annotation is used in the demo, when moved them to "standard-annotations" branch: https://github.com/php-annotations/php-annotations/tree/standard-annotations/src/annotations/standard
https://github.com/php-annotations/php-annotations/blob/master/src/annotations/AnnotationManager.php#74 has no range entry either ...
php-annotations/php-annotations#112 - I've created an issue about it
solution is simple: copy over it's definition from that branch into demo namespace & register it within demo annotation package
a PR for that would be awesome
I guess nobody tried to run demo code recently
the "master" branch is supported
the "standard-annotations" isn't
fact, that you've found a bug in "master" branch doesn't mean it's no longer supported. it's bug in demo script after all, that isn't used in production.
:smile:
https://github.com/php-annotations/php-annotations defaults to master ... select standard-annotations branch and I see the /tree/standard-annotations and the correct code!
as I've said in above mentioned task the RangeAnnotation class was forgotten in that move
What's in "standard-annotations" branch are stubs of annotations and aren't generally useful. That's why they were removed from "master" branch and thrus from release.
the
@range and @length in particular are used in demo only to demonstrate some validation possibilities through annotations. but they're not standard and that's why exist only in demo
I see no problem adding "@deprecated" and "@throws" and such annotations back to "master" branch if somebody would create them according to current PHPDoc website specification.
if you wish for example to use new annotations in your code or replace existing ones, that AnnotationManager supports that already
you can even pack your custom annotations into a package (as was done with demo annotations) and ship it through Composer as well.
Actually the target should be to replace all the 'non-PHPDoc' stuff that is being pushed into core PHP by making sure these are available but that will require an extended PHPDoc standard. http://lsces.org.uk/bitweaverdocsPHP/index.html has the proper tree structure now missing from phpDoc2 but ideally one would see exactly what field size is used for variables. Simply forcing 'int' without knowing if its 16,32 or 64bit helps no-one, and being able to extednd
extend that to cover case like age range helps a lot more
if you have any concrete needs, then list them as 1, 2, 3. or even better create issues in GitHub.
I'm at work actually during the day and doing chatting on abstract topics isn't helping anyone and especially my employee :(
once merged that would allow everybody else not to spend time figuring out why this isn't working for them
.
http://hg.lsces.org.uk/bw/bitweaver/externals/php-annotations/ is now up to date, just not sure how to repackages as a push at the moment. Just need to add RangeAnnotation.php, update Package.php in demo/annotations, and the add standalone.php and AutoLoader.php to demo ...
@aik099 - The AutoLoader is just the generic PSR4 loader as provided by php-fig and being used in a demo I left all of the comments. At the moment I can't see how to get github to JUST use one of the commits. I'm normally posting direct to github mirrors so have never actually used the PR process, so how do I get just one commit into a pull request?
- fork a repo
- clone the fork
- in the clone create one branch per PR
- in that branch make necessary commits
- push branch from clone to fork
- submit PR from fork to original repo
While the comments on the AutoLoader could be trimmed, it is 'as supplied' currently. I've cleaned up the standalone.php so it mirrors index.php, but simply commenting the changes would be messy. Simply running standalone.php rather than index.php works and I've managed to leave out a couple of local paths I had earlier.
My next step is to work out my own version of #113 and work out just what is missing for a full set of data validation annotation classes.