Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 08 2021 11:36
    mindplay-dk commented #138
  • Dec 06 2021 16:19
    aik099 closed #138
  • Dec 06 2021 16:19
    aik099 commented #138
  • Dec 04 2021 18:59
    aik099 opened #138
  • Nov 07 2021 18:13
    aik099 closed #137
  • Nov 07 2021 18:13

    aik099 on master

    Improve GitHub Actions workflow… Merge pull request #137 from ai… (compare)

  • Nov 07 2021 18:06
    aik099 opened #137
  • Oct 31 2021 11:28

    aik099 on master

    Change build badge to Travis CI (compare)

  • Oct 31 2021 11:25

    aik099 on master

    Move to GitHub Actions (#136) … (compare)

  • Oct 31 2021 11:25
    aik099 closed #136
  • Oct 31 2021 11:23
    aik099 synchronize #136
  • Oct 31 2021 10:53
    aik099 synchronize #136
  • Oct 31 2021 10:40
    aik099 opened #136
  • Jan 29 2021 13:19
    mindplay-dk opened #135
  • Jan 29 2021 00:21
    szepeviktor commented #134
  • Jan 28 2021 20:49
    aik099 commented #134
  • Jan 28 2021 20:49

    aik099 on master

    Improve CI All there is left f… Merge pull request #134 from sz… (compare)

  • Jan 28 2021 20:49
    aik099 closed #134
  • Jan 25 2021 16:48
    szepeviktor closed #133
  • Jan 25 2021 16:47
    szepeviktor opened #134
Alex
@aik099
As I've said above it's in "standard-annotations" branch
php-annotations/php-annotations#112 - I've created an issue about it
solution is simple: copy over it's definition from that branch into demo namespace & register it within demo annotation package
a PR for that would be awesome
I guess nobody tried to run demo code recently
Lester Caine
@lsces
Would have been nice if you flagged that master branch is defunct and no longer supported!
Alex
@aik099
it's otherwise
the "master" branch is supported
the "standard-annotations" isn't
fact, that you've found a bug in "master" branch doesn't mean it's no longer supported. it's bug in demo script after all, that isn't used in production.
:smile:
Lester Caine
@lsces
https://github.com/php-annotations/php-annotations defaults to master ... select standard-annotations branch and I see the /tree/standard-annotations and the correct code!
Alex
@aik099
in old days standard annotations were part of master branch. since they doesn't help anybody we've moved them to separate branch for review and copied ones, needed by demo script to demo namespace
as I've said in above mentioned task the RangeAnnotation class was forgotten in that move
Lester Caine
@lsces
I'm getting lost here ... range and length are just the annotations I want to use as standard annotations ... but they are not supplied as standard?
Alex
@aik099
They are not standard annotations. See PHPDoc: https://www.phpdoc.org/docs/latest/index.html
What's in "standard-annotations" branch are stubs of annotations and aren't generally useful. That's why they were removed from "master" branch and thrus from release.
the @range and @length in particular are used in demo only to demonstrate some validation possibilities through annotations. but they're not standard and that's why exist only in demo
I see no problem adding "@deprecated" and "@throws" and such annotations back to "master" branch if somebody would create them according to current PHPDoc website specification.
Lester Caine
@lsces
That is not relevant ... the whole point of annotation is to add the missing metadata ... which is why I still use the original phpDocumentor. The current one lost many of the 'standard features' that were provided!
Alex
@aik099
the php-annotations implementation of PHPDoc annotations is standard against current PHPDoc standard version
if you wish for example to use new annotations in your code or replace existing ones, that AnnotationManager supports that already
you can even pack your custom annotations into a package (as was done with demo annotations) and ship it through Composer as well.
Lester Caine
@lsces
Actually the target should be to replace all the 'non-PHPDoc' stuff that is being pushed into core PHP by making sure these are available but that will require an extended PHPDoc standard. http://lsces.org.uk/bitweaverdocsPHP/index.html has the proper tree structure now missing from phpDoc2 but ideally one would see exactly what field size is used for variables. Simply forcing 'int' without knowing if its 16,32 or 64bit helps no-one, and being able to extednd
extend that to cover case like age range helps a lot more
Alex
@aik099
you seem to be discussing different topics in parallel here. that makes it harder to understand what you actually is expecting from me in this discussion
if you have any concrete needs, then list them as 1, 2, 3. or even better create issues in GitHub.
I'm at work actually during the day and doing chatting on abstract topics isn't helping anyone and especially my employee :(
Lester Caine
@lsces
I'm still 'learning the limitations' ... but now I have a working setup I can put back the stuff I was expecting to get. Just the hassle with the Range wasted a lot of my time when I simply expected the demo to work :(
Alex
@aik099
if you can, then please submit PR's for:
  • autoloader
  • putting @range annotations in demo namespace
once merged that would allow everybody else not to spend time figuring out why this isn't working for them
.
Lester Caine
@lsces
Have a working setup ... back later to document ... standalone.php demo
Lester Caine
@lsces
http://hg.lsces.org.uk/bw/bitweaver/externals/php-annotations/ is now up to date, just not sure how to repackages as a push at the moment. Just need to add RangeAnnotation.php, update Package.php in demo/annotations, and the add standalone.php and AutoLoader.php to demo ...
Alex
@aik099
OK. Waiting for PR's then.
Lester Caine
@lsces
@aik099 - The AutoLoader is just the generic PSR4 loader as provided by php-fig and being used in a demo I left all of the comments. At the moment I can't see how to get github to JUST use one of the commits. I'm normally posting direct to github mirrors so have never actually used the PR process, so how do I get just one commit into a pull request?
Alex
@aik099
  1. fork a repo
  2. clone the fork
  3. in the clone create one branch per PR
  4. in that branch make necessary commits
  5. push branch from clone to fork
  6. submit PR from fork to original repo
Lester Caine
@lsces
OK ... looks like I have to kill the fork and start again ... You are OK with the Package commit? ... but I need to rework the non-composer one?
Alex
@aik099
yes, new annotation part looks good. the autoloader pr needs some changes.
Lester Caine
@lsces
While the comments on the AutoLoader could be trimmed, it is 'as supplied' currently. I've cleaned up the standalone.php so it mirrors index.php, but simply commenting the changes would be messy. Simply running standalone.php rather than index.php works and I've managed to leave out a couple of local paths I had earlier.
My next step is to work out my own version of #113 and work out just what is missing for a full set of data validation annotation classes.