Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
panki3a
@panki3a
thats all
Tobias Nyholm
@Nyholm
Lets rename it, It might have some issues with other versions. I just copied that function from Symfony 3.3
panki3a
@panki3a
you will rename it ?
panki3a
@panki3a
its in vendor/cache/cache-bundle/src/DataCollector/CacheDataCollector.php line 218
Tobias Nyholm
@Nyholm
Of off to lunch in a minute. I may do it later if you you’ve done it
panki3a
@panki3a
i will look on it
php-cache/cache-bundle#84
look at it if you will have a time
Tobias Nyholm
@Nyholm
Thank you
panki3a
@panki3a
can you make new tag, after you merge it ?
Tobias Nyholm
@Nyholm
Naturally
panki3a
@panki3a
are you clouse my PR ?
Tobias Nyholm
@Nyholm
I gave you a comment: php-cache/cache-bundle#84
panki3a
@panki3a
but i dont know what to do right now ...
iam not involvet in this cache-bundle, i only fix this fatal
so ... if you dont want to merge it ... i cant fix it
Tobias Nyholm
@Nyholm
Just rename the method and that single method call
Nothing more than that.
Also, turn it back to private
panki3a
@panki3a
sorry, but i cant look on it right now
Tobias Nyholm
@Nyholm
No worries.
panki3a
@panki3a
may be tomorrow
Tobias Nyholm
@Nyholm
I’ll fix it now
Tobias Nyholm
@Nyholm
You got a new release now
Thank you
panki3a
@panki3a
thank you too,
we will install it right now
Tobias Nyholm
@Nyholm
Great.
panki3a
@panki3a
i can give you feedback
Tobias Nyholm
@Nyholm
We should have test covering that class to avoid this misstake
panki3a
@panki3a
hi, will you try to add symfony 4.0 support in php-cache/cache-bundle and php-cache/adapter-bundle ?
Tobias Nyholm
@Nyholm
Sure, lets put in some efforts to fix that
panki3a
@panki3a
@Nyholm i made PR to fix deprication in php-cache/cache-bundle#88
panki3a
@panki3a
@Nyholm can you make new tag 1.0.4 from master ?
Guy Radford
@guyradford
Hi, is there a plan to tag the https://github.com/php-cache/array-adapter repo with the recent bug fixes?
Tobias Nyholm
@Nyholm
Sure
@guyradford Fixed now
@panki3a Fixed.
Btw, feel free to tag new versions yourself, you got that permission, right?
Guy Radford
@guyradford
Thank you.... I guess the permission comment wasnt aimed at me?
Tobias Nyholm
@Nyholm
Na, not yet at least :)
Massimo Chiarillo
@massimo_me_twitter
Hi :)
wsm
@swim
Hello all, does anyone know what benefits the php-cache filesystem has over the symfony filesystem adapter? Both seem to exist in the same space
Egor
@egbuk_gitlab
I've encountered this php-cache/issues#134 issue with symfony 3.4.20. I'm really puzzled, the view can be found in bundle directory but symfony ignores it. Has anyone found an adequate way to fix this?
Matthias Breddin
@lunetics
@Nyholm happy new year...
Tobias Nyholm
@Nyholm
@lunetics
Happy new year
Desjardins Jérôme
@jewome62
Hello, there are no tag on main repo cache since 1,5 year. This is normal ?
https://github.com/php-cache/cache/compare/1.0.0...master
Daniel Bannert
@prisis
All of the maintainer didn't have much time to work on this, but this will change soon... And the v1 ist very stable