Is there a reason to use sed for this rather than preg_replace, as you're already reading in the file anyway?
I'm only reading the first 1024 bytes to see whether it is necessary to parse the file at all. But sure I could do all of that in PHP.
Also skipping all the output might make it faster as well...
I had an interesting discussion yesterday eventing with Marco Pivetta. The main question was whether it makes sense to split the current SVN repo up into multiple GIT-repos. I know it was me that started with that but he made some good points to not split it up. The main reason being that it makes more complicated than necessary to keep track of changes over multiple repositories.
So is there actually a reason why we should split it up?
It will make a lot of background-stuff easier when its only one repo as there is no need to change working directory all the time while comparing git hashes
Everyone with karma can access everything. So far it should is not be necessary to restrict access to certain parts of the repo to certain people
It should still be possible to require at least two reviews by code-owners to merge PRs into the repo. And that's even easier when everyone has the same access for smaller languages
Those are some interesting points 🤔
But touch the Karma system isn’t something that I would do
I wouldn't want to touch the karma system!
I thought i had seen the karma-files lying around somewhere but I can't find it at the moment.
So can someone with access to them perhaps have a look whether we currently have different karma for the different translations?
From a Filesystem POV we currently have the docs in SVN subdivided in multiple repos as every language has their own set of trunk, branches and tags folder. That and possibly different karma for the different languages would IMO speak for different GIT-repos for the different languages. But if all have the same karma, I'd rather try to use ONE git-repo for all the names...
Now I understand your point, would be easier to track/manage things
THANKS! I knew I had seen it somewhere!
But that file shows that access to the different languages is already restricted to different people so my initial approach of moving each language to its own repo seems to be the one to follow. At lesat if we say we "just" want to move docs from SVN to git.
Access is already restricted on a language level
Tags and Branches are not possible on a level above languages
Even though diffs currently are possible across languages I have no insight on how often they are actually done
So how do we want to proceed? One Repo per language or one repo for all?
@nikic are they synced back or is doc-en already live?
We're currently in the process of making the toolage work with a
repo that's constantly pulled from SVN... Using some filter-branch magic. But after a filter branch the connection between SVN and the new head is lost. So I'm currently figuring out how to solve that....
A y insights into how git svn keeps track of the svn-git commit hash association?
So far I
@beberlei It's a read-only mirror, but I have a github webhook to merge PRs into SVN
@heiglandreas sorry no clue :( is this an intermediate step before fully migrating? what would be the steps there.
@nikic i just realized my patch was reverted for good reasons, so the doc chaange is not needed anyways :D
@heiglandreas Maybe avoid the issue by also keeping the original branch, updating that one and then copying over the commits ... or something?