by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Daniel Rose
    @daniel-rose
    ah okay
    but what is the default case?
    Toon Verwerft
    @veewee
    By default the absolute path is generated by \Symfony\Component\Process\ExecutableFinder
    or relative if the extraDirs matches (so when the binDir is being used)
    Daniel Rose
    @daniel-rose
    for this, i must fill the extraDirs in composer.json
    Toon Verwerft
    @veewee
    no, it uses the binDir from the grumphp.yml file
    (which mostly points to the bin directory in composer.json)
    Daniel Rose
    @daniel-rose
    bin_dir: "./vendor/bin"
    this entry
    ?
    Toon Verwerft
    @veewee
    indeed
    Daniel Rose
    @daniel-rose
    okay is use this, but the path in the git-hook file will absolute.
    Toon Verwerft
    @veewee
    That is the 'forceUnix' part in your diff: it will use pathinfo to force a unix path separator which will quote the git hook arguments on windows
    The easiest way to solve this issue locally is to run ./vendor/bin/grumphp git:init in the environment you commit
    Daniel Rose
    @daniel-rose
    okay
    that solution is already added to my robofile
    but thanks
    Toon Verwerft
    @veewee
    no problem! We'll surely have to investigate the issue further
    Daniel Rose
    @daniel-rose
    thank u
    Lars Roettig
    @larsroettig
    Hi , have you good starting issuse for me i will contribition to this nice pice of software
    I am already Maintainer at Magento2 i like phpro/grumphp and will contribute
    Lander Vanderstraeten
    @Landerstraeten
    Hi @larsroettig. Thanks for your interest! We currenlty have an open PR for git hook variables for vagrant. See phpro/grumphp#544. It would be nice to have the same for docker. There isnโ€™t yet an issue for it. @veewee had found an interesting starting point: https://github.com/ModestCoders/magento2-dockergento/tree/master/config/grumphp/hooks
    Toon Verwerft
    @veewee

    @Landerstraeten : I've gone through the PRs. I'll be working on opensource next Thursday (6/12). The plan is to release the latest patch (0.14.3)
    Next up is the grumpy-seventies release being 0.15.0 which will also happen next Thursday (6/12)

    Previous month we tested the grumpy-seventies thoroughly, but can you confirm that everything is still working as expected?

    Can you also follow up the open issues and let me know it is ok to release?

    Let's celebrate "Sinterklaas" with 2 releases :)

    Roman Glushko
    @roma-glushko
    Hi folks ๐Ÿ‘‹Is there any useful way to run Grumphp in pipelines to verify that pushed code in PRs are good according to all defined tasks?
    Roman Glushko
    @roma-glushko
    There is a way to just run "grumphp run" and check the whole project every time, but it's not really cost-effective for big codebase and pay-as-you-run pipeline providers like Github Actions
    Toon Verwerft
    @veewee
    we always run the complete test suite, how would you otherwise know if everything is ok?
    We're currently working on a way to run the tasks in parallel, that will most likely improve the cost
    Roman Glushko
    @roma-glushko
    Hi @veewee thank you for the replay. I don' t want to run tasks for the whole project if my PR changes a couple of files. This is the main goal I think
    So far I came with this hack
    DIFF=$(git diff ${currentBranch} ${destinationBranch} -r -p -m -M --full-index | cat)
    if [ -z "$DIFF" ]; then
        echo "No files to check";
        exit 0;
    else
        echo "${DIFF}" | ./vendor/bin/grumphp git:pre-commit || exit $?
    fi
    Roman Glushko
    @roma-glushko
    We're currently working on a way to run the tasks in parallel, that will most likely improve the cost
    Is there any PR/task I can track to see the progress?
    Toon Verwerft
    @veewee

    PR for parallel tasks can be followed here: phpro/grumphp#741
    (Still WIP and lots of work todo though - you can always play around with it and provide feedback)

    Another solution for your issue could be this feature request:
    phpro/grumphp#394
    I guess it won't be hard to implement this, but nobody picked it up yet.

    on the other hand, it will work similar to the hack you provided. So the hack is kinda the solution as well :)
    it would recommend working with a list of files instead of a diff for the run command if you want to work on the feature though.
    Roman Glushko
    @roma-glushko
    @veewee that's sweet ๐Ÿ™ŒI will review references and discussion in phpro/grumphp#394
    Thank you for the help ๐Ÿš€
    vinitmirkar
    @vinitmirkar
    Hi
    runnig testsuite with phpcs failed but not giving any error
    Toon Verwerft
    @veewee
    Feel free to provide any additional information te reproduce.