Where communities thrive

Join over 1.5M+ people
Join over 100K+ communities
Free without limits
Create your own community

Explore more communities

phpspec/prophecy

Highly opinionated mocking framework for PHP 5.3+

People

Repo info

Activity

Eddie Jaoude

@eddiejaoude

I get this error method Double\Symfony\Component\Translation\LoggingTranslator\P4::getMessages() is not defined.

The code https://github.com/eddiejaoude/symfony-translation-twig-collection-bundle/blob/master/src/EddieJaoude/Bundle/SymfonyTranslationTwigCollectionBundle/Twig/TranslationLengthExtension.php#L47

The Spec https://github.com/eddiejaoude/symfony-translation-twig-collection-bundle/blob/master/test/Spec/EddieJaoude/Bundle/SymfonyTranslationTwigCollectionBundle/Twig/TranslationLengthExtensionSpec.php#L32

I didnt write the code hence the Spec was written afterwards - I have now bundled the code that was supplied from help on a StackOverFlow question & want to cover it with a Spec

Christophe Coevoet

@stof

getMessages is not part of the Symfony Translator interface, and so is not implemented in the LoggingTranslator

Eddie Jaoude

@eddiejaoude

thank you! it was a long day yesterday, I dont know what I was doing :(

Mark Harding

@markharding

Hey. Is it possible to set the construct variables of a dependency

Christophe Coevoet

@stof

PhpSpec is mocking collaborators and does not call their constructors

CarstenHoyer

@CarstenHoyer

This message was deleted

Kévin Liagre

@BboyKeen

Does it makes sense to spec simple model class ? I've seen this a lot in the Sylius project

Ciaran McNulty

@ciaranmcnulty

Sure

Kévin Liagre

@BboyKeen

@ciaranmcnulty Even for simple getters/setters ? Seems like overkill, no ?
What should I write for example for a "name" field ?
it_should_return_a_name() ?
it_should_have_name_mutable() ?

Ciaran McNulty

@ciaranmcnulty

Oh that sort of 'model' :-)

Doesn't hurt if it helps you create it

Kévin Liagre

@BboyKeen

Yes, for complex model, I already use it

Ciaran McNulty

@ciaranmcnulty

I tend to because I find stopping my TDD workflow in those cases slows me down slightly

DTOs don't specifically need it if they have no logic

But I'd fix it by pushing logic into the model rather than by skipping the tests

Kévin Liagre

@BboyKeen

Right, that's what I'm trying to do.

And you always start by specifiying your class ? Looks like I still need a lot of training for complex cases :D

Ciaran McNulty

@ciaranmcnulty

I do for core stuff but it's because I use PhpSpec so it does magic for me

It's either that or get some other tool to generate the class eh

Kévin Liagre

@BboyKeen

Fine, I'll try to let PhpSpec do the magic for me too :)

Ciaran McNulty

@ciaranmcnulty

Don't feel you have to, but thinking 'is this one of the ones I spec?' Inside the core is an overhead for me

That said I don't spec adapters

Christophe Coevoet

@stof

@ciaranmcnulty which is logical, as it would force you to mock something you don't own :smile:

Ciaran McNulty

@ciaranmcnulty

I'm not 100% anti that if it adds something to your workflow. It's just a waste of time most of the time

I have some specs for adapters that just check it fits an interface, artefacts of my workflow

I could delete them I guess

Mohamed Cherif Bouchelaghem

@cherifGsoul

hi, ask, how to pass callable as argument?

Mohamed Cherif Bouchelaghem

@cherifGsoul

I try to go with this phpspec/phpspec#653

I want to test tactician middelware

Kévin Liagre

@BboyKeen

Hi, I've taken a look at the specificications written in the Sylius project to use them as inspiration but I had the feeling that the specifications were just repeating the same source code as in the final class except they added the suffixes willReturn, shouldBeCalled, etc.

Is this really the way PhpSpec should be used ?

Do you guys have any good and complex examples I can follow ? (by complex I mean classes doing a bit more than just echoing "Hello World" )