These are chat archives for pi-hole/AdminLTE

16th
Apr 2016
G
@Windyo
Apr 16 2016 14:36
Hi there
Adam Warner
@PromoFaux
Apr 16 2016 14:37
hey!
G
@Windyo
Apr 16 2016 14:37
Hey @PromoFaux ! Thanks for the fix, finishing up the install as we speak
:)
:)
Adam Warner
@PromoFaux
Apr 16 2016 14:38
Excellent! I've also made a couple of other changes...
G
@Windyo
Apr 16 2016 14:43
okay I seem to be back
strangely enough the listen-adress in pihole.conf wasn't set to the pihole adress, so I had no internet access for a while after update. Anywho I must have done somthing wrong, because I don't see the changes :(
and the changelog seems awesome :)
Adam Warner
@PromoFaux
Apr 16 2016 14:45
easiest way to update the dashboard is with pihole -u and then you don't have to go through the whole install process
you may need to reset the AdminLTE folder.
cd /var/www/html/admin
sudo git fetch
sudo git reset --hard
sudo git checkout master
sudo git pull
G
@Windyo
Apr 16 2016 14:48
haha I was actually reading that thread in bug #73 thinking that could be it. Thanks
@PromoFaux it's just perfect.
Adam Warner
@PromoFaux
Apr 16 2016 14:52
Excellent, glad you like it!
I think it's about time we put hostnames in there...
G
@Windyo
Apr 16 2016 14:53
Yeah I was actually going to play around with it
I can't move much today so I'm spending most of my time geeking around anyways
Adam Warner
@PromoFaux
Apr 16 2016 14:54
:) i've been doing similar! Though I'm going out for drinks soon so hooray!
G
@Windyo
Apr 16 2016 14:55
Seems there's a small bug in how you handle the transition between high resolutions and low resolutions for the "Top Advertisers" table. Not that good at php but i'll try to write youa well-documented issue at least ;) AdminLTE tracker I imagine ?
And drinks are nice :) probably will do the same thing if I can get up :)
Thanks again for the release, that was hella quick
Adam Warner
@PromoFaux
Apr 16 2016 14:55
Yeah, AdminLTE repo would be good please! Do you mean when you resize the window?
(If it's any consolation, I don't know any PHP at all... Made all the changes by looking at what was already written, and a lot of googling!)
G
@Windyo
Apr 16 2016 14:57
AdminLTE it is !
Well I'm not done testing, but "Top Advertisers" doesn't seem to reserve its own display space. Even on 4k resolution the column it's clipped, resizing the window makes it worse up until it changes to "tablet" format. I'll test with multiple native resolutiosn/browsers to see if that changes how the bug delcares
(I get it, I resurected a dead javascript project for my own ends a while back and now I'm maintaining it more or less. Don't know a thing about javascript either. Google can get you places :))
Adam Warner
@PromoFaux
Apr 16 2016 15:05
Sounds like it could be a bootstrap issue to me...

I figure as long as you understand the logic behind what you're trying to do, you can code in pretty much any language with a little help from google.

Hell, I'm paid to be a C# developer, and I wouldn't say I was even fluent in that!

G
@Windyo
Apr 16 2016 15:22
haha