These are chat archives for pi-hole/AdminLTE

30th
Jun 2016
Sander
@brantje
Jun 30 2016 16:26
Almost done with translations
Adam Warner
@PromoFaux
Jun 30 2016 16:28
You're on fire!
Mark Drobnak
@Mcat12
Jun 30 2016 16:28
What're you using to translate?
Sander
@brantje
Jun 30 2016 16:28
Haha nice fact
My full name is Sander Brand
Brand is dutch for fire
:P
Angular
Is easy as
blob
it's*
I can translate it to Dutch
A friend of mine will translate to Spanish
Adam Warner
@PromoFaux
Jun 30 2016 16:32
I can provide English translations
Sander
@brantje
Jun 30 2016 16:33
xD :P but it's already English :P?
Adam Warner
@PromoFaux
Jun 30 2016 16:33
True English
😂
Sander
@brantje
Jun 30 2016 16:34
I'll upload the JSON when i'm done
Sander
@brantje
Jun 30 2016 16:43
1 page to go
Sander
@brantje
Jun 30 2016 17:05
Done
Mark Drobnak
@Mcat12
Jun 30 2016 17:07
Is that the variable->English binding?
Sander
@brantje
Jun 30 2016 17:07
yea
Maybe better to use key's?
like TOGGLE_NAV, OSS_ADB, etc
Mark Drobnak
@Mcat12
Jun 30 2016 17:08
Maybe.
Sander
@brantje
Jun 30 2016 17:09
Now when you open index.html you'll see the text being translated
But if i uses keys it would be abit harder to read the text eg: {{ 'UPDATE_AVAILBLE_PYHOLE' }} = There's an update available for this Pi-hole
Your call =)
Mark Drobnak
@Mcat12
Jun 30 2016 17:13
Keys are fine, as long as they're not something like "key_0568". The "UPDATE-AVAILABLE-PYHOLE" should work fine.
Sander
@brantje
Jun 30 2016 17:13
Ok =) will do after i finish my lasagna
Sander
@brantje
Jun 30 2016 18:32
Enjoy =)
Sander
@brantje
Jun 30 2016 19:01
blob
Mark Drobnak
@Mcat12
Jun 30 2016 19:03
How do you feel about angular 1 vs 2?
Sander
@brantje
Jun 30 2016 19:03
Waiting till stable hits
Then i give it a try =)
Mark Drobnak
@Mcat12
Jun 30 2016 19:06
With 2 so close to release, I'm not sure whether we should use 1.5 or 2...
Sander
@brantje
Jun 30 2016 19:07
Well, imo most things still need to be ported to 2
directives
graph libraries
Mark Drobnak
@Mcat12
Jun 30 2016 19:07
So, probably use 1.5 until it is released and confirmed stable.
Sander
@brantje
Jun 30 2016 19:08
Yea
I'll keep an eye on the things i use
If all of them are ready for 2, then i'll make an new branch with the angular 2.0 things
As you might know, its completely different
Mark Drobnak
@Mcat12
Jun 30 2016 19:09
I've looked into it a little bit, but still need to look more
Sander
@brantje
Jun 30 2016 19:10
I might get a Angular 2 training course from my work
I know some team members of ownCloud / Nextcloud, they might be willing to help translating