These are chat archives for pixijs/pixi.js

6th
Jun 2017
Yeling Shi
@shiyeling
Jun 06 2017 00:50
All too busy i guess
Matt Hicks
@darkfrog26
Jun 06 2017 14:41
based on the documentation Texture is not a BaseTexture, but I see in examples where it's used as one...
it only extends EventEmitter
oh, it's because the docs are wrong for PIXI.Texture constructor
it checks if it's a Texture and grabs the base texture if it is.
Chad Engler
@englercj
Jun 06 2017 16:11
How are the docs wrong? It takes a baseTexture as the first parameter, passing a Texture is incorrect but we fix it for you
ᦖєgιт
@LegitSoulja
Jun 06 2017 16:12
The docs are messed up @englercj
Ivan Popelyshev
@ivanpopelyshev
Jun 06 2017 16:12
whats up with docs
ᦖєgιт
@LegitSoulja
Jun 06 2017 16:12
So messed up, it's better off reading the uncompiled source
Ivan Popelyshev
@ivanpopelyshev
Jun 06 2017 16:12
docs are generated from comments
yeah, @englercj is right about that thing with Texture- "we fix it for you" is a common behaviour in js )
Chad Engler
@englercj
Jun 06 2017 16:13
It isn't so much that you can pass a Texture into the ctor, more that people messed it up so much we just decided to add some "fix it" code to help prevent issues
ᦖєgιт
@LegitSoulja
Jun 06 2017 16:13
Best not to read the comments
Chad Engler
@englercj
Jun 06 2017 16:14
Then improve them? Or report issues?
Just ignoring the problem doesn't help anyone
ᦖєgιт
@LegitSoulja
Jun 06 2017 16:14
Is it my problem/issue?
I'm busy 24/7, I work. I was just saying, the docs are messed up.
Ivan Popelyshev
@ivanpopelyshev
Jun 06 2017 16:15
@LegitSoulja what's your point? People are supposed to look inside pixi sources. docs are for those who are afraid
we need more examples, but that's not about core docs, i suppose
ᦖєgιт
@LegitSoulja
Jun 06 2017 16:15
No
Ivan Popelyshev
@ivanpopelyshev
Jun 06 2017 16:16
the descriptions of methods, fields and params are close enough.
I think we need more examples right in docs for classes
Matt Hicks
@darkfrog26
Jun 06 2017 20:07
okay, I'm more used to a type-safe methodology where the working types are outlined properly instead of "this is what we want, but we'll fix it for you if you enter some other ones..."