Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
matrixbot
@matrixbot
ehuelsmann Hi
Erik Huelsmann
@ehuelsmann
@pjlsergeant hi! did you notice my PRs?
Erik Huelsmann
@ehuelsmann
@vti around?
@vti the newlines have been fixed in release 0.58
@vti which has been released a few hours ago.
Erik Huelsmann
@ehuelsmann
@kwakwaversal : I have an idea what's going on, yes.
Test::Builder is implemented on top of Test2; however, I think the two are incompatible in what they do.
I think it would be best if I could identify (possibly after talking to the author of Test2::Suite) how to not use Test::Builder.
Erik Huelsmann
@ehuelsmann
@kwakwaversal I have a branch now which has the reverse problem: it doesn't work with Test::More.
(but it does work with Test2::Bundle::More!)
Erik Huelsmann
@ehuelsmann
@vti , @latk : I've changed the way the distribution is generated so your contributions are now recognised on MetaCPAN.
Erik Huelsmann
@ehuelsmann
@kwakwaversal , do you have the ability to test that branch? I think I might have solved the bleeding through.
Paul Williams
@kwakwaversal
Unfortunately I no longer work at the place where I came across that issue. If I get chance I'll test it against the branch I created to replicate the original issue. Been a while since I've thought about it!
Erik Huelsmann
@ehuelsmann
@kwakwaversal , oh! actually, I can probably too.
I should have that somewhere.
are you still using Test::BDD::Cucumber though?
Erik Huelsmann
@ehuelsmann
@kwakwaversal yes! the branch indeed solves that!
there's one problem with your example: the stepfile should not end in "done_testing".
Erik Huelsmann
@ehuelsmann
@kwakwaversal do you know if the places you were using Test::BDD::Cucumber were using Test::More's $TODO variable?
Erik Huelsmann
@ehuelsmann
@pjlsergeant hi. did you see my mail, requesting PAUSE upload permissions for Gherkin too?
I've brought that up to date (parser-wise) with the rest of Cucumber 7.0
Erik Huelsmann
@ehuelsmann
@pjlsergeant I'm pretty sure you didn't see the mail until yesterday: I sent it to the wrong Peter (who ignored it upon receipt... instead of notifying me of my mistake)
sorry about that.
Erik Huelsmann
@ehuelsmann
hi.
Erik Huelsmann
@ehuelsmann
hi
Erik Huelsmann
@ehuelsmann
morning.
Erik Huelsmann
@ehuelsmann
hi.
Erik Huelsmann
@ehuelsmann
hi
Erik Huelsmann
@ehuelsmann
hi
Erik Huelsmann
@ehuelsmann
hi
Ben Little
@littlebenlittle

Hello. Lately I have been experimenting with cucumber-style tests in our automated builds. I would like those builds to fail when feature files contain steps that don't have a corresponding definition. As of pherkin 0.67, the default behavior is to skip these steps, but the process still returns exit code 0. I tried adding an extension to hook into the app and collect steps that aren't defined, but undefined steps don't appear to call the pre- or post-step hooks.

Right now I'm resorting to using the JSON output option and parsing it in a separate process. This works, but feels a bit inelegant and I'm wondering if I might be missing the obvious solution 🙃

Any ideas on how I can catch undefined steps, alert the user, and cause the process to send a failing exit code?

Erik Huelsmann
@ehuelsmann
hi!
@littlebenlittle did 0.66 actually fail on those steps?
if it did, can you create a regression ticket in github?
Ben Little
@littlebenlittle
I didn't check any prior versions, but I will now
Erik Huelsmann
@ehuelsmann
it's 1am here now, so, I'll be going off to sleep shortly, but I'll have a look tomorrow.
and it's easier if this is a regression, because that changes behaviour back to how it used to be instead of to new behaviour.
Ben Little
@littlebenlittle
That's a-okay, thanks for the reply! I'll have some examples for when you get back
Erik Huelsmann
@ehuelsmann
thanks!
Ben Little
@littlebenlittle
So it does appear that the last three versions (67, 66, 64) all behave the same way. I created a pull request that demonstrates the docker setup I used.
Erik Huelsmann
@ehuelsmann
@littlebenlittle I'm going to change the behaviour of the pherkinbinary to return an exit code to indicate missing steps and I'll add a setting to the prove integration to make it fail steps where the step function is missing.
Erik Huelsmann
@ehuelsmann
@littlebenlittle if/when you're around: I've created a branch which adds the --strict option just like it exists in Cucumber.
@littlebenlittle could you test it and tell me if that's what you were looking for, so I can merge?
Erik Huelsmann
@ehuelsmann
@littlebenlittle hi. I'll proceed and merge that branch. I hope it does what you want.
Erik Huelsmann
@ehuelsmann
@littlebenlittle the --strict option has been released.
Erik Huelsmann
@ehuelsmann
Just released 0.71 with minor fixes.
Erik Huelsmann
@ehuelsmann
hi
matrixbot
@matrixbot
ehuelsmann Hi
matrixbot
@matrixbot
ehuelsmann Hi