These are chat archives for pjlsergeant/test-bdd-cucumber-perl

4th
Sep 2016
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:07
@pjlsergeant there's a PR with localization examples in Spanish.
@pjlsergeant should we accept that?
@pjlsergeant and what about the 2 POD fix PRs?
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:14
All done
Thanks for the reminder
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:14
welcome :-)
now I can start working on more PRs !
Did you see Yves's feedback that it's all working regarding parallellization?
(with prove)
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:16
Yah, although he also mentioned he wasn't getting actual parallelization
I've asked him for details
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:16
Hmm. I should ask him about that tonight.
I did see that remark, but haven't heard about it since.
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:16
I wonder if he thinks that it should work doing scenarios simulatenously
I'd also like to get his issue with tagspecs not being passed through fixed
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:17
Ok. I'd like to add it all to the docs.
He knows he shouldn't be getting scenarios simultaneously.
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:18
If you promise to only accept doc patches for now, I'll give you a commit bit :)
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:18
although at the moment he thinks he wants that later on.
sure. that's easy enough.
I'll gladly accept the commit bit :-) thanks!
I'll still ask you to review all my own doc changes.
so that we have review on each PR getting in.
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:24
@pjlsergeant question regarding the .pherkin.yaml file: Yves would like to be able to allow environment variable expansion in it, when the key's value starts with ${ and ends with } and the text in between is a valid env var.
we could do the expansion in App::Pherkin
mind me writing a preprocessor like that?
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:25
I wonder if that's the right syntax for it
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:26
ok. I'm happy to do any syntax you think works.
Maybe you're right, and that is a sensible syntax
I wonder if it's becoming time to split the pherkin config file in to its own module
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:28
that's probably a good next step.
yes.
you want me to use the syntaxes provided there? with the colon separator for defaults?
Peter Sergeant
@pjlsergeant
Sep 04 2016 08:30
seems reasonable. What do you think?
Erik Huelsmann
@ehuelsmann
Sep 04 2016 08:31
I think it's a good syntax. and a very important enhancement over Yves's proposal.
(as his doesn't allow for defaults)
Erik Huelsmann
@ehuelsmann
Sep 04 2016 10:33
@pjlsergeant now that you have a bit more time to think; I'm wondering what the 'tag_scheme' is doing here: the argument is received, but not passed on, nor documented on any of the callers: https://github.com/pjlsergeant/test-bdd-cucumber-perl/blob/master/lib/Test/BDD/Cucumber/Parser.pm#L72
can I clean it up in the call chain?
Erik Huelsmann
@ehuelsmann
Sep 04 2016 10:40
asking because it confused me before.
I'll be looking at the parallellization and options pass through in a bit.
Erik Huelsmann
@ehuelsmann
Sep 04 2016 12:36
@pjlsergeant if/when you have time: I've submitted 2 more PRs (with code changes this time)