Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 15 21:41
    bmish edited #146
  • Jan 15 21:00
    bmish edited #146
  • Jan 15 20:57
    coveralls commented #146
  • Jan 15 20:57
    coveralls commented #146
  • Jan 15 20:57
    coveralls commented #146
  • Jan 15 20:57
    coveralls commented #146
  • Jan 15 20:56
    bmish opened #146
  • Jan 15 19:35
    coveralls commented #145
  • Jan 15 19:35
    coveralls commented #145
  • Jan 15 19:35
    coveralls commented #145
  • Jan 15 19:35
    coveralls commented #145
  • Jan 15 19:35
    coveralls commented #145
  • Jan 15 19:34
    coveralls commented #145
  • Jan 15 19:34
    coveralls commented #145
  • Jan 15 19:34
    coveralls commented #145
  • Jan 15 19:32
    bmish opened #145
  • Jan 15 19:30
    bmish commented #144
  • Jan 15 19:11

    platinumazure on master

    Fix: false positive for tests i… (compare)

  • Jan 15 19:11
    platinumazure closed #143
  • Jan 15 19:11
    platinumazure closed #142
Kevin Partington
@platinumazure
Looks good, so I'll go ahead and merge to master. Thanks so much for your patience (both with my comments and with my work schedule).
Mitch Lloyd
@mitchlloyd
Yeah well... :smile:
Glad it worked out!
If there are bugs that arise, I'll definitely follow up.
I have a very large code base that I'm going to install it in. Lot's of crazy legacy code.
Kevin Partington
@platinumazure
Nice. And yeah, I'm looking forward to using the rule on my codebase as well.
And merged!
Thanks for your contribution, it's gonna be awesome.
Mitch Lloyd
@mitchlloyd
Great thanks! Hopefully I'll be able to follow up with another one soon.
Kevin Partington
@platinumazure
Did you want to write a PR for the arrow function one? Otherwise I might be able to knock it out today.
Kevin Partington
@platinumazure
Scratch that, I just learned we'll be putting a cat down soon, so... we'll see if I get time this weekend. If you want to start the no-arrow-tests rule, feel free to post here or in the issue (or just start a PR) to let me know. Otherwise, have a good weekend!
Kevin Partington
@platinumazure
Oh, and FYI, I'll release 0.6.0 once no-arrow-tests is done, so hopefully this weekend. (I'm starting it now)
Kevin Partington
@platinumazure
Got a branch up, if you want to take a look and/or try it out on a codebase of yours. I'll probably merge it to master tonight (US time).
Kevin Partington
@platinumazure
Released eslint-plugin-qunit@0.6.0, contains both no-arrow-tests and require-expect new rules. Please open an issue if you run into any bugs.
Kevin Partington
@platinumazure
Released eslint-plugin-qunit@0.9.0, which fixes two no-negated-ok issues and adds the last of the new rules for QUnit 2.0 migration. Next release will probably be a major release and will come with an ESLint peer dependency bump and a shareable config to enable all the QUnit 2.0 migration rules.
Mitch Lloyd
@mitchlloyd
Hey @platinumazure I'm getting some errors when running the tests. It's saying that this method is undefined: https://github.com/platinumazure/eslint-plugin-qunit/blob/master/build/generate-release-changelog.js#L43. What magic is this?
Mitch Lloyd
@mitchlloyd
I've worked around this my just calling mocha and eslint directly for now. Perhaps there is an npm module missing from package.json?
Kevin Partington
@platinumazure
That method is defined by shelljs-- just to check, have you run npm install locally?
Although I'm not sure why you're running my release changelog script as part of testing. >_> What are you entering on the command line to test?
Kevin Partington
@platinumazure
Ping @mitchlloyd, I was hoping you might be able to answer my question about running the release changelog script. :grinning:
Mitch Lloyd
@mitchlloyd
@platinumazure Yep I updated all of my npm modules with npm i
Also just running npm test seems to run the changelog script.
Also running npm unit-test test seemed to hit the script as well.
 ~  projects  platinumazure  eslint-plugin-qunit  require-expect-one-error-per-test  $  npm i
 ~  projects  platinumazure  eslint-plugin-qunit  require-expect-one-error-per-test  $  npm test

> eslint-plugin-qunit@0.9.0 test /Users/llomitch/projects/platinumazure/eslint-plugin-qunit
> npm run lint && npm run unit-test --coverage && npm run check-coverage


> eslint-plugin-qunit@0.9.0 lint /Users/llomitch/projects/platinumazure/eslint-plugin-qunit
> eslint ./


> eslint-plugin-qunit@0.9.0 unit-test /Users/llomitch/projects/platinumazure/eslint-plugin-qunit
> istanbul cover --include-all-sources --dir build/coverage -x build/** --report lcovonly node_modules/mocha/bin/_mocha tests/**/*.js -- --recursive

=============================================================================
Writing coverage object [/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/build/coverage/coverage.json]
Writing coverage reports at [/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/build/coverage]
=============================================================================

=============================== Coverage summary ===============================
Statements   : 5.76% ( 33/573 ), 25 ignored
Branches     : 15.4% ( 71/461 ), 71 ignored
Functions    : 1.28% ( 2/156 )
Lines        : 5.76% ( 33/573 )
================================================================================
/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/build/generate-release-changelog.js:9
__cov_nCxX4vthq_HmwHZhe_dWnA.s['1']++;var shelljs=require('shelljs'),semver=require('semver'),VERSION=require('../package.json').version;function execSilent(command){__cov_nCxX4vthq_HmwHZhe_dWnA.f['1']++;__cov_nCxX4vthq_HmwHZhe_dWnA.s['3']++;return shelljs.exec(command,{silent:true}).stdout;}__cov_nCxX4vthq_HmwHZhe_dWnA.s['4']++;var lastTag=execSilent('git tag').trim().split('\n').filter(semver.valid).sort(semver.compare).pop();__cov_nCxX4vthq_HmwHZhe_dWnA.s['5']++;var releaseCommitMessage=/^\* \d+\.\d+\.\d+/;__cov_nCxX4vthq_HmwHZhe_dWnA.s['6']++;var logs=execSilent('git log --no-merges --pretty=format:"* %s (%an)" '+lastTag+'..HEAD').split(/\n/g).filter(function(line){__cov_nCxX4vthq_HmwHZhe_dWnA.f['2']++;__cov_nCxX4vthq_HmwHZhe_dWnA.s['7']++;return!releaseCommitMessage.test(line);});__cov_nCxX4vthq_HmwHZhe_dWnA.s['8']++;('### '+VERSION+'\n').to('CHANGELOG.tmp');__cov_nCxX4vthq_HmwHZhe_dWnA.s['9']++;logs.join('

TypeError: (("### " + VERSION) + "
").to is not a function
    at Object.<anonymous> (/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/build/generate-release-changelog.js:9:857)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions.(anonymous function) [as .js] (/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/node_modules/istanbul/lib/hook.js:107:24)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at runFn (/Users/llomitch/projects/platinumazure/eslint-plugin-qunit/node_modules/istanbul/lib/command/common/run-with-cover.js:122:16)
    at /Users/llomitch/projects/platinumazure/eslint-plugin-qunit/node_modules/istanbul/lib/command/common/run-with-cover.js:251:17
    at /Users/llomitch/projects/platinumazure/eslint-plugin-qunit/node_modules/istanbul/lib/util/file-matcher.js:68:16
    at /Users/llomitch/projects/platinumazure/eslint-plugin-qunit/node_modules/istanbul/node_modules/async/lib/async.js:52:16
Seems very odd :)
Mitch Lloyd
@mitchlloyd
Ah, is it possible that istanbul is invoking this script when trying to determine test coverage?
istanbul cover --include-all-sources --dir build/coverage -x build/** --report lcovonly node_modules/mocha/bin/_mocha tests/**/*.js -- --recursive
Ok, I think I've got it.
Mitch Lloyd
@mitchlloyd
platinumazure/eslint-plugin-qunit#37
Kevin Partington
@platinumazure
You're a gentleman and a scholar, sir. Thank you!
Kevin Partington
@platinumazure
@mitchlloyd Unfortunately single quotes ends up breaking my setup. I think the general idea is that the glob string needs to be shell-quoted to avoid being picked up by the shell. I've pushed a commit to the master branch using double quotes; could you please try npm test with that version of the code and let me know if things break for you again?
For what it's worth, it works when I run npm test in Windows cmd.exe.
Kevin Partington
@platinumazure
Released eslint-plugin-qunit@1.0.0-rc0, which is a release candidate for 1.0.0. It contains two plugin-exported configs: "two" to turn on the QUnit 2.0 enforcement rules, and "recommended" for my personal list of recommended rules. Your configurations can inherit from one or both. Try it out with npm install eslint-plugin-qunit@next.
Mitch Lloyd
@mitchlloyd
@platinumazure How can I extend the recommended config in my config file? I tried extends: 'qunit:recommended... but its looking for eslint-config-qunit:recommended.
@platinumazure .... and I just saw your latest commit to the readme :) Ok, got it.
Mitch Lloyd
@mitchlloyd
Just tried this out on a large project. Everything worked great. Also I'll be using the recommended ruleset going forward. Overall awesome work!
Kevin Partington
@platinumazure
Thanks @mitchlloyd, glad this is helping you
*your project
Sorry, I could probably improve the readme. The plugin config extension syntax is a little weird.
Anyway, thanks for all your help in making this useful to people. Hopefully I'll release 1.0.0 soon.
Kevin Partington
@platinumazure
@mitchlloyd I've added the exact extension syntax for the plugin configs to the README for this repo. Sorry for the confusion earlier.
Kevin Partington
@platinumazure
Released eslint-plugin-qunit@1.0.0. This is a major release which introduces shareable configs but bumps the ESLint peerDependency requirement to ^2.8.0. In addition, we added a new QUnit 2.0 rule "no-test-expect-argument" and we made "require-expect" less noisy. Please open issues if you see problems with the new release.
Off-the-cuff, it's awesome to finally get a major release out. Thanks for all your help with this plugin!
Kevin Partington
@platinumazure
In case anyone is interested in update news but too lazy to check npm: I've released eslint-plugin-qunit@3.0.0, which has some new recommended rules and drops support for Node versions below 4.0. In addition, the ESLint peerDependency requirement is >=3.18.0 since we are using AST selectors in a few rules.
Jordan Eldredge
@captbaritone
nice.
Kevin Partington
@platinumazure
Released eslint-plugin-qunit@3.2.0, which is just a minor release but which expands ESLint peerDependency support to include eslint@4.x. (There were no breaking changes in the ESLint major release that should have affected end users of this plugin, but please do open issues if you do run into problems.)
deavor
@Ckefan
Hello everyone . How to customize the format code using vs code ? such as eslint
Kevin Partington
@platinumazure
Hi @Ckefan, are you asking how to let VS Code run ESLint's autofix? If so, I'm not really sure, as I've never used VS Code myself. But there shouldn't be anything special you need to do to get it working for eslint-plugin-qunit in particular- if you get it working for core ESLint rules, and your ESLint configuration includes this plugin, then VS Code should automatically fix any fixable lint warnings from this plugin.
Kevin Partington
@platinumazure
All that said, I just checked and I'm pretty sure none of the eslint-plugin-qunit rules are fixable. :smile: Sorry.
Kevin Partington
@platinumazure
eslint-plugin-qunit@4.1.0 has been released!
Kevin Partington
@platinumazure
eslint-plugin-qunit@5.0.0 has been released! Lots of great stuff in this release, including new rules and autofix updates to a bunch of existing rules!