I'm trying to build a helm lint test rule in my pleasings repo. It looks like the following so far, but I can't really get it work:
CONFIG.setdefault("HELM_TOOL", "//tools/k8s:helm")
def helm_lint(name:str, visibility:list=None):
"""Lints a Helm chart.
Args:
name (str): Name of the rule.
visibility (list): Visibility of the rule.
"""
return gentest(
name = name,
srcs = glob(["**"], hidden = True),
test_cmd = f'"$(location {CONFIG.HELM_TOOL})" lint "$PKG_DIR" 2>&1 > $RESULTS_FILE',
data = glob(["**"], hidden = True) + [CONFIG.HELM_TOOL],
#tools = {"helm": [CONFIG.HELM_TOOL]},
visibility = visibility,
no_test_output = True,
)I'm currently trying to test it inside the pleasings repo, but obviously I want to reuse it.
So the first question that comes into mind: will the helm tool config work this way? It's actually a target in the same repo, installing helm. Will it work, if I use the pleasings repo as a subrepo somewhere else?
Secondly, I guess I don't really get how tests work yet. So I want to use the downloaded helm tool for linting the helm chart, which consists of every file in the package. Looks like tools doesn't work that way, so I need to add CONFIG.HELM_TOOL as a dependency? Also as a data, so that it's in the test directory?
And the third question: I needed to add the files as both src and data. Is this how it supposed to work?
(Basically what I do here is run the helm lint tool for the chart directory).
Apologies if I'm asking dumb questions, but the current examples seem to work a bit differently than what I'm trying to do here.
--exclude option and in https://please.build/config.html look for blacklistdirs
def helm_package(name:str=None, visibility:list=None):
"""Packages a Helm chart into a versioned chart archive.
Args:
name (str): Name of the rule.
visibility (list): Visibility of the rule.
"""
return genrule(
name = name or basename(package_name()),
srcs = glob(["**"], hidden = True),
cmd = [
"mkdir helm-out",
'"$TOOLS_HELM" package --destination helm-out "$PKG_DIR"',
],
output_dirs = ["helm-out"],
tools = {"helm": [CONFIG.HELM_TOOL]},
visibility = visibility,
)
def helm_lint(name:str=None, visibility:list=None):
"""Lints a Helm chart.
Args:
name (str): Name of the rule.
visibility (list): Visibility of the rule.
"""
return gentest(
name = name or "_%s#lint" % (basename(package_name())),
test_cmd = f'"$(location {CONFIG.HELM_TOOL})" lint "$PKG_DIR" 2>&1',
data = glob(["**"], hidden = True) + [CONFIG.HELM_TOOL],
visibility = visibility,
no_test_output = True,
)
go_library and go_test, and defaulting the name there would be a good idea since it confuses things if they don't match
1 reply
go_library though
I'm trying to integrate please into a GitHub CI flow with caching.
I have two separate jobs that run sequentially:
- Build runs
plz buildand caches the compiled test binaries - Test runs the tests
Build saves .plz-cache to the cache, Test restores it and uses it to run the tests. I would like to utilize caching for test executions themselves though. What should I cache (from .plz-cache or plz-out I presume) so that please only runs the tests that changed?
plz test/cover, the test results would just be cached as you expect.
PLZ_ARGS="-p --profile ci") and then you can just use the pleasew script without having to duplicate those arguments in every command. I actually copied that env var from the circle config of please, but I realized it was from the bootstrap script.
Here is the PR BTW: banzaicloud/pipeline#3080
I moved onto the next step of building test binaries upfront and then executing them in the following steps.
./pleasew test -i go -o proto.language:go . It looks like it's trying to construct the python grpc bindings. Are there any projects that use Please that I could have a look at. The smaller the better!