The rest was just wrong haha
Yeah, I went through the codelabs, especially the one about creating custom build rule definitions. I liked the guidance of the codelabs because it walks me through the process step by step. The documentation is good to look something up, but the codelabs are great for learning how to do something step by step.
So while going through the codelabs, I found a couple of minor issues at felt like contributing back, even if those are just small documentation improvements. :-)
Hmmm, I'm trying to wrap my head around the problem and this change. I have an alias
[alias "deploy-vercel"]
cmd = run --env //vercel:deployand this rule requires the Firebase admin credentials (a JSON file) because some APIs deployed to Vercel require access to Google Firebase. //vercel:deploy is a sh_cmd rule. Curently, I set a custom [buildconfig] variable secrets-dir which contains the absolute path of the directory that contains different secret files. This value is used via CONFIG.SECRETS_DIR in the sh_cmd rule to. How would your suggested change improve this situation?
Would the secret files be transferred and made available temporarily to a remote worker?
I guess the path would be something like
~/.vercel/context.json or the like?
If i make this change, you'd be able to
plz run --env //vercel:deploy and then $SECRET_VERCEL_CONTEXT or whatever could be set via the secrets parameter on sh_cmd.
However I imagine you could just set the secret location in the sh_cmd i.e.
cmd = "vercel deploy --context ~/.vercel/context.json"
Is there any reason you don't just want to put the path in the cmd?
I'm not using a remote worker right now but thought that the
secrets parameter might make the secret available on the worker, but as you said it doesn't.
Hm, wait, why would the rule be rebuilt if the a secret file changed?
Stupid question but does the file exist if you just build "//src/bin/initdb"?
Build finished; total time 13.02s, incrementality 100.0%. Outputs:
//src/bin/initdb:initdb:
plz-out/gen/src/bin/initdb/initdb
I would suspect some kind of concurrency bug, but it's actually reproducible every time I try to build
//src/bin:binaries.
Obviously that should be an error.
Let me know if moving the filegroup to //src/bin/binaries:binaries fixes it
It seems similar to this: thought-machine/please#1313
Also, how easy is it to use Please to package Azure Function Apps and AWS Lambdas?
@brycefisher Hey! Thanks for checking out Please. Yeah so a "python_library()" in please terms is really just a way to group some .py files together. You can then depend on these from other bits of code. I'd recommend trying out the python codelab: https://please.build/codelabs/python_intro/#0
As for packing Azure Function Apps and AWS Lambdas, I'm not intimately familiar with what that would involve however I think it should be possible. You'll need to write some build rules to perform those actions though. You can get a feel for what's possible with build rules here: https://please.build/codelabs/genrule/#0
There's also some more guidance here: https://please.build/build_rules.html
And the built in rules are all defined here: https://github.com/thought-machine/please/tree/master/rules
I was wondering if there are any example repos, or tips on how to integrate please with vscode.
Currently in my project, code formatters (
Currently in my project, code formatters (
black), linters, and type checkers (mypy) are downloaded as dev dependencies and stored in the .venv along with other third party libraries. This means that vscode can look in the .venv folder for the executables as well as for autocompleting python code.
Hey @sbdchd, there's a vscode plugin here that implements with the please language server: https://github.com/thought-machine/please-vscode
It's not very mature but should start to see some love soonish. IDE support is something we're dearly lacking, but we're planning on investing in it in the not to distant future :)
It's not very mature but should start to see some love soonish. IDE support is something we're dearly lacking, but we're planning on investing in it in the not to distant future :)
I'm not sure Please does anything to generate a .venv for you. We do something very similar to generate a Go path including generated sources in
I can't think of a good reason we can't do the same for python.
plz-out/go...I can't think of a good reason we can't do the same for python.