Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Aug 25 15:28
    ddseanc opened #716
  • Aug 24 21:56
    JensRantil opened #715
  • Aug 24 18:32
    voidshard commented #714
  • Aug 24 13:13
    noxxious commented #714
  • Aug 24 13:10
    voidshard opened #714
  • Aug 23 08:52

    peterebden on master

    set grpc logger at init time (compare)

  • Aug 22 14:33

    peterebden on master

    Add a flag to `query print` to … (compare)

  • Aug 21 19:48

    peterebden on master

    Break out Go test main templati… (compare)

  • Aug 21 19:48
    peterebden closed #713
  • Aug 21 11:58
    matthen commented #712
  • Aug 21 11:42
    matthen edited #712
  • Aug 21 09:58
    rasto2211 commented #712
  • Aug 21 09:32
    rasto2211 commented #712
  • Aug 21 09:31
    rasto2211 commented #712
  • Aug 21 09:04
    fsiddiqia commented #713
  • Aug 21 08:21
    peterebden synchronize #713
  • Aug 21 08:19
    peterebden opened #713
  • Aug 21 01:31
    matthen opened #712
  • Aug 20 16:57

    peterebden on master

    Don't report diagnostics for ps… (compare)

  • Aug 20 16:35

    peterebden on master

    truncate interactive output aft… (compare)

Rastislav Rabatin
@rasto2211
@peterebden thanks
Hi @peterebden and everyone, we are trying to run our tests in please sandbox (sandbox=True) on circleCI and we are getting remount: Operation not permitted. I think that the error occurs on this line . Do you have an idea how to go around this problem?
Peter Ebden
@peterebden
hmmmmm so that'll be within Docker
I imagine that the user doesn't have sufficient capabilities
although interesting that it failed there rather than at unshare
Peter Ebden
@peterebden
Yeah that is odd, it fails at unshare for me if I just do it within an unprivileged Docker container
Rastislav Rabatin
@rasto2211
It fails also under sudo.
with the same error.
Peter Ebden
@peterebden
yeah that might not matter, if it's within a container then being root within that namespace might not be enough
Travis Johnson
@ThisGuyCodes
is there any way to have please use a different TMPDIR location? I just found a strange terraform bug and am looking for workarounds
I'd rather not use passenv as ubuntu has a tenancy to include the username there, so it'll mess with shared cache
Travis Johnson
@ThisGuyCodes
(if anyone is curious: hashicorp/terraform#22198)
Peter Ebden
@peterebden
Huh, interesting one... It isn't really configurable although turning on sandboxing might help since it can then go under /tmp instead
although that may raise other issues, if the rules can't be sandboxed or the environment doesn't support it
Travis Johnson
@ThisGuyCodes
I may be able to sandbox some of them. Others require network by their nature, for now I'm manually setting TMPDIR=/tmp/$PKG_DIR in the problematic jobs
Ranganath Kini
@codematix
hello, all. I wanted to know if there is an editor integration with VSCode for Please BUILD files. If yes, where do I get it from?
Ernst de Ridder
@hnridder
please can run a Language Protocol Server with 'please tool lps' that VSCode can talk to for syntax etc., but I can't get it to work. Maybe you are more lucky.
Peter Ebden
@peterebden
yeah it needs a bit of love, unfortunately Luna who was developing it left us :(
there is https://github.com/thought-machine/please-vscode which is a start on a vscode plugin - it is not yet working though
Gytis Raciukaitis
@noxxious
@peterebden i've done some initial fix to make the extension working
thought-machine/please-vscode#1
not very elaborate for now, but the code completion, syntax highlighting and error cheking + formatting works
and has has to be installed manually
Peter Ebden
@peterebden
sounds amazing, thanks!
Gytis Raciukaitis
@noxxious
I was thinking of copying larger parts from Bazel VSCode extension, like tasks support and snippets, but currently constrained in time
Peter Ebden
@peterebden
FYI I've uploaded the thing here: https://marketplace.visualstudio.com/items?itemName=please-build.plz-vscode so at least it's easier to install :)
Gytis Raciukaitis
@noxxious
yay
Alec Benzer
@AlecBenzer
https://github.com/thought-machine/please/blob/master/third_party/python/BUILD how do y'all handle some of the custom attributes (outs, deps) needed for some of these? e.g., do you just manually note which transitive deps certain libs have and record that in the BUILD file?
Gytis Raciukaitis
@noxxious
@AlecBenzer manually, but I found out that the likes of pipenv graph helps a lot
Gytis Raciukaitis
@noxxious
Did anybody try to build a nice dependencies graph using i.e. graphviz out of plz query graph ?
Gytis Raciukaitis
@noxxious
@peterebden can you review the #707 ?
Peter Ebden
@peterebden
sure, will do!
:thumbsup:
Gytis Raciukaitis
@noxxious
on the other note I noticed that some of the test dependencies are very old in particular xmlunit (that does not support unittest's subtests) and pytest. I can get around with custom bootstrap, but could push a change for this ?
Peter Ebden
@peterebden
Yeah, if you have time that would be great
I thought we updated pytest not so long back tbh, but maybe we only talked about it
Alec Benzer
@AlecBenzer
is there a way to set up plz & python so that I can continue importing third party deps as "import foo" and not, e.g., "from third_party.python import foo"
I guess just putting my third party deps in a BUILD.plz at my repo root could work?
Alec Benzer
@AlecBenzer
ah, so I found the moduledir option, but it doesn't seem to be doing anything for me. Does it need to be used in conjunction w/ plz's own "//tools/please_pex" ?
Alec Benzer
@AlecBenzer
nvm.... figured it out, I was being dumb with case sensitivity
Anton Kozlov
@tonickkozlov

Hi @peterebden,

We're trying to set up HTTP cache server (using please version 14.0.0.-beta8).
Main purpose is to cache installation results of large python libraries (e.g. tensorflow).

We've noticed that running //third_party/python:tensorflow without cache server enabled (which is a local docker container running WebDAV) does not significantly improve performance. Mainly it looks like all the dependencies of the rule are being re-downloaded from cache before building the root target.

Is there any caveat with trying to remotely cache pip libraries? Thanks!

I've also tried your image https://github.com/thought-machine/please/tree/master/tools/images/http_cache but it didn't seem to work (does not allow GET requests) :(
Peter Ebden
@peterebden
hmmm I don't think there should be anything special about pip libraries in that regard
I don't think the old image will work any more - the API is different now
Matt Henderson
@matthen
any thoughts on thought-machine/please#712 ? tensorflow as a pip library dependency is reeaally slowing down our builds
Peter Ebden
@peterebden
Not much beyond what you've mentioned there. The ultimate solution would be to work out how to make it work without extracting the zip
but that seems Very Difficult
I'm probably happiest with your suggestion of the propagating label
Peter Ebden
@peterebden
although it's still only a partial solution but hope it improves things for you
I'd like to dig in at some point but am pretty busy with non-plz stuff at work right now so not got a lot of time for it :(