These are chat archives for plexus/chestnut

11th
Feb 2015
Anna Pawlicka
@annapawlicka
Feb 11 2015 11:21
I've tried the latest snapshot version of chestnut with upgraded cljs ("0.0-2816") and om ("0.8.8") but when i try to start repl i get this "java.lang.RuntimeException: Unable to resolve var: cemerick.piggieback/wrap-cljs-repl in this contex" - @plexus i remember seeing something about latest cljs not working with piggieback. is there a hack i could do to make it work or should i downgrade cljs?
Arne Brasseur
@plexus
Feb 11 2015 14:57
Have a look at plexus/chestnut#79 , that's still pretty much the current status.
Anna Pawlicka
@annapawlicka
Feb 11 2015 14:57
thx!
Arne Brasseur
@plexus
Feb 11 2015 14:57
where do you get om 0.8.8? clojars still lists 0.8.0-rc1 as the latest version
Anna Pawlicka
@annapawlicka
Feb 11 2015 14:57
clojars
Arne Brasseur
@plexus
Feb 11 2015 14:57
odd
does that also say 0.8.0-rc1 for you?
David changed it to org.omcljs/om
Arne Brasseur
@plexus
Feb 11 2015 14:58
oh I see, I missed that
Anna Pawlicka
@annapawlicka
Feb 11 2015 14:59
i think he did it around the same time when he released 0.8.0 final
Arne Brasseur
@plexus
Feb 11 2015 14:59
a branch with those updates would be very welcome and appreciated :D
Anna Pawlicka
@annapawlicka
Feb 11 2015 14:59
np :D
Arne Brasseur
@plexus
Feb 11 2015 14:59
yeah seems like it, good to know. I was wondering why it was stuck on rc1 for so long
need to start paying more attention :D
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:00
and i need to start helping out more
Arne Brasseur
@plexus
Feb 11 2015 15:01
I got pretty close to getting chestnut 0.7.0 tested last weekend, finally have some automated testing in place
still needs to be expanded but at least it gives me some confidence that the basic stuff works with every single feature flag
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:02
that's great!
Arne Brasseur
@plexus
Feb 11 2015 15:02
it really should've been released long ago, but don't want to ship something half baked and get flooded with issues
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:02
with phantom.js right?
Arne Brasseur
@plexus
Feb 11 2015 15:02
0.6.0 seems pretty stable for people
yup, contains an example test on clj and cljs side
and figwheel-sidecar, so no more dependency on leiningen
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:04
should i make that branch in my fork or in your repo? you've added me to owners so i can do the latter
Arne Brasseur
@plexus
Feb 11 2015 15:07
you're fine to do it straight in the main repo
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:07
cool
Arne Brasseur
@plexus
Feb 11 2015 15:07
been meaning to have another look at the contributors and add some more to the repo
the list is getting long :)
many small patches but still cool
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:08
small patches make sure nothing gets really broken :)
Arne Brasseur
@plexus
Feb 11 2015 15:11
yup, like those much better than the big PRs that I merge too fast and then spend a weeking cleaning up :P
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:11
I created a PR
but it says "We can’t automatically merge this pull request."
not sure why
Arne Brasseur
@plexus
Feb 11 2015 15:11
hmm is it based on latest master?
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:11
it's just a version change
yeah, i pulled before i did anything
ah
wait
Arne Brasseur
@plexus
Feb 11 2015 15:12
:)
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:12
i'm on "2face77 Upgrade cljs, compojure and om. (origin/master, origin/HEAD, master)"
so up to date
that's the last commit before mine
facepalm..
Arne Brasseur
@plexus
Feb 11 2015 15:14
check where you're pulling from ;)
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:14
i pushed it to my fork by accident. will fix it in a moment
fixed
Arne Brasseur
@plexus
Feb 11 2015 15:19
great! we'll merge it as soon as 0.7.0 is released, then cut a 0.7.x branch for bugfixes
and get on with 0.8.x stuff on master
might be cool to more or less lock chestnut version to om versions
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:20
and to clojurescript probably since it's changing as rapidly?
Arne Brasseur
@plexus
Feb 11 2015 15:23
yeah, that too. what I meant was that chestnut 0.7.x has om 0.7.x etc
Anna Pawlicka
@annapawlicka
Feb 11 2015 15:23
right
that makes sense. easier to track