Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 18 15:34

    plokhotnyuk on master

    Update list of supported Scala … (compare)

  • Jan 18 15:30

    plokhotnyuk on master

    (compare)

  • Jan 18 15:28

    plokhotnyuk on master

    Update README.md (compare)

  • Jan 15 11:02
    plokhotnyuk closed #236
  • Jan 15 11:02
    plokhotnyuk commented #236
  • Jan 15 10:45

    plokhotnyuk on v2.12.1

    (compare)

  • Jan 15 10:45

    plokhotnyuk on master

    Setting version to 2.12.1 Setting version to 2.12.2-SNAPS… (compare)

  • Jan 15 08:34

    plokhotnyuk on master

    Code clean up 3 (compare)

  • Jan 14 22:04

    plokhotnyuk on master

    Code clean up 3 (compare)

  • Jan 14 18:30

    plokhotnyuk on code-cleanup-2

    (compare)

  • Jan 14 18:30

    plokhotnyuk on master

    Code clean up 2 (#848) (compare)

  • Jan 14 18:30
    plokhotnyuk closed #848
  • Jan 14 18:19
    plokhotnyuk opened #848
  • Jan 14 18:19

    plokhotnyuk on code-cleanup-2

    Code clean up 2 (compare)

  • Jan 14 17:32

    plokhotnyuk on master

    Enum with params (#847) Suppor… (compare)

  • Jan 14 17:32
    plokhotnyuk closed #847
  • Jan 14 17:01
    rssh opened #847
  • Jan 14 14:43
    rssh commented #828
  • Jan 14 14:43
    rssh commented #828
  • Jan 14 12:04

    plokhotnyuk on cleanup

    (compare)

Objektwerks
@objektwerks
@plokhotnyuk The code is rather complicated. Image 3 case classes A, B and C, each with this structure: id: Int, parentId: Int, installed: Int, model: String My Akka-Http router tests naturally tests A, B and C via their respective routers, and all effected database tables are good. This works with uPickle, for instance.
Yet it seems as though Jsoniter is interpreting all 3 case classes as case class A. And that naturally breaks the router-to-database code.
So is there some case class discriminator key feature in Jsoniter that might resolve this confusion?
Andriy Plokhotnyuk
@plokhotnyuk
Do you have separated codecs derived by the make call for all A, B and C types.
Objektwerks
@objektwerks
Yes, I do. See: https://github.com/objektwerks/pwa.pool/blob/master/shared/src/main/scala/pool/Codecs.scala
It all looks good to go. In the code above, the effected classes are Pump, Timer and Heater.
See: https://github.com/objektwerks/pwa.pool/blob/master/shared/src/main/scala/pool/Entity.scala
You'll note all 3 have the identical field names, just different case class names. Jsonitor thinks all 3 are a Pump.
And in my router test, I get 3 record entries in the pump table, nothing in the timer or heater tables.
Objektwerks
@objektwerks
@plokhotnyuk Andriy, I've gotta step out for a few hours. This is by no means a high priority issue for me. Any suggested resolutions would be awesome --- at your convenience. Cheers!
Objektwerks
@objektwerks
@plokhotnyuk Andriy, I built this unit test: https://github.com/objektwerks/pwa.pool/blob/master/shared/src/test/scala/pool/CodecsTest.scala
Note the imports for each test. Jsoniter gets confused about codecs when they're all detailed in a single object.
It looks as though I may have to place a custom codec in the companion object of each entity. Does that sound about right?
Andriy Plokhotnyuk
@plokhotnyuk
Not at the computer now. Probably the problem is that you have used implicit keyword for codec vals of Entity trait implementations.
Andriy Plokhotnyuk
@plokhotnyuk
You can define them in a different namespace to not be injected when deriving codec for Entity.
Andriy Plokhotnyuk
@plokhotnyuk
I isolated codecs for product-types from codecs for sum-types and modified your tests to show difference between these codecs, please check if it passes your end-to-end and integration tests: objektwerks/pwa.pool#1
Objektwerks
@objektwerks
@plokhotnyuk Thanks, Andriy. I re-added jsoniter support. I just got the codecs test to work correctly! The type key appears on all 3 entity tests, but no individual pump, heater or timer tests. But the router test still fails. Still the same problem, jsoniter still thinks a heater and timer are a pump.
Objektwerks
@objektwerks
jsoniter pump: Pump(0,1,1,model.pump)
jsoniter pump as json: {"poolId":1,"installed":1,"model":"model.pump"}
jsoniter pump as entity json: {"type":"Pump","poolId":1,"installed":1,"model":"model.pump"}
jsoniter heater: Heater(0,1,1,model.heater)
jsoniter heater as json: {"poolId":1,"installed":1,"model":"model.heater"}
jsoniter heater as entity json: {"type":"Heater","poolId":1,"installed":1,"model":"model.heater"}
jsoniter timer: Timer(0,1,1,model.timer)
jsoniter timer as json: {"poolId":1,"installed":1,"model":"model.timer"}
jsoniter timer as entity json: {"type":"Timer","poolId":1,"installed":1,"model":"model.timer"}
Is there a way to force the generation of a type key for pump, heater and timer json?
Objektwerks
@objektwerks
upickle pool as json: {"$type":"pool.Pool","license":"abc123","name":"pool","built":1991,"lat":26.85,"lon":82.29,"volume":10000}
This is how uPickle, for instance, does it for each of my entities.
Andriy Plokhotnyuk
@plokhotnyuk
I've updated the PR with reusing of sum-type codecs for parsing and serialization of ADT leaf types and modified the unit test to check that serialized JSON is identical:
jsoniter pump: Pump(0,1,1,model.pump)
jsoniter pump as json: {"type":"Pump","poolId":1,"installed":1,"model":"model.pump"}
jsoniter pump as entity json: {"type":"Pump","poolId":1,"installed":1,"model":"model.pump"}
jsoniter heater: Heater(0,1,1,model.heater)
jsoniter heater as json: {"type":"Heater","poolId":1,"installed":1,"model":"model.heater"}
jsoniter heater as entity json: {"type":"Heater","poolId":1,"installed":1,"model":"model.heater"}
jsoniter timer: Timer(0,1,1,model.timer)
jsoniter timer as json: {"type":"Timer","poolId":1,"installed":1,"model":"model.timer"}
jsoniter timer as entity json: {"type":"Timer","poolId":1,"installed":1,"model":"model.timer"}
Objektwerks
@objektwerks
@plokhotnyuk Thanks for your help, Andriy. I made the codec/test changes, and everything works correctly. In the router test, though, I now get the following error: ClassCastException: pool.Surface cannot be cast to pool.Pool ... also for Pump, Timer, Heater, Measurement, Cleaning, Chemical, Supply and Repair. All extend Entity, to include Pool. Pool has a 1-to-N relationship with these entities. But the casting exceptions make no sense. So, perhaps, we need to tweak the fromSumTypeCodec method. Not sure. All changes are pushed to master.
Andriy Plokhotnyuk
@plokhotnyuk
@objektwerks could you please provide steps how to setup and run the router test? Probably imports of codecs should be defined more closely for used places or codec params should be passed explicitly.
Objektwerks
@objektwerks
@plokhotnyuk Andriy, if you feel the fromSumTypeCodec method is solid, I'll play around with the router/test imports and the like. My apologies for having taken up so much of your time. FWIW, this all worked fine with Circe and uPickle. Jsoniter just need a bit more work. Thanks, again, for your help!
Andriy Plokhotnyuk
@plokhotnyuk
@objektwerks It may be wrong but I think that using of separated routes for each Entity sub-class is overkill. It looks that routing and storage can be greatly simplified using one entities route which can work polymorphically using the type key values from payload.
Objektwerks
@objektwerks
@plokhotnyuk Yes, no doubt, there's multiple ways to build Akka-Http routes. Paths vs Pattern Matching, for instance. In Scala, there's no wrong way, just many ways. :)
Nils Kilden-Pedersen
@nilskp
Once again I have a parsing failure, but not sure where it's from since stack traces are disabled by default.
First, how do I enable those again? And second, any easy way to enable this wholesale across the entire runtime, or have the default changed?
Looks like it's a very cumbersome default to override, as it's specific all the way to the individual read methods. And not implicit either. So I have to manually reference a ReaderConfig everywhere, manually. I guess that's less than optimal.
Andriy Plokhotnyuk
@plokhotnyuk
@nilskp As a w/a you can define a delegating call with an implicit parameter for the config that have your custom default settings: def read[A](buf: Array[Byte])(implicit codec: JsonValueCodec[A], config: ReaderConfig = CustomReaderConfig) = readFromArray(buf, config)(codec)
Nils Kilden-Pedersen
@nilskp
@plokhotnyuk That should work. Thanks.
b-gyula
@b-gyula
Is there an (implicit) generic transitive codec for collections like in play-json or if I want to generate json for an Array[User] then I need to create a codec implicit val codec: JsonValueCodec[Array[User]] = make regardless if I already have a codec for the User class?
Andriy Plokhotnyuk
@plokhotnyuk
Hi, @b-gyula ! Usually you need to call make only for the top level type of your data structure as described in the README example. All subsequent codecs will be automatically generated and inlined to the top level one. Defining of type class instances for other types of messages by calling make(cfg: CodecMakerConfig) could be needed if the derivation configuration should be different from the default or custom configuration used for the top level type.
Nils Kilden-Pedersen
@nilskp
Could be because arrays are reified?
quanganhtran
@quanganhtran
I can serialize case object extending sealed trait as a string using withDiscriminatorFieldName=None but that string is in PascalCase. How can I make it kebab case?
I tried withFieldNameMapper but I'm still getting PascalCase
JsonCodecMaker.make(
  CodecMakerConfig
    .withDiscriminatorFieldName(None)
    .withFieldNameMapper(JsonCodecMaker.`enforce-kebab-case`)
)
Andriy Plokhotnyuk
@plokhotnyuk
Hi, @quanganhtran ! Have you tried adtLeafClassNameMapper yet?
quanganhtran
@quanganhtran
just now! it works!
.withAdtLeafClassNameMapper(c => JsonCodecMaker.`enforce-kebab-case`(JsonCodecMaker.simpleClassName(c)))
thanks
phlamenco
@phlamenco
Hi, I use jsoniter-scala to searialze a case class which has a byte field of default value to 0, using writeToString for a case class that the byte field being assigned to 0 gives a json string that missing this byte field, is there a way to output the byte field and it's value?
Andriy Plokhotnyuk
@plokhotnyuk
Hi, @phlamenco ! Please try the following config option during codec derivation:
JsonCodecMaker.make[YourDatatypeWithAByteField] {
    CodecMakerConfig
      .withTransientDefault(false)
  }
phlamenco
@phlamenco
tested ok!, thanks
Guillaume Vauvert
@gvauvert
Hello @plokhotnyuk, first, thanks for jsoniter-scala, performance is great !
I have created plokhotnyuk/jsoniter-scala#836 in order to be able to provide better human readable and structured response in case of invalid input.
(I forked/cloned the repo to have a first look into the code, but IntelliJ is failing to compile the code, the same using sbt with command line. First issue seems to be a missing Jackson dependency.)
Paulius Imbrasas
@CremboC
@plokhotnyuk hey, is there any update on Scala 3 support? I see plokhotnyuk/jsoniter-scala#828 is merged but there hasn't been any releases
Andriy Plokhotnyuk
@plokhotnyuk
@CremboC Hi, Paulius! Remaining works before first release with Scala 3 are checking of performance and minimization of difference with Scala 2 version
Paulius Imbrasas
@CremboC
Got it. When you say minimization of differences, do you mean is it encoding/decoding something incorrectly right now or some other minor differences?
Andriy Plokhotnyuk
@plokhotnyuk
It is mostly about differences in Macros API for derivation and non-functional requirements: CPU cycles, allocations, etc.