Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 14 05:39
    ykkhan commented #9
  • Aug 14 05:38
    ykkhan commented #9
  • May 15 05:39
    ss229v commented #9
  • Oct 31 2019 17:11
    TatkaVu opened #12
  • Oct 17 2019 00:35
    LeuAlmeida commented #11
  • Oct 12 2019 15:09
    tkimnguyen closed #11
  • Oct 12 2019 15:09
    tkimnguyen commented #11
  • Oct 12 2019 15:05
    tkimnguyen commented #11
  • Oct 12 2019 09:46
    jugmac00 commented #11
  • Oct 07 2019 22:17
  • Oct 05 2019 14:19

    tkimnguyen on daterecurringindex

    use Products.DateRecurringIndex… (compare)

  • Oct 04 2019 13:59
    LeuAlmeida commented #11
  • Oct 04 2019 13:57
    LeuAlmeida commented #11
  • Oct 04 2019 07:14
    jugmac00 commented #11
  • Oct 04 2019 02:08
    LeuAlmeida opened #11
  • Oct 03 2019 21:40

    tkimnguyen on daterecurringindex

    specify git branch source for P… (compare)

  • Oct 03 2019 20:06

    tkimnguyen on daterecurringindex

    enable mr.developer and auto-ch… (compare)

  • Oct 03 2019 18:58

    tkimnguyen on daterecurringindex

    (compare)

  • Oct 03 2019 06:53
  • Oct 03 2019 00:42

    tkimnguyen on master

    Update CHANGES.rst (compare)

Maik Derstappen
@MrTango

or example when I try it with the custom stuff, auto complition of the list works, but the actual call not, because the create command expects the name argument first and then the subcommand addon

plonecli create addon di.bla Usage: plonecli create [OPTIONS] NAME COMMAND [ARGS]... Error: No such command "di.bla"

But we want it in the oposit order

Thomas Massmann
@tmassman
I'll test it later
Thomas Massmann
@tmassman
plone/plonecli@7ce4108
Maik Derstappen
@MrTango
ok, it seems to work now with the master of click, thx a lot. I still have to refactor the part which finds the root_folder and the setup.cfg
Maik Derstappen
@MrTango
I pushed my changes, but so far it only works if you are inside a package or no other setup.py is in the path ;)
it will not work when you are in the plonecli package folder
I'll refactor that later, now dinner ;)
Thomas Massmann
@tmassman
@MrTango, please follow the coding style guide, especially https://docs.plone.org/develop/styleguide/python.html#docstrings-style
Saicharan Reddy
@mrsaicharan1
I had actually stumbled upon something which made me feel doubtful .
Saicharan Reddy
@mrsaicharan1
So, I had been creating additional methods for the bobregistration.py file for the plonecli.The templates for mr.bob are plone_addon,plone_buildout,plone_themepackage etc. Could anyone help me out segregating them on basis of whether they are a standalone template or a subtemplate? This info would be helpful as I would have to decide whether I should override the init method variable self.depend_on (if it's a subtemplate, I would need to override it)
Pertaining to the information I have gathered, I think the add_on, buildout and theme_package are the standalone ones, whereas the others are subtemplates. Please correct me if I'm wrong.
Saicharan Reddy
@mrsaicharan1
If I'm not wrong , could you also mention the parent standalone template names?
Maik Derstappen
@MrTango
Hi @mrsaicharan1 in the docs in the github repo you can find updated docs for this, they are not on docs.plone.org yet, because this needs an rebuild of the docs, which is still pending.
but in short, addon, theme_package and buildout are standalone templates, content_type, vocabulary, theme are sub templates.
I'm still working on updating the structure, i have some stuff in the queue, but i need to fix the tests before i can push it. It will solve some ssues with the plonecli
usually every template/subtemplate has it's own python file like theme.py, but the addon stuff is still in the hooks,py which was the only one when i startet to refacture this.
What are you working on?
please read also the todo list, if you want to contribute
Saicharan Reddy
@mrsaicharan1
Yes, I had figured out everything by read the docs in the git repo. I had been adding additional methods for the other templates in bobregistration.py to get used to the plone cli codebase
I would like to work on the plonecli features. Could you point me to the todo list?
Manish Ranjan
@Zemotacqy
Hello, I am following this link: https://training.plone.org/5/mastering-plone/eggs1.html to write my own add-ons , I get the following error- https://www.pastiebin.com/5a9b020b6dd89
Maik Derstappen
@MrTango
hey, please upgrade your bobtemplates.plone version to at least 3.0.0b3
Saicharan Reddy
@mrsaicharan1
@MrTango I've done the upgrade . The behavior template which has been added newly in 3.0.0b3, is it a template or a subtemplate in bobtemplates.plone?
Also, In the gsoc ideas, I wasn't able to make out what you meant by util. Is it the same as utilities? or is it something else?
Saicharan Reddy
@mrsaicharan1
I have spoken with @datakurre regarding util and he has helped me by confirming that util means utilities. I'd be using popular utilities and adapters in my proposal . Thank you !
Akshit Jain
@AkshJain99
hey I am getting changelog test fail in my pr plone/bobtemplates.plone#348 how to correct that
Akshay
@kakshay21
you have to add a comment about your change in CHANGES.rst
Akshit Jain
@AkshJain99
is it good idea to touch changes.rst and commit it in pr?
@kakshay21
Akshit Jain
@AkshJain99
everytime i submit a pr should i also need to add comment in changes.rst,but i push that in commit that look odd as commit should only contain changes that solves the issue
Akshay
@kakshay21
Akshit Jain
@AkshJain99
maintainers please review and merge this pr plone/bobtemplates.plone#348
Maik Derstappen
@MrTango
@AkshJain99 you don't need to change the changelog every time you commit, but a PR changes something which shoulkd be documented. So not change without noting it there ;)
Robert Kuzma
@balavec
Hi all.
Alexander Loechel
@loechel
Hi Robert
Alexander Loechel
@loechel
@MrTango are you online?
I think about working on bob templates.plone here at the burschschanksprint and make changes so that generated code would be black conform
Alexander Loechel
@loechel
any objectives against?
Maik Derstappen
@MrTango
no I'm fine with black, started already at some places.
so please check my last work
but it's all merged ;)
Alexander Loechel
@loechel
perfect
Maik Derstappen
@MrTango
I still have the branch for the upgrade steps WIP
will probably work on that this week too
Maik Derstappen
@MrTango
But I'll focus later on EasyNewsletter DX/P3 Upgrade
Tobias Herp
@tobiasherp
Hi all, I'm currently creating packages for Plone 4.3 (for now), and AFAICS, the bobtempates.plone:addon has several issues now concerning the compatibility.
I understand that the community of course likes to go forward ... but IMO it is important to have it for Plone 4 as well, because a good prior condition for a migration to Plone 5+ is a best-practices Plone 4 package, right?
Thus, what I'd like to have, is:
  • a branch which maintains Plone 4 compatibility; if possible, picking up a last truly compatible version
  • a branch which goes forward and drops Plone 4 compatibility completely.
    Since we have v4.1.0 by now, we could have versions 4.3.x for the Plone 4 compatibity, and versions 5.x for the non-compatible versions.
    What do you think?
Maik Derstappen
@MrTango
hi @tobiasherp sorry for the delay, just read you msg. The current version should be compatible with Plone 4, except for the theme templates, they are made for new plones
if you find problems, please add issues for it and help us to fix the issues.