Hi! I want to choose the pool_size of the db pool from my k8s yaml:
I have the following name/value
- name: G_databases__db__pool_size - value: "4"
the problem is that guillotina doesn't convert the "4" to integer and asyncpg crashes with:
TypeError '<=' not supported between instances of 'str' and 'int'
I was thinking to convert the str to int here https://github.com/plone/guillotina/blob/4c814b60b774f94a39344514b6127fa1ad85963f/guillotina/db/factory.py#L64 but I'm asking to know if there is a better way / place to do it.
ps: k8s doesn't like a numeric value under
how would everyone feel about simply adding prometheus directly to guillotina?
I'd like to add metrics to our database layers and adding some kind of metrics utility in order for us to capture this seems a bit silly. Prometheus has very low overhead and most of us use it anyways. Thoughts?
@/all there is preliminary evidence that the shared read connection is a problem. I have some preliminary examples on smaller test servers where we have p99s of 40ms just waiting to use that connection object.
we'll have full metrics in production next week so we should have a more clear picture then with servers under more much load