Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Ramon Navarro Bosch
    @bloodbare
    At least should be possible to deactivate and not collect metrics
    Nathan Van Gheem
    @vangheem
    ok, I guess I just see minimal value in having it optional/configurable
    Ramon Navarro Bosch
    @bloodbare
    Yups
    Nathan Van Gheem
    @vangheem
    we okay with introducing prometheus and directly using it then?
    Jordi Masip
    @masipcat_gitlab
    Sounds good :)
    Ramon Navarro Bosch
    @bloodbare
    @all we open sourced two small guillotina packages we’ve been using just in case are interesting: https://pypi.org/project/guillotina-nats/ and https://pypi.org/project/guillotina-numpy/
    To connect guillotina to Nats or Nats streaming and to store numpy fields on guillotina objects
    Jordi Masip
    @masipcat_gitlab
    Nice! We also released this library two weeks ago: https://pypi.org/project/guillotina-localstorage/
    Ramon Navarro Bosch
    @bloodbare
    it remembers me a lot the blobstorage from zope/plone :) Really nice work Jordi !
    Jordi Masip
    @masipcat_gitlab
    thank you :)
    Nathan Van Gheem
    @vangheem
    @bloodbare @masipcat_gitlab if you are okay, I'll add to master as well: plone/guillotina#1005
    Ramon Navarro Bosch
    @bloodbare
    @vangheem is it conditional ?
    I see that prometheus package is not try catch
    Nathan Van Gheem
    @vangheem
    no, I thought we said it was not worth it to make it conditional
    "ok, I guess I just see minimal value in having it optional/configurable" -- your response, "Yups" :)
    Ramon Navarro Bosch
    @bloodbare
    missunderstanding sorry, I understood I see minimmal value ...
    Nathan Van Gheem
    @vangheem
    yah, my point, so low of value it's not worth it
    Ramon Navarro Bosch
    @bloodbare
    I don’t use prometheus on 70% of my G projects
    Nathan Van Gheem
    @vangheem
    conditional would introduce other knobs that increase complexity
    what do you use instead of prometheus?
    Ramon Navarro Bosch
    @bloodbare
    on that project we don’t need prometheus
    Nathan Van Gheem
    @vangheem
    is having it hurting anything/
    ?
    Ramon Navarro Bosch
    @bloodbare
    Sorry, I don’t understand you
    Nathan Van Gheem
    @vangheem
    even if you don't consume the metrics, it doesn't hurt to still have them does it?
    my point on this: sure, we can add indirection in order to conditionally have this but I just see very little value in adding indirection
    Ramon Navarro Bosch
    @bloodbare
    I see why u see little value in adding indirection, I don’t see the value of the PR by itself for my use cases, but if you don’t feel to have it conditional (like adding an app_settings check at https://github.com/plone/guillotina/pull/1005/files#diff-715c11a2e98bfb857700e76197df6278R34 and try except import) we can add later on
    Nathan Van Gheem
    @vangheem
    alright, changed to handle import errors
    Ramon Navarro Bosch
    @bloodbare
    thanks !
    Nathan Van Gheem
    @vangheem

    @/all there is preliminary evidence that the shared read connection is a problem. I have some preliminary examples on smaller test servers where we have p99s of 40ms just waiting to use that connection object.

    we'll have full metrics in production next week so we should have a more clear picture then with servers under more much load

    Jordi Collell
    @jordic
    @vangheem how it's going at production?
    Nathan Van Gheem
    @vangheem

    p50 shows little contention, ~300 microseconds

    p99 shows 1.5 second wait for shared connections

    so pretty bad and no reason little reason for this it seems to me.

    Jordi Masip
    @masipcat_gitlab
    interesting!
    Christophe de Vienne
    @cdevienne
    quit
    Ramon Navarro Bosch
    @bloodbare
    Hi everybody, its time to push for G7! After last Guillotina Core Devs Meetings we wrote all propsals for next generation! The list is tied to Milestone https://github.com/plone/guillotina/milestone/6 and I’ve started a branch (https://github.com/plone/guillotina/tree/g7)
    I would like to clean up actual PRs before continuing: @vangheem what about #757 #960 #966 #997 , @masipcat_gitlab #788 #978 #1004 #1010 #1020 #1021
    Nathan Van Gheem
    @vangheem
    awesome!
    I can poke ferran about those prs
    Nathan Van Gheem
    @vangheem
    @bloodbare think we should forward port mertrics to master before working on g7 branch?
    Ramon Navarro Bosch
    @bloodbare
    @vangheem I think so
    then we can rebase asap on g7 branch
    alan runyan
    @runyaga
    @bloodbare why drop cockroach support?
    everyone busy shipping product?
    Ramon Navarro Bosch
    @bloodbare
    @runyaga I love cockroach support, all arround its design, but there is nobody using it on production right now and avoids us to use more powerful functionallity from postgres and at the same time makes code more difficult to maintain. Do you have a use case with cockroach ?
    Nobody that we are aware, of course :)
    alan runyan
    @runyaga
    no use case. guys i know whom use it are doing it for multiDC;i was curious. would be nice to see what the status of g.
    Ramon Navarro Bosch
    @bloodbare
    Its quite a nice usecase the multiDC, my plan for cockroach will be to move it to a external package so it can be an addon instead of a core feature if anybody wants to work on it. You should not miss the Status of G talk at PC2020 :) Lots of improvements this year and a nice roadmap for G7
    Robert Kuzma
    @balavec
    Hey guys… I am playing around with guillotina_react … I get it to work, but not abel to login … not sure what I am missing. It keeps messaging me: “Failed to fetch data: Backend not running?”
    and the request is 401:
    INFO:     ::1:54940 - "POST /%40login HTTP/1.1" 401 Unauthorized
    I am able to login using postman