Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 13:51
    zkochan commented #3039
  • 10:22
    eden-lane commented #2933
  • 08:40
    illright commented #3039
  • 02:22
    zkochan synchronize #4280
  • 02:22

    zkochan on v7-global-bin

    test: fix (compare)

  • Jan 27 23:07
    gluxon commented #4285
  • Jan 27 22:57
    zkochan milestoned #4158
  • Jan 27 22:57
    zkochan milestoned #4285
  • Jan 27 22:57
    zkochan milestoned #4265
  • Jan 27 22:57
    zkochan milestoned #4259
  • Jan 27 22:57
    zkochan demilestoned #4259
  • Jan 27 22:54

    zkochan on main

    feat: add support of the update… (compare)

  • Jan 27 22:54
    zkochan closed #4285
  • Jan 27 22:54
    zkochan closed #4158
  • Jan 27 21:51
    zkochan synchronize #4285
  • Jan 27 20:30
    Olyno commented #4286
  • Jan 27 19:46
    LeSuisse synchronize #4285
  • Jan 27 19:40
    zkochan commented #4286
  • Jan 27 19:00
    Olyno commented #4286
  • Jan 27 18:28
    zkochan commented #4286
Vaughan Rouesnel
@vjpr
(this also modified them)
Zoltan Kochan
@zkochan
this is what I was looking for https://github.com/maxogden/dependency-check
Vaughan Rouesnel
@vjpr
Zoltan Kochan
@zkochan
yep, I looked into dependents of detective
that's how I've found it
Vaughan Rouesnel
@vjpr
if i run pnpm i —force will this update my local shrinkwrap?
i think i need something like pnpm i —force-but-dont-modify-my-shrinkwrap.
say i am reusing a node_modules dir, but i have changed branch and want to run pnpm i to use the new shrinkwrap
Zoltan Kochan
@zkochan
I think it won't update the shrinkwrap.
Vaughan Rouesnel
@vjpr
im finding that the new node_modules/.shrinkwrap.yaml is not the same as shrinkwrap.yaml which means its doing an entire deploy each time
Zoltan Kochan
@zkochan
but the outer shrinkwrap is not modified, right?
the inner is rewritten to be the same as the outer
Vaughan Rouesnel
@vjpr
hmm ok it seems like that is the case
but im seeing my shrinkwrap change each time i install
e.g.
  /soap/0.17.0:
    dependencies:
      compress: 0.99.0
      debug: 0.7.4
      ejs: 2.3.4
      lodash: 3.10.1
      node-uuid: 1.4.8
      optional: 0.1.3
      request: 2.81.0
      sax: 1.2.2
      selectn: 0.9.6
      strip-bom: 0.3.1
      ursa: 0.9.4
      xml-crypto: 0.8.5
    resolution: 1fccd7e19031a143ee53dec09afe89ba379e051e
  /soap/0.17.0:
    dependencies:
      compress: 0.99.0
      debug: 0.7.4
      ejs: 2.3.4
      lodash: 3.10.1
      node-uuid: 1.4.8
      optional: v0.1.3
      request: 2.81.0
      sax: 1.2.2
      selectn: 0.9.6
      strip-bom: 0.3.1
      ursa: 0.9.4
      xml-crypto: 0.8.5
    resolution: 1fccd7e19031a143ee53dec09afe89ba379e051e
Zoltan Kochan
@zkochan
when the two shrinkwraps differ?
Vaughan Rouesnel
@vjpr
notice the optional has a v
prefixed
i remember this is an issue i submitted earlier
Zoltan Kochan
@zkochan
yes, I couldn't repro
maybe the difference between inner/outter shrinkwrap causes these
Vaughan Rouesnel
@vjpr
ok so i can reproduce it everytime now
maybe its a corrupt store or something
rm shrinkwrap.yaml
rm -rf node_modules
pnpm i

rm -rf node_modules
pnpm i

shrinkwrap.yaml has changed
react-highcharts and the optional module
the second time it reports these messages and then adds them to the shrinkwrap
  WARN Cannot find resolution of /highcharts-release/v4.2.7 in shrinkwrap file
  WARN Cannot find resolution of /highmaps-release/v1.1.10 in shrinkwrap file
  WARN Cannot find resolution of /highstock-release/v2.1.10 in shrinkwrap file
  WARN Cannot find resolution of /optional/v0.1.3 in shrinkwrap file
Vaughan Rouesnel
@vjpr
i will try find where it happens in the code
Zoltan Kochan
@zkochan
I think I reproduced it.
happens when the shrikwrap.yaml inside node_modules difference from the one outside
so after a branch switch very likely
Vaughan Rouesnel
@vjpr
im seeing it without the inside and outside being different
Vaughan Rouesnel
@vjpr
so in shrinkwrap.ts pkgIdToRef, pkgVersion sometimes can start with a v
i will find the root cause
Zoltan Kochan
@zkochan
thanks
Vaughan Rouesnel
@vjpr
haha so highcharts-release puts of v in its package.json version
is this even valid?
Zoltan Kochan
@zkochan
wow
according to this site it is valid
Vaughan Rouesnel
@vjpr
haha
Zoltan Kochan
@zkochan
TIL
A leading "=" or "v" character is stripped off and ignored.
boom
i think ive seen packages with leading equals too
ah there was a bug related to that
Zoltan Kochan
@zkochan
I see, there's a semver.clean method for stripping off the v and stuff
Vaughan Rouesnel
@vjpr
cool, where is the best place to do it?
Zoltan Kochan
@zkochan
I don't know. I'd add a test that reproduces the issue first
where to put it, maybe to readPkg.ts, normalizing the version property
also we use read-pkg, which can normalize the package.json as well. https://github.com/npm/normalize-package-data#what-normalization-currently-entails