Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 01:39
    zkochan opened #4053
  • 01:38

    zkochan on 4052

    fix: calculating tarball locati… (compare)

  • Nov 30 22:03
    zkochan commented #4052
  • Nov 30 21:17
    zkochan commented #4052
  • Nov 30 20:31
    zkochan commented #2933
  • Nov 30 20:04
    zkochan commented #2933
  • Nov 30 19:50
    zkochan commented #4052
  • Nov 30 18:00
    aholtkamp opened #4052
  • Nov 30 18:00
    aholtkamp labeled #4052
  • Nov 30 16:01

    zkochan on main

    feat(core): overrides, packageE… (compare)

  • Nov 30 16:01

    zkochan on refactor-overrides

    (compare)

  • Nov 30 16:01
    zkochan closed #4050
  • Nov 30 15:22
    vivek-medly commented #2933
  • Nov 30 14:31
    damiensedgwick commented #2933
  • Nov 30 13:41
    erlendk commented #3755
  • Nov 30 13:37
    cjanietz commented #2933
  • Nov 30 13:37
    cjanietz commented #2933
  • Nov 30 13:30
    zkochan synchronize #4050
  • Nov 30 13:30

    zkochan on refactor-overrides

    test: getOptionsFromRootManifes… (compare)

  • Nov 30 13:29
    zkochan review_requested #4050
Vaughan Rouesnel
@vjpr
react-highcharts and the optional module
the second time it reports these messages and then adds them to the shrinkwrap
  WARN Cannot find resolution of /highcharts-release/v4.2.7 in shrinkwrap file
  WARN Cannot find resolution of /highmaps-release/v1.1.10 in shrinkwrap file
  WARN Cannot find resolution of /highstock-release/v2.1.10 in shrinkwrap file
  WARN Cannot find resolution of /optional/v0.1.3 in shrinkwrap file
Vaughan Rouesnel
@vjpr
i will try find where it happens in the code
Zoltan Kochan
@zkochan
I think I reproduced it.
happens when the shrikwrap.yaml inside node_modules difference from the one outside
so after a branch switch very likely
Vaughan Rouesnel
@vjpr
im seeing it without the inside and outside being different
Vaughan Rouesnel
@vjpr
so in shrinkwrap.ts pkgIdToRef, pkgVersion sometimes can start with a v
i will find the root cause
Zoltan Kochan
@zkochan
thanks
Vaughan Rouesnel
@vjpr
haha so highcharts-release puts of v in its package.json version
is this even valid?
Zoltan Kochan
@zkochan
wow
according to this site it is valid
Vaughan Rouesnel
@vjpr
haha
Zoltan Kochan
@zkochan
TIL
A leading "=" or "v" character is stripped off and ignored.
boom
i think ive seen packages with leading equals too
ah there was a bug related to that
Zoltan Kochan
@zkochan
I see, there's a semver.clean method for stripping off the v and stuff
Vaughan Rouesnel
@vjpr
cool, where is the best place to do it?
Zoltan Kochan
@zkochan
I don't know. I'd add a test that reproduces the issue first
where to put it, maybe to readPkg.ts, normalizing the version property
also we use read-pkg, which can normalize the package.json as well. https://github.com/npm/normalize-package-data#what-normalization-currently-entails
oh, and we have to be sure that after the fix, we won't save this changes to the package.json
so that we don't rewrite v1.0.0 ot 1.0.0 in the project's package.json
Vaughan Rouesnel
@vjpr
possible to get a quick fix for this published?
Zoltan Kochan
@zkochan
I'll look into it
Zoltan Kochan
@zkochan
I will publish a fix in 30 minutes
Zoltan Kochan
@zkochan
I've prepared a new article about pnpm. pnpm's strictness helps to avoid silly bugs: https://www.kochan.io/nodejs/pnpms-strictness-helps-to-avoid-silly-bugs.html
Vaughan Rouesnel
@vjpr
Nice post. Flat node_modules was such a bad design decision.
Zoltan Kochan
@zkochan
What also disturbs me is the devDependencies. Sometimes I start using them in normal code.. but once it gets published, it breaks
Vaughan Rouesnel
@vjpr
It's a shame too, because it flat node_modules will become such a norm thst I see library owners refusing to adhere to the resolver spec.
When trying to get PRs in to fix pnpm compatibility
Zoltan Kochan
@zkochan
yeah, some people see it as a feature
Vaughan Rouesnel
@vjpr
Yep
:(
I think the main argument for it was windows file paths
Vaughan Rouesnel
@vjpr
It's good though from pnpm's perspective because pnpm will always be more reliable and correct than npm
Zoltan Kochan
@zkochan
:thumbsup:
Zoltan Kochan
@zkochan
FYI, I am less active on smaller issues because I work on optimizing the peers resolution algorithm. I managed to make it faster. I also want to avoid running peers resolution when there's a lockfile in the repo. My changes are currently on the perf/peers branch
Vaughan Rouesnel
@vjpr
cool :+1:
Zoltan Kochan
@zkochan
I am thinking about renaming shrinkwrap.yaml to node_modules_lock.yaml to avoid confusion.
There will be breaking changes in the lockfile format in pnpm@0.69 so now it would be a good time for a rename
Andrey Popp
@andreypopp
Curious if pnpm is going to support npm5 lock file format?
It looks sane to me.
Zoltan Kochan
@zkochan

I am changing pnpm's lockfile format to have all the fields that npm's lockfile has.

However, currently I don't know how can we use the same format because npm's lockfile format also specifies how the layout should look like
pnpm cannot create the same layout npm uses