Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 22:12
    kttykat commented #5276
  • 21:45
    Shinyaigeek synchronize #5408
  • 21:09
    Shinyaigeek synchronize #5408
  • 20:05
    zkochan synchronize #5338
  • 20:05

    zkochan on refactor-mutate-modules

    refactor!: pass always all proj… feat: wip (compare)

  • 20:05
    Shinyaigeek synchronize #5408
  • 20:02

    zkochan on main

    refactor: projects finding/filt… (compare)

  • 19:50

    zkochan on refactor-find-projects

    refactor: projects finding/filt… (compare)

  • 19:42
    Shinyaigeek synchronize #5408
  • 19:29
    JorgeAssaf edited #5433
  • 19:29
    JorgeAssaf labeled #5433
  • 19:29
    JorgeAssaf opened #5433
  • 19:26
    Shinyaigeek synchronize #5408
  • 19:22
    Shinyaigeek synchronize #5408
  • 19:12
    Shinyaigeek synchronize #5408
  • 18:55
    Shinyaigeek synchronize #5408
  • 18:53
    Shinyaigeek synchronize #5408
  • 18:38
    Shinyaigeek synchronize #5408
  • 18:15
    Shinyaigeek synchronize #5408
  • 15:12
    zkochan synchronize #5408
Andrei Neculau
@andreineculau
is pnpm install X supposed to be different than pnpm add X ? (install doesn't do uninstall and install, add does)
Zoltan Kochan
@zkochan
I think we don't currently have the add alias but it would just be an alias to install tjat would fail without args
Andrei Neculau
@andreineculau
ok, pnpm doesn't have an add alias but i can do pnpm add ?!
Andrei Neculau
@andreineculau
i see.. pnpm add will be proxied as is to npm add
opened up a new issue
Zoltan Kochan
@zkochan
We need to add a whitelist of commands that are proxies to npm
The new add alias was a surprise to me
JR Utily
@JR-Utily
Hello, I have a problem with some dependency resolution, it works fine with npm, but failed to find it with pnpm
There is a dependency declared as "inquirer-path": "" in the package.json of the dep I want to include in my app
So I can not modify it myself, this is just what I get
pnpm answer me "No compatible version found: inquirer-path@

Versions in registry:
1.0.0-alpha1, 1.0.0-alpha2, 1.0.0-alpha3, 1.0.0-alpha4, 1.0.0-alpha5, 1.0.0-beta2, 1.0.0-beta3 "
I wonder if there is a way to force resolution when this happen
Nik
@nikdojo
I have no answer, but have a related to a version issue. In package.json there r some modules with * version. If the module doesn't exist in npm repo, the module won't be installed, as well as other modules from deps list. Ember CLI requires to have * as a value for addons development. npm handles it fine and installs the rest of modules.
Zoltan Kochan
@zkochan
@nikdojo I never heard about this use case. If it works with npm then file an issue please. With a package.json for reproducing, if possible
@JR-Utily a dependency with no spec? If it works with npm then we'll fix it, please create an issue for it
Nik
@nikdojo
Sure, I'm just testing the whole day today with all those fixes for Ember resolver. It works better now, but new issues appear, including this one.
JR Utily
@JR-Utily
this is while including https://github.com/aam229/local-dependencies in my deps
Zoltan Kochan
@zkochan
so you say the "inquirer-path": "*", part fails? That would be weird but I'll recheck tonight. The fix will be easy if that is the case
JR Utily
@JR-Utily
that's it pnpm/pnpm#865
thanks a lot
JR Utily
@JR-Utily
@zkochan thanks for the fix :)
Zoltan Kochan
@zkochan
you're welcome
Wei Wang
@onlywei
Hi, what happened to the README? https://www.npmjs.com/package/pnpm
Zoltan Kochan
@zkochan
I don't know, I published it the same way I always did
the readme is in the registry. Maybe the npm website has issues
Wei Wang
@onlywei
Spent all day making this reproducible error case for pnpm: pnpm/pnpm#867
Wei Wang
@onlywei
how does pnpm determine what URL to fetch from?
Sometimes it tries to hit:
://npm-registry.domain/p/pnpm/_attachments/pnpm-1.10.1.tgz (correct)
And sometimes it tries to hit:
://npm-registry.domain/pnpm/-/pnpm-1.10.1.tgz(causes 406)
Zoltan Kochan
@zkochan
sometimes from the shrinkwrap file and if there is no such then from the dist field of the metadata.
Zoltan Kochan
@zkochan
@onlywei the fix is ready for CR pnpm/supi#6
Wei Wang
@onlywei
@zkochan thanks! What's the best way for me to test this before you cut a release?
Zoltan Kochan
@zkochan
you can clone pnpm from master and supi from the fix/npm-enterprise branch. Link supi to pnpm, run npm run tsc in both projects
and then you can use pnpm from the cloned repo
Joe Schmitt
@josephschmitt
@zkochan gonna give this a go
thanks for looking into it and fixing so quickly. this one was killing us all week until we were finally able to make a narrow test case
Zoltan Kochan
@zkochan
np. It is a pleasure to fix something when you already know what is the issue
you did all the hard work
Joe Schmitt
@josephschmitt
@zkochan hmm, not entirely clear on which supi link function i should be running. is it just supi.link()? and what are the params?
Zoltan Kochan
@zkochan
I mean link the cloned supi repo to pnpm
pnpm link ../supi (from the cloned pnpm repo)
Joe Schmitt
@josephschmitt
ooooh, gotcha
Joe Schmitt
@josephschmitt
@zkochan getting this error: ERROR ENOENT: no such file or directory, open '/usr/pnpm-global/node_modules/supi/package.json'
does this not work with locally installed pnpm?
i ran ./node_modules/.bin/pnpm link supi/
Zoltan Kochan
@zkochan
better try with the globally installed one
and using a relative path
Zoltan Kochan
@zkochan
@josephschmitt I can just publish it
all tests are passing so it should work
Joe Schmitt
@josephschmitt
@zkochan ok, sounds good. we can install and test within the hour
Zoltan Kochan
@zkochan
ok
Wei Wang
@onlywei
testing now
Wei Wang
@onlywei
seems promising so far
had to regenerate my shrinkwrap.yaml files, which is to be expected
Wei Wang
@onlywei
great success!
Zoltan Kochan
@zkochan
:tada:
Zoltan Kochan
@zkochan

I am rewriting parts of pnpm using reactive programming. It looks a lot better and I think it will help to write more complex/performant algorithms.
However, I am just learning reactive programming, so I'd appreciate if someone more experienced could do code reviews

has anyone experience with reactive programming?

Zoltan Kochan
@zkochan
In case someone is interested in the reactive rewrite: pnpm/supi#8
Vaughan Rouesnel
@vjpr
@zkochan can you point me in the right direction for pnpm/pnpm#600