Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:42

    zkochan on main

    chore(release): 7.18.1 (compare)

  • 09:42

    zkochan on v7.18.1

    (compare)

  • 09:37

    zkochan on fix-ignore-cves

    (compare)

  • 09:37

    zkochan on main

    fix(audit): don't skip vulnerab… (compare)

  • 09:37
    zkochan closed #5756
  • 09:36

    zkochan on main

    fix: it should possible to use … (compare)

  • 09:36

    zkochan on 5754

    (compare)

  • 09:36
    zkochan closed #5754
  • 09:36
    zkochan closed #5757
  • 07:21
    zhenzhenChange commented #5744
  • 01:01
    zkochan commented #5741
  • 00:46
    zkochan opened #5757
  • 00:46

    zkochan on 5754

    fix: it should possible to use … (compare)

  • 00:01
    zkochan commented #5755
  • Dec 05 23:59
    zkochan review_requested #5756
  • Dec 05 23:59
    zkochan opened #5756
  • Dec 05 23:58

    zkochan on fix-ignore-cves

    fix(audit): don't skip vulnerab… (compare)

  • Dec 05 23:49

    zkochan on main

    fix(reporter): update notifier … (compare)

  • Dec 05 23:49

    zkochan on change-update-instruction

    (compare)

  • Dec 05 23:49
    zkochan closed #5750
Zoltan Kochan
@zkochan
and then you can use pnpm from the cloned repo
Joe Schmitt
@josephschmitt
@zkochan gonna give this a go
thanks for looking into it and fixing so quickly. this one was killing us all week until we were finally able to make a narrow test case
Zoltan Kochan
@zkochan
np. It is a pleasure to fix something when you already know what is the issue
you did all the hard work
Joe Schmitt
@josephschmitt
@zkochan hmm, not entirely clear on which supi link function i should be running. is it just supi.link()? and what are the params?
Zoltan Kochan
@zkochan
I mean link the cloned supi repo to pnpm
pnpm link ../supi (from the cloned pnpm repo)
Joe Schmitt
@josephschmitt
ooooh, gotcha
Joe Schmitt
@josephschmitt
@zkochan getting this error: ERROR ENOENT: no such file or directory, open '/usr/pnpm-global/node_modules/supi/package.json'
does this not work with locally installed pnpm?
i ran ./node_modules/.bin/pnpm link supi/
Zoltan Kochan
@zkochan
better try with the globally installed one
and using a relative path
Zoltan Kochan
@zkochan
@josephschmitt I can just publish it
all tests are passing so it should work
Joe Schmitt
@josephschmitt
@zkochan ok, sounds good. we can install and test within the hour
Zoltan Kochan
@zkochan
ok
Wei Wang
@onlywei
testing now
Wei Wang
@onlywei
seems promising so far
had to regenerate my shrinkwrap.yaml files, which is to be expected
Wei Wang
@onlywei
great success!
Zoltan Kochan
@zkochan
:tada:
Zoltan Kochan
@zkochan

I am rewriting parts of pnpm using reactive programming. It looks a lot better and I think it will help to write more complex/performant algorithms.
However, I am just learning reactive programming, so I'd appreciate if someone more experienced could do code reviews

has anyone experience with reactive programming?

Zoltan Kochan
@zkochan
In case someone is interested in the reactive rewrite: pnpm/supi#8
Vaughan Rouesnel
@vjpr
@zkochan can you point me in the right direction for pnpm/pnpm#600
Zoltan Kochan
@zkochan
I am on vacation, so unlikely will I contribute this week but I will try to answer shortly for any questions.
I'll read the issue and try to give some clues
Vaughan Rouesnel
@vjpr
thanks, just the old Z_BUF_ERROR error...
Zoltan Kochan
@zkochan
If this is concurrency issue maybe you can try to throttle unpack stream or whatnot
Vaughan Rouesnel
@vjpr
it seems to be happening predictibly for me at the same point. i will see what tar is causing it today.
so i dont think its concurrency….maybe an unpack-stream edge case
Daniel Bayley
@danielbayley
@zkochan What are your thoughts on implementing features that the npm core team refuse to consider? Requests such as being able to use other formats like YAML instead of package.json, and more powerful lifecycle scripts keep cropping up for example. I am working on a bunch of ideas to solve these frequent annoyances for myself in the form of more npm modules (and others have attempted with modules like nps and npm-run-all), but ultimately there would be a lot less need for hacky/workarounds if such features were supported in [p]npm core. So I'm just wondering whether your opinion is generally "pnpm is solely focussed on speed/disk space efficiency over regular npm", or more "open to other improvements over npm, which can help pnpm gain more traction"… what are your thoughts?
Zoltan Kochan
@zkochan
@danielbayley I am not sure about adding it to core yet but I am fine creating a "hook system" that will allow to do things like you described. See: pnpm/pnpm#861
Daniel Bayley
@danielbayley
@zkochan Interesting… I'll check it out thanks!
Zoltan Kochan
@zkochan
Just some status updates. I am on vacation this week.
Probably I won't add new features to pnpm v1. I might fix some bugs till v2 is not ready.
For the v2 beta I have to finish the "reactive" rewrite of pnpm, see PR: pnpm/supi#8
Vaughan Rouesnel
@vjpr
@zkochan could you explain package-store/lib/network/got.js#download?
it is downloading a tar with npm-registry-client which is then being written to disk using createWriteStreamAtomic, while at the same time being piped to unpackStream.local?
Vaughan Rouesnel
@vjpr
also, there is no ~/.pnpm-registry anymore?
Zoltan Kochan
@zkochan

it is downloading a tar with npm-registry-client which is then being written to disk using createWriteStreamAtomic, while at the same time being piped to unpackStream.local?

yes, the tarball is being saved and unpacked at the same time. We keep the tarball in the store as well (in case the unpacked version gets mutated)

also, there is no ~/.pnpm-registry anymore?

correct, now the tarballs are saved in the store (~/.pnpm-store), in the folders where the unpacked packages are

Vaughan Rouesnel
@vjpr
can i clear a package from the store by just removing its dir?
or is there an index/manifest somewhere...
Zoltan Kochan
@zkochan
there is an index in the root of store. I don't currently remember what will happen if you remove the folder but leave it in the index.
Vaughan Rouesnel
@vjpr
i think it breaks things...
Zoltan Kochan
@zkochan
I think we can add some commands for these, if needed
Vaughan Rouesnel
@vjpr
maybe we need a pnpm store remove [package]
Zoltan Kochan
@zkochan
there is pnpm store prune
the store prune will remove it if no project has links to the package
so if you remove the node_modules to which it is linked

maybe we need a pnpm store remove [package]

maybe, but right now I don't know how it should behave. Like should it leave the package in the node_modules?

Vaughan Rouesnel
@vjpr
the use case would be when you want to force a re-download
so something that would make the next pnpm i says “this package has been modified in the store…redownloading'
Zoltan Kochan
@zkochan
it does that currently
Vaughan Rouesnel
@vjpr
hmm ok
Zoltan Kochan
@zkochan
Like if you modify a file in the package, it will be reunpacked