Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 19:08
    igorakkerman commented #5135
  • 19:06
    igorakkerman commented #5135
  • 19:05
    igorakkerman commented #5135
  • 19:05
    igorakkerman commented #5135
  • 19:04
    igorakkerman commented #5135
  • 18:54
    igorakkerman commented #5135
  • 18:34
    igorakkerman commented #5135
  • 18:33
    igorakkerman commented #5135
  • 16:50
    zkochan commented #5965
  • 16:29
    zkochan commented #5965
  • 16:25
    keithlayne commented #5965
  • 15:56

    zkochan on main

    perf: optimize fs-hard-link-dir fix(fs.hard-link-dir): ignore b… (compare)

  • 15:51
    aparajita closed #2634
  • 15:50
    aparajita closed #2503
  • 15:36

    zkochan on hard-link-dir

    perf: optimize fs-hard-link-dir fix(fs.hard-link-dir): ignore b… (compare)

  • 15:28

    zkochan on main

    fix: issues with storybook and … (compare)

  • 15:28

    zkochan on 5976

    (compare)

  • 15:28
    zkochan closed #5976
  • 15:28
    zkochan closed #5998
  • 15:00
    WoLfulus commented #5790
Vaughan Rouesnel
@vjpr
it seems to be happening predictibly for me at the same point. i will see what tar is causing it today.
so i dont think its concurrency….maybe an unpack-stream edge case
Daniel Bayley
@danielbayley
@zkochan What are your thoughts on implementing features that the npm core team refuse to consider? Requests such as being able to use other formats like YAML instead of package.json, and more powerful lifecycle scripts keep cropping up for example. I am working on a bunch of ideas to solve these frequent annoyances for myself in the form of more npm modules (and others have attempted with modules like nps and npm-run-all), but ultimately there would be a lot less need for hacky/workarounds if such features were supported in [p]npm core. So I'm just wondering whether your opinion is generally "pnpm is solely focussed on speed/disk space efficiency over regular npm", or more "open to other improvements over npm, which can help pnpm gain more traction"… what are your thoughts?
Zoltan Kochan
@zkochan
@danielbayley I am not sure about adding it to core yet but I am fine creating a "hook system" that will allow to do things like you described. See: pnpm/pnpm#861
Daniel Bayley
@danielbayley
@zkochan Interesting… I'll check it out thanks!
Zoltan Kochan
@zkochan
Just some status updates. I am on vacation this week.
Probably I won't add new features to pnpm v1. I might fix some bugs till v2 is not ready.
For the v2 beta I have to finish the "reactive" rewrite of pnpm, see PR: pnpm/supi#8
Vaughan Rouesnel
@vjpr
@zkochan could you explain package-store/lib/network/got.js#download?
it is downloading a tar with npm-registry-client which is then being written to disk using createWriteStreamAtomic, while at the same time being piped to unpackStream.local?
Vaughan Rouesnel
@vjpr
also, there is no ~/.pnpm-registry anymore?
Zoltan Kochan
@zkochan

it is downloading a tar with npm-registry-client which is then being written to disk using createWriteStreamAtomic, while at the same time being piped to unpackStream.local?

yes, the tarball is being saved and unpacked at the same time. We keep the tarball in the store as well (in case the unpacked version gets mutated)

also, there is no ~/.pnpm-registry anymore?

correct, now the tarballs are saved in the store (~/.pnpm-store), in the folders where the unpacked packages are

Vaughan Rouesnel
@vjpr
can i clear a package from the store by just removing its dir?
or is there an index/manifest somewhere...
Zoltan Kochan
@zkochan
there is an index in the root of store. I don't currently remember what will happen if you remove the folder but leave it in the index.
Vaughan Rouesnel
@vjpr
i think it breaks things...
Zoltan Kochan
@zkochan
I think we can add some commands for these, if needed
Vaughan Rouesnel
@vjpr
maybe we need a pnpm store remove [package]
Zoltan Kochan
@zkochan
there is pnpm store prune
the store prune will remove it if no project has links to the package
so if you remove the node_modules to which it is linked

maybe we need a pnpm store remove [package]

maybe, but right now I don't know how it should behave. Like should it leave the package in the node_modules?

Vaughan Rouesnel
@vjpr
the use case would be when you want to force a re-download
so something that would make the next pnpm i says “this package has been modified in the store…redownloading'
Zoltan Kochan
@zkochan
it does that currently
Vaughan Rouesnel
@vjpr
hmm ok
Zoltan Kochan
@zkochan
Like if you modify a file in the package, it will be reunpacked
from the tarball that is in the store
Vaughan Rouesnel
@vjpr
but what if i delete entirely
rm -rf ~/.pnpm-store/reigstry…/foo/1.0.0
Zoltan Kochan
@zkochan
that one I don't know
you should try, I guess
Zoltan Kochan
@zkochan

@vjpr amazing investigation about the EINTEGRITY issue!

you can also contact with the npm team via their discord channel. They are very responsive there: https://discordapp.com/channels/317475976369930241/317477684999487489

Vaughan Rouesnel
@vjpr
thx will do
Vaughan Rouesnel
@vjpr
how do i join the npm discord?
Zoltan Kochan
@zkochan
Vaughan Rouesnel
@vjpr
thx
Zoltan Kochan
@zkochan
if a peer of a prod dep is resolved from a dev dep, should a warning be printed?
Zoltan Kochan
@zkochan
@andreypopp we are adding hooks to pnpm's engine. See pnpm/supi#12
readPkg and maybe preResolve for now
Zoltan Kochan
@zkochan
lynchmaniac
@lynchmaniac
Hi, Is there any roadmap for the futur release of this excellent pnpm ?
Zoltan Kochan
@zkochan
hi @lynchmaniac
you mean with the hooks?
It was already released yesterday with v1.12.0
lynchmaniac
@lynchmaniac
no i mean a global roadmap. By the way hook is an excellent idea (good article on medium :+1: )
Zoltan Kochan
@zkochan
thanks
we don't currently have a roadmap
lynchmaniac
@lynchmaniac
oki i work on a tools in action with pnpm this why i ask this :)
Zoltan Kochan
@zkochan
what do you mean? you develop some toolings that use pnpm?
lynchmaniac
@lynchmaniac
no, I will make a quickie to present pnpm at the Devfest Nantes (https://devfest.gdgnantes.com/) so it will cool to see what's happens in the futur with pnpm :)
it's an event for dev :smile:
Zoltan Kochan
@zkochan
that is awesome!