These are chat archives for ppi/framework

17th
Jan 2016
any ideas?
Vítor Brandão
@noisebleed
Jan 17 2016 01:16
Is that master?
Ross Moroney
@code-ph0y
Jan 17 2016 01:16
yeah
master skeletonapp
master framework
Vítor Brandão
@noisebleed
Jan 17 2016 01:17
Any changes made to the index.php file in the public dir?
Ross Moroney
@code-ph0y
Jan 17 2016 01:18
nope?
i see that the app function pushs null input params to the dispatch function?
Vítor Brandão
@noisebleed
Jan 17 2016 01:19
When you add a ? to the end of a sentence, does it mean you are not sure?
Ross Moroney
@code-ph0y
Jan 17 2016 01:20
yeah i was asking do you need to add something into the index.php
its a new install from master
its exactly the same
Paul Dragoonis
@dragoonis
Jan 17 2016 11:30
hi @noisebleed @code-ph0y - we’re not calling dispatch, but run()
https://github.com/ppi/skeletonapp/blob/master/public/index.php#L31
and run() passes 2 params to dispatch() always
https://github.com/ppi/framework/blob/master/src/App.php#L262
Vítor Brandão
@noisebleed
Jan 17 2016 11:42
@dragoonis check my latest changes, Request and Response were not being created in run()
Paul Dragoonis
@dragoonis
Jan 17 2016 11:42
interesting?
will look
Vítor Brandão
@noisebleed
Jan 17 2016 15:31
@dragoonis what’s the status of ppi/framework#152
Paul Dragoonis
@dragoonis
Jan 17 2016 15:31
In progress dude.
We decided to postpone this for 2.2, so I started the ChainRouter factor branch instead
Vítor Brandão
@noisebleed
Jan 17 2016 15:32
where is that?
I have local commits I guess, and not pushed.
Vítor Brandão
@noisebleed
Jan 17 2016 15:32
what about that PR? does it still make sense?
close it?
Paul Dragoonis
@dragoonis
Jan 17 2016 15:33
We can close it and re-open when working on 2.2
David McKay
@rawkode
Jan 17 2016 17:19
Evening @dragoonis
Paul Dragoonis
@dragoonis
Jan 17 2016 17:19
Hey @rawkode