These are chat archives for ppi/framework

7th
Feb 2016
Paul Dragoonis
@dragoonis
Feb 07 2016 15:31 UTC
@noisebleed i’m here! :)
Vítor Brandão
@noisebleed
Feb 07 2016 15:36 UTC
On the phone only atm
Created support/2.1 branch for skeletonapp
Would like to tag 2.1.1 for both skeletonapp and framework
Paul Dragoonis
@dragoonis
Feb 07 2016 15:42 UTC
@noisebleed let’s tag once I resolve this getNamespace() issue ?
Paul Dragoonis
@dragoonis
Feb 07 2016 15:58 UTC
@noisebleed want me to update the ppi/skeletonapp#53 PR to support/2.1 branch ?
Vítor Brandão
@noisebleed
Feb 07 2016 16:04 UTC
Yeah
Paul Dragoonis
@dragoonis
Feb 07 2016 16:05 UTC
@noisebleed just tried to make a new PR and it says: tests-dispatch is up to date with all commits from support/2.1. Try switching the base for your comparison.
Vítor Brandão
@noisebleed
Feb 07 2016 16:08 UTC
Leave and I will bring master into support
Paul Dragoonis
@dragoonis
Feb 07 2016 16:08 UTC
Closed open PR’s. Waiting for your signal.
Vítor Brandão
@noisebleed
Feb 07 2016 16:08 UTC
But I would prefer to do it the other way around. This way is awkward
Signal for?
Paul Dragoonis
@dragoonis
Feb 07 2016 16:09 UTC
nvm - what do you wanna do ? I have tests-dispatch ready to make a new PR.
Vítor Brandão
@noisebleed
Feb 07 2016 16:10 UTC
Leave the PR as is against master
Paul Dragoonis
@dragoonis
Feb 07 2016 16:10 UTC
I close it - will re-open.
github is being retarded .. tests-dispatch is up to date with all commits from master.
Vítor Brandão
@noisebleed
Feb 07 2016 16:11 UTC
Maybe you didn't pushed any commits yet?
Paul Dragoonis
@dragoonis
Feb 07 2016 16:12 UTC
Pauls-MBP:skeletonapp dragoonis$ git br
  master
* tests-dispatch
Pauls-MBP:skeletonapp dragoonis$ git push
Everything up-to-date
This message was deleted
@noisebleed i successfully re-opened PR against master - ppi/skeletonapp#53
Vítor Brandão
@noisebleed
Feb 07 2016 16:20 UTC
Check my comments and try to fix the travis build. You can remove php-cs checks.
Paul Dragoonis
@dragoonis
Feb 07 2016 16:20 UTC
@noisebleed already removed php-cs checks.
ppi/skeletonapp@dcb0b35
Unable to replicate the getNamespace() bug - I get: OK (2 tests, 2 assertions) on localhost
Vítor Brandão
@noisebleed
Feb 07 2016 16:22 UTC
In which php version does it happen?
PHP 5.5 and 5.6
Vítor Brandão
@noisebleed
Feb 07 2016 16:22 UTC
What version are you running locally?
Paul Dragoonis
@dragoonis
Feb 07 2016 16:23 UTC
PHP 5.5.14 (cli) (built: Sep 9 2014 19:09:25)
Inside of our VM is: PHP 5.5.30-1+deb.sury.org~trusty+1 (cli) (built: Oct 4 2015 16:23:01)
@noisebleed can you try to replicate? just “vendor/bin/phpunit” is the execution point
Vítor Brandão
@noisebleed
Feb 07 2016 16:46 UTC
Not at home.
Will be at the laptop in 1h
Vítor Brandão
@noisebleed
Feb 07 2016 16:57 UTC
Push it to travis and check results
Maybe it's not an issue anymore
Paul Dragoonis
@dragoonis
Feb 07 2016 17:08 UTC
@noisebleed this commit is breaking things - i want to require ^2.1-dev ppi/ppi-distribution-module@51fff32
Paul Dragoonis
@dragoonis
Feb 07 2016 17:21 UTC
This message was deleted
Paul Dragoonis
@dragoonis
Feb 07 2016 17:29 UTC
nvm - that commit is ok
Paul Dragoonis
@dragoonis
Feb 07 2016 18:42 UTC
@noisebleed all is green in the PR. ppi/skeletonapp#53
Paul Dragoonis
@dragoonis
Feb 07 2016 19:00 UTC
It’s now ppi/skeletonapp#54
Merged it against support/2.1
Paul Dragoonis
@dragoonis
Feb 07 2016 19:25 UTC
@noisebleed 2.1.1 release created - with the 2 unit tests - here’s the modified composer.json for skeletonapp
https://github.com/ppi/skeletonapp/blob/support/2.1/composer.json#L23
Vítor Brandão
@noisebleed
Feb 07 2016 20:55 UTC
Checking now
Vítor Brandão
@noisebleed
Feb 07 2016 21:02 UTC
@dragoonis where are the PRs?
Paul Dragoonis
@dragoonis
Feb 07 2016 21:02 UTC
@noisebleed I merged them. Look at latest closed ones.
Vítor Brandão
@noisebleed
Feb 07 2016 21:03 UTC
did you merged support/2.1 into master?
Paul Dragoonis
@dragoonis
Feb 07 2016 21:04 UTC
@noisebleed nope - you own ‘master’ :)
Vítor Brandão
@noisebleed
Feb 07 2016 21:04 UTC
ppi/skeletonapp@9aeaa49 2 hours ago
in master
how?
Paul Dragoonis
@dragoonis
Feb 07 2016 21:05 UTC
I comitted a readme updated to master (2.2). Unrelated to the 2.1 I was doing earlier.
Vítor Brandão
@noisebleed
Feb 07 2016 21:05 UTC
ok
Paul Dragoonis
@dragoonis
Feb 07 2016 21:37 UTC
Working on Documentation tonight :)
Paul Dragoonis
@dragoonis
Feb 07 2016 22:42 UTC
Cleaned up structure - pages now much flatter - http://docs.ppi.io/latest/
Vítor Brandão
@noisebleed
Feb 07 2016 23:23 UTC
I’ve noticed we have a cache and logs dirs at root level. Why is that? They should exist under app/
Paul Dragoonis
@dragoonis
Feb 07 2016 23:23 UTC
Accident?
should be in app
I don’t see them dirs at root level - link ?
Vítor Brandão
@noisebleed
Feb 07 2016 23:24 UTC
true. they only exist locally. don’t know why
Paul Dragoonis
@dragoonis
Feb 07 2016 23:24 UTC
cool
Vítor Brandão
@noisebleed
Feb 07 2016 23:25 UTC
./app/check is now happy :)
                                          _
                           _____   _____ |_|
                          / __  | /  __ | /|
                         | |__| || |__| || |
                         |  ___/ |  ___/ | |
                         | |     | |     |_|
                         |/      |/

                         Framework Version 2

                      -- Requirements Check --


* Configuration file used by PHP: /usr/local/etc/php/5.6/php.ini

** ATTENTION **
*  The PHP CLI can use a different php.ini file
*  than the one used with your web server.
*  To be on the safe side, please also launch the requirements check
*  from your web server using the public/config.php script.

** Mandatory requirements **

 OK       PHP version must be at least 5.3.23 (5.6.17 installed)
 OK       PHP version must not be 5.3.16 as PPI won't work properly with it
 OK       Vendor libraries must be installed
 OK       app/cache/ directory must be writable
 OK       app/logs/ directory must be writable
Paul Dragoonis
@dragoonis
Feb 07 2016 23:26 UTC
sweet!
Vítor Brandão
@noisebleed
Feb 07 2016 23:26 UTC
Gitter copy&paste is great
Paul Dragoonis
@dragoonis
Feb 07 2016 23:35 UTC
@noisebleed installation, application, modules pages are cleaned up!
Vítor Brandão
@noisebleed
Feb 07 2016 23:36 UTC
providing a fix for distribution-module. Should hit github shortly
Paul Dragoonis
@dragoonis
Feb 07 2016 23:36 UTC
sweeeet!
Vítor Brandão
@noisebleed
Feb 07 2016 23:44 UTC
Done.