Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 15:09
    gvolpe commented #245
  • 09:09
    scala-steward opened #245
  • Sep 17 21:48

    gvolpe on 2.0.0

    (compare)

  • Sep 17 21:22

    gvolpe on gh-pages

    updated site updated site updated site and 6 more (compare)

  • Sep 17 21:19

    gvolpe on publishing-blocker

    (compare)

  • Sep 17 21:19

    gvolpe on master

    Creating a publisher requires a… Blocker is now required to crea… Updating docs and 2 more (compare)

  • Sep 17 21:19
    gvolpe closed #244
  • Sep 17 21:19
    gvolpe closed #230
  • Sep 17 21:13
    gvolpe synchronize #244
  • Sep 17 21:13

    gvolpe on publishing-blocker

    Update site/src/main/tut/publis… (compare)

  • Sep 17 19:36
    gvolpe edited #244
  • Sep 17 19:22
    gvolpe synchronize #244
  • Sep 17 19:22

    gvolpe on publishing-blocker

    Updating docs (compare)

  • Sep 17 19:18
    gvolpe commented #244
  • Sep 17 19:14
    gvolpe synchronize #244
  • Sep 17 19:14

    gvolpe on publishing-blocker

    Blocker is now required to crea… (compare)

  • Sep 17 18:00
    gvolpe opened #244
  • Sep 17 18:00
    gvolpe review_requested #244
  • Sep 17 17:58

    gvolpe on publishing-blocker

    Creating a publisher requires a… (compare)

  • Sep 17 16:43

    gvolpe on 2.0.0

    (compare)

Gavin Bisesi
@Daenyth
I have a bit of code where I want to test that I'm handling a ResilientStream usage correctly
but to test it, I need rabbit to fail
which I can't figure out how to make happen programatically
so I want to pass a wrapped connection that fails randomly
Gabriel Volpe
@gvolpe
Go for it 😉
Gabriel Volpe
@gvolpe
Also @Daenyth if you're interested in becoming a maintainer I'd be glad to grant you permissions, no pressure though 😁
Gavin Bisesi
@Daenyth
Sure, why not
I don't know what I'm doing in terms of release management but I don't mind contributing in general
Gabriel Volpe
@gvolpe
Awesome, that aligns pretty well with the politics I've been practicing so far 😂
Gabriel Volpe
@gvolpe
@Daenyth done. The release process needs to be improved and as of today I only have permissions to release and I've no idea how I can give you permissions to deploy to Nexus for example, but we can figure it out :)
Gavin Bisesi
@Daenyth
not a priority for me for now - I'm happy to ping you as needed for that sort of thing ;)
Gabriel Volpe
@gvolpe
Great :)
Basavaraj Kalloli
@scalolli
@gvolpe the examples link on this page: https://fs2-rabbit.profunktor.dev/resiliency.html is broken, not sure if there is an issue logged already, maybe I should I try fixing it?
I will try fixing it now
Done fixed awaiting merge
Gavin Bisesi
@Daenyth
@scalolli review request me, I'll get to it as I can
Basavaraj Kalloli
@scalolli
@Daenyth unfortunately I cannot add you as the reviewer not sure why
Gavin Bisesi
@Daenyth
oh I think you need repo permissions to request review, maybe
I marked it so I hopefully won't forget
Gabriel Volpe
@gvolpe
Cool thanks for looking into it Gavin!
Gabriel Volpe
@gvolpe
@Daenyth I've been out of the loop with the latest fs2 / cats-effect releases. What would you suggest for the next release of fs2-rabbit? I was waiting for the releases based on cats-2.x.x but I'm not sure if that's ideal. If I do an RC4 with the new dependencies based on Cats 2 are we breaking bincompat with RC3? (this also reminds me that I've never setup MiMa...)
Gavin Bisesi
@Daenyth
@gvolpe I think you're OK bincompat-wise; except for the laws, it's all bincompat with 1.x. We could do another RC/M release on the latest cats-effect M release but I don't think it's needed. We can do a full release once 2.0 final is out
Gabriel Volpe
@gvolpe
Cool thanks, will go with the latter then!
alexander-branevskiy
@alexander-branevskiy
hello @gvolpe ! Can you please help me? Should I use a separate thread pool while consuming messages from rabbit ?
Or it’s sufficient to use default
I haven’t found anything related to providing custom thread pool
Gabriel Volpe
@gvolpe
I don't know how people are using it tbh. The library doesn't give you a way to provide a custom thread pool (maybe we should now that there's Blocker et al). It runs on the default EC given by cats-effect. So you could give a custom EC using IO.contextShift(customEC) but I wouldn't worry about it since it's an async client.
I'd use it as is and if it becomes a bottleneck maybe think about giving it a different EC. So far I haven't heard of anyone having issues with it but I haven't used it in a long time so maybe people currently using it can share how they are using it.
alexander-branevskiy
@alexander-branevskiy
Ok thanks
alexander-branevskiy
@alexander-branevskiy
@gvolpe seems you're wrong
i've checked this signature and seems basicPublish is blocking operation
/**
 * Publish a message.
 *
 * Publishing to a non-existent exchange will result in a channel-level
 * protocol exception, which closes the channel.
 *
 * Invocations of <code>Channel#basicPublish</code> will eventually block if a
 * <a href="https://www.rabbitmq.com/alarms.html">resource-driven alarm</a> is in effect.
 *
 * @see com.rabbitmq.client.AMQP.Basic.Publish
 * @see <a href="https://www.rabbitmq.com/alarms.html">Resource-driven alarms</a>
 * @param exchange the exchange to publish the message to
 * @param routingKey the routing key
 * @param props other properties for the message - routing headers etc
 * @param body the message body
 * @throws java.io.IOException if an error is encountered
 */
void basicPublish(String exchange, String routingKey, BasicProperties props, byte[] body) throws IOException; 
Gavin Bisesi
@Daenyth
should be straightforward to fix, I think.
Gabriel Volpe
@gvolpe
Yeah we should fix that. Consuming is definitely async but we missed the publishing part. Feel free to raise an issue on Github or even better send a PR @alexander-branevskiy :)
alexander-branevskiy
@alexander-branevskiy
@gvolpe created the issue profunktor/fs2-rabbit#230 =)
Gabriel Volpe
@gvolpe
:+1:
alexander-branevskiy
@alexander-branevskiy
will try to find some time to handle it
Gabriel Volpe
@gvolpe
I'm commenting on the issue now
alexander-branevskiy
@alexander-branevskiy
yea i see)
currently, I'm using the second approach
Gabriel Volpe
@gvolpe
that's fine :+1:
Blocker just makes clearer that you're shifting the execution into a blocking context
Gavin Bisesi
@Daenyth
It should be Blocker on the ce-2 version
Gabriel Volpe
@gvolpe
@Daenyth whenever you have 5 mins could you have a look at profunktor/fs2-rabbit#241 :pray:
Once that is merged I'll get a PR in for profunktor/fs2-rabbit#230
Gavin Bisesi
@Daenyth
:+1:
Gabriel Volpe
@gvolpe
Thanks!
Gabriel Volpe
@gvolpe
Thanks to all the contributors :tada: