profunktor.dev/redis4cats

Redis client for Scala built on top of Cats Effect, Fs2 and Lettuce (formerly Fs2 Redis) -> https://redis4cats.profunktor.dev/

Ben Plommer

@bplommer

Might be worth rereleasing v0.12.0 as v0.12.2 in case someone breaks binary compatibility by updating

Gabriel Volpe

@gvolpe:matrix.org

[m]

will do, for some reason GH does not allow me to create a tag release against a previous tag or specific commit, only against an active branch or recent commit 🤷‍♂️

I'll have to pull the tag and push a branch to do it

Ben Plommer

@bplommer

🤦

Gabriel Volpe

@gvolpe:matrix.org

[m]

seems to be a more complicated than expected

if you know of some users migrating to v0.12.1, please recommend them to downgrade to v0.12.0, I'll add this info in the release notes of v0.12.0

https://github.com/profunktor/redis4cats/releases/tag/v0.12.0

λoλcat

@catostrophe

I suppose the usage of Dispatcher is wrong in the CE3 branch

Has anybody tried it?

I will make a PR that probably should work.

Gabriel Volpe

@gvolpe:matrix.org

[m]

I haven't tried it, what's wrong with that usage?

λoλcat

@catostrophe

the scope of dispatcher

will make a pr in a minute

and explain

λoλcat

@catostrophe

profunktor/redis4cats#528

If we use Dispatcher in place as Dispatcher[F].use { ... } we will lose everything just after the exit from the use scope

Dispatcher is a resource and its inner Supervisor cancels all its fibers on exit

We definitely need some tests :)

λoλcat

@catostrophe

cc @bplommer

Ben Plommer

@bplommer

Good catch, I'll take a look later

λoλcat

@catostrophe

I myself have recently started discovering CE3 peculiarities. Dispatcher is a tricky thing. One cannot replace ConcurrentEffect with Dispatcher not thinking about it's lifetime

Ben Plommer

@bplommer

Feels like the gun was jumped a bit in releasing 3.0 without robust guidelines for Soviet interop

λoλcat

@catostrophe

https://github.com/typelevel/fs2/blob/main/reactive-streams/src/main/scala/fs2/interop/reactivestreams/package.scala#L52

same pattern

wrap dispatcher in Stream than flatMap

Gabriel Volpe

@gvolpe:matrix.org

[m]

ha! awesome @catostrophe I am just getting started with CE3 so really I wasn't aware Dispatcher depends on in the inner Supervisor

I'll have a look at the PR in a few mins, on a few meetings now

λoλcat

@catostrophe

I just tried to wrap AsyncConnectionPoolSupport in F[_] to get a Resource[F, () => Resource[F, RedisCommand[F, K, V]]] but I couldn't since some constructor in redis4cats is private. So I probably should make a PR.

@gvolpe:matrix.org have you considered providing a functional API for pooling? Are there any nuances I should know before starting doing it?

Gabriel Volpe

@gvolpe:matrix.org

[m]

λoλcat: wasn't really aware of it, seems like it could be a good addition to the library :)

Ben Plommer

@bplommer

@gvolpe:matrix.org v1.0.1 doesn't seem to be on Maven Central :|

Ben Plommer

@bplommer

Oh nvm, that's a draft release

Gabriel Volpe

@gvolpe:matrix.org

[m]

Hehe no problems, I guess it's time to make a new RC

Ben Plommer

@bplommer

:+1:

Gabriel Volpe

@gvolpe:matrix.org

[m]

https://github.com/profunktor/redis4cats/releases/tag/v1.0.0-RC3

Ben Plommer

@bplommer

splendid

Nacho Castillo

@nachocodexx

Hi, I'm struggling to get RedisTransaction working, I get the following message: No implicit arguments of type: WitnessFilter[HList]

  def saveCreatedEvent(c: Node.Created)(implicit C:DefaultConfig) = client.use{ cmd=>
    val tx = RedisTransaction(cmd)
    val payload =  c.payload
    val tagCmd  = generateSetCommand(cmd,c.nodeId,"tag")(payload.tag)
    val commands= HList.fromList(tagCmd::Nil)
    tx.filterExec(commands)
  }

Gabriel Volpe

@gvolpe:matrix.org

[m]

@nachocodexx: I believe that Hlist.fromList never worked. Can you please raise an issue?

Gabriel Volpe

@gvolpe:matrix.org

[m]

@nachocodexx: why are you using HList.fromList though? Isn't that tagCmd a single command? You can basically do

val commands = tagCmd :: HNil

Or if you really need a dynamic list, you can use this hack but it requires knowing the types to help the compiler

 val commands = HList.fromList(List(IO.unit, IO.pure("hi"))).asInstanceOf[IO[Unit] :: IO[String] :: HNil]

Nacho Castillo

@nachocodexx

Hi @gvolpe:matrix.org ,I'm wanna run multiple commands and I tried to run in a transaction but i faced this problem.

if I follow the documentation example and create the commands list using (::) operator and HNil, the result is the same:

val commands=  tagCmd::ipAddressCmd::HNil

\ No implicit arguments of type: WitnessFilter[HCons[IO[Unit], HCons[IO[Unit], hlist.HNil.type]]]

Nacho Castillo

@nachocodexx

Which should I import in my code to get that implicit value ?

Nacho Castillo

@nachocodexx

I used RedisTransaction.exec insted of RedisTransaction.filterExec method and works like a charm

λoλcat

@catostrophe

@gvolpe:matrix.org @bplommer any blockers on the road to 1.0.0 final?

Gabriel Volpe

@gvolpe:matrix.org

[m]

There are two issues (streaming offset and hlist.fromList) I'd like to get fixed before 1.0.0 but I barely have any time these days :(

Yisrael Union

@yisraelU

is there support for authentication , I cannot find it in the documentation

Artem Sholokhov

@sholokhov

hi @gvolpe:matrix.org ! is there any plans to back port underlying dependency updates into 0.xx series? specifically I'm interested in lettuce-core 6.1.2 that seems to be merged only in 1.xx. They have fixed a nasty bug (lettuce-io/lettuce-core#1706) that we are facing in prod, but we didn't event start migrating to CE3 yet, so can't really take a 1.xx snapshot

1 reply

Ben Plommer

@bplommer

I think you should be able to manually update your app’s lettuce dependency with the current r4c version?

Artem Sholokhov

@sholokhov

thanks @bplommer , will try to swap the binary and see if its bin compatible

Where communities thrive

People

Repo info

Activity