Yes, either that or instrumenting calls to :gen and instrument :elixir as well as stdllib.
That sounds slooooow.
I'd instrument
Gen* family, :gen_* family and Tasks by default. but also give a quick way to instrument other modules instead of full apps
The only thing I miss for now is the correlation between commands of the processes. We cannot see this in the reports - and it might be meaningless since we do not know how long each command run. So there is indication that e.g.
var8 is always set after var2 because Process 2 could be faster than Process 1.
'd instrument Gen family, :gen_ family and Tasks by default. but also give a quick way to instrument other modules instead of full apps
We need something different: the current application under test needs to instrumented such that calls to Gen*, Task, SuperVisor, :ets, :dets and some replaced by their instrumented variants (I would like to add support for send() and receive..do..end as well).
The basic idea is to instrument the application under test only. In special cases, it might be helpful to instrument other applications or modules as well, but this really depends on the situation.
Instrumenting modules can always be done by calling
instrument_module(), which is the working horse of instrument_app().
*calls to those things
So, I would go for experimental instrumentation as part of the next release, and then we follow with better support for concurrency in the later release(s).
So there is indication that e.g. var8 is always set after var2 because Process 2 could be faster than Process 1.
this isn't clearly present even in this version:
Sequential step:
var1 = DSL.cache(10, 1)
var2 = DSL.cache(8, -2)
Parallel step:
+------------P0-------------+ +-----------P1-----------+
| var3 = DSL.cache(-18, -2) | | var5 = DSL.cache(8, 3) |
| var4 = DSL.find(-2) | | var6 = DSL.cache(0, 0) |
+---------------------------+ | var7 = DSL.flush() |
+------------------------+
all of P1 commands can be started and finished when P0 executes DSL.cache from var3... so there's no good way to visualize this
ok. it's night-night for me. see ya
Folks, do we need more for PR #157 ? Otherwise I would merge. My next plans are provide a buggy concurrent algorithm or to analyse the Registry. In addition to that I would like to start a better reporting facility for parallel processes by evaluating traces.
Alas, I am a bit swamped with work right now, so I can't review a lot currently :-/
Marking a dependency runtime: false will not start it as part of the application supervision tree when your main application is started.
Probably doesn't make a difference, I guess libgraph does not have a supervisor tree
@evnu , @x4lldux I do a nasty git operation, due to the unlucky merge operation of Alex for his let-chaining branch. I create a new branch, cherry-picked all commits and publish the old master as the new and create a new PR. Keep your fingers crossed and please don't do anything with the repo.
sometimes you gotta do what you gotta do
And it worked out well.
Maybe someone here has a little bit of input for this: I sometimes find a failing counter example on CI; I can then download the counter examples and fix the problem. It happens that I realize only after that I should add a specific regression test with the example I just fixed, but the list of counter examples is already clear. So, to get the example again, I download the file from CI again and make the test fail, to copy the example from the output. I think it would be nice to allow listing the counter examples on the command line instead. For example,
mix propcheck.list_counter_examples What do you think?
Perhaps a better would be helpful
@evnu Good point, semester holidays are over, obviously. I was absorbed with job related stuff in the last weeks. I will try to create a release this week, after that I am on vacation myself. It would be a point release, without too much new/fancy stuff, since the parallelism stuff is still in its early phases - unless you can convince me otherwise ...
Hmm, I should give it a try. I was commenting on #180 but until now I am somewhat behind Elixir and Erlang versions.
PropCheck 1.3.0 is released now.