Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 03:03
    jywarren commented #1783
  • 02:58
    HarshKhandeparkar commented #1783
  • 02:29
    jywarren commented #1783
  • 00:39
    codecov[bot] commented #9035
  • 00:24
    codecov[bot] commented #9035
  • 00:22
    codecov[bot] commented #9035
  • 00:19
    codeclimate[bot] commented #9035
  • 00:19
    codecov[bot] commented #9035
  • 00:19
    codeclimate[bot] commented #9035
  • 00:18
    gitpod-io[bot] commented #9035
  • 00:18
    noi5e synchronize #9035
  • 00:11
    jywarren commented #1783
  • 00:00
    codecov[bot] commented #9035
  • Jan 18 23:47
    noi5e labeled #9035
  • Jan 18 23:47
    noi5e labeled #9035
  • Jan 18 23:47
    noi5e labeled #9035
  • Jan 18 23:47
    noi5e milestoned #9035
  • Jan 18 23:47
    noi5e edited #9035
  • Jan 18 23:46
    noi5e edited #9035
  • Jan 18 23:42
    codecov[bot] commented #9035
Ruth
@RuthNjeri
I don't have the section 4 issue on my end but I do see that the profile picture in the dashboard page is not the same as the other pages.
Sudipto Ghosh
@pydevsg
@imajit this ain't an issue, went through other pages and the bottom-to-top button is working fine. The reason we haven't put it here is of the fact that this page is for creating a post and anyone can move to and fro when needed.
1 reply
The clock kinda button is to review the post you have written which you can clear or revert as needed.
Sudipto Ghosh
@pydevsg
@RuthNjeri right seems like a default image is set in the profile in https://publiclab.org/post for everyone rather than their own profile pic.
2 replies
This is something we can work upon.
Let me know your thoughts @jywarren , @cesswairimu
Sagarpreet Chadha
@sagarpreet-chadha
Hey @pydevsg , yes I just checked, this seems to be an issue. If you are interested in working in this, then you can open an gh issue for this and make a PR :)
Thanks!
Yogesh Sharma
@YogeshSharma01
Hi, @jywarren @govindgoel please review my PR publiclab/community-toolbox#420
noi5e
@noi5e
app/views/admin/assets.html.erb lists a bunch of JS scripts. is every script here present on every page?
noi5e
@noi5e
I guess there's also app/assets/javascripts/application.js - it seems like if we load a script here, it's going to appear everywhere, is that right?
noi5e
@noi5e
Is the legacy editor used anywhere on the live site still?
if params[:legacy]
  render template: 'editor/post'
else
Jeffrey Warren
@jywarren
Hi @noi5e i'm online now, working a few hours early today (instead of a full day tomorrow) so going back through your Qs now!
admin/assets i believe is a file purely for the integration test present here, if I understand right: https://github.com/publiclab/plots2/commit/2cbd203906736b4910fd728f36ec98cd0a6a9c7b#diff-11ea0ba4eb2d73398663c6ae7c91dd040c36a404960b603167a0557b3a17cf1c
I just added an explanatory comment for that in publiclab/plots2@446a812
Jeffrey Warren
@jywarren
i think it was so that we had an integration test to catch any errors in compiling or referencing JS or CSS files
application.js is the one that's used by almost every page in production

I guess there's also app/assets/javascripts/application.js - it seems like if we load a script here, it's going to appear everywhere, is that right?

yes!

People still use the legacy editor sometimes to post things that break in the rich editor. And, the legacy editor is the only way to post wiki pages, because it was very hard to ensure the rich editor worked with editing very long complex legacy wiki page content
2 replies
Jeffrey Warren
@jywarren
hi everyone, btw! happy Martin Luther King Jr. day!
2 replies
@RuthNjeri @noi5e @cesswairimu @sagarpreet-chadha it's a holiday in the US, so no need to check in or anything but if you are stuck or need input on something, I'm around. thanks!
2 replies
coder645
@coder645
ooh happy Martin Luther King Jr. day! He's definitely an inspiration to everyone!
Cheers!
Jeffrey Warren
@jywarren
hi @coder645 ! thank u, good to see u!
publiclab/plots2#9030 - @RuthNjeri i left a request for a parameter change but it was small so it can be a separate PR. Merged it, great work, love to see the system test with it, and great and helpful screenshots on the PR!
1 reply
coder645
@coder645
hi @coder645 ! thank u, good to see u!
+1 @jywarren. Hope you're doin good
Cheers!
Jeffrey Warren
@jywarren
i am! I'm burning this playlist into my brain on repeat: https://www.youtube.com/watch?v=GH5v7oIL_jc it's a great alternative to lofi hiphop streams; brazilian lofi hiphop streams!
2 replies
coder645
@coder645
ooh sounds cool...I've not heard much of hiphop myself but em buddies tell me it's addictive :laughing:
How's the pandemic situation there @jywarren ?
Things seem to have gone haywire here in Berlin
Jeffrey Warren
@jywarren
oof, pretty bad. sorry to hear that in Berlin. Trying to stay home as much as possible. Good time for cooking, woodworking, you know...
coder645
@coder645
Ooh sorry about that. But it's nice to know that you've picked up some amazing things like cooking n woodworking...this has been a great time to pick up long lost hobbies (in my case Guitar :sweat_smile: )
Jeffrey Warren
@jywarren
oh cool!
indeed
coder645
@coder645
Stay safe everyone!
Cheers!
Jeffrey Warren
@jywarren
thank you @coder645 !!!
u too!
coder645
@coder645
Thank you!
Jeffrey Warren
@jywarren
I just approved publiclab/plots2#9031 and folks, noticing we're still seeing errors related to nid uniqueness issues in the test fixtures, as in publiclab/plots2#8865 -- i'll try to fix that today, we'll see... :sweat_smile:
and thanks @coder645 for helping newcomers, i see your comments on publiclab/plots2#9026 and very helpful!
coder645
@coder645
ooh thanks @jywarren. Happy to be of help!
The pleasure's all mine
Jeffrey Warren
@jywarren
@coder645 i'd like to invite you to be a collaborator so you can do reviews too if you'd like. you should get an invite in moment!
Jeffrey Warren
@jywarren
i had an idea to invite more people to be reviewers through welcomebot and/or weekly check-ins - discussion here: publiclab/plots2#9032
coder645
@coder645
Omg that sounds so cool! Thanks a bunch @jywarren
Jeffrey Warren
@jywarren
and, other folks who've been helping review or support newcomers, i'm happy to invite you to be in the reviewers team as well, so just ping me!
:smile: :tada: :raised_hands:
coder645
@coder645
:tada:
Jeffrey Warren
@jywarren
@coder645 @Manasa2850 @gauravahlawat81 i've invited all three of you to be reviewers. Please be sure you read over our Code of Conduct (https://publiclab.org/conduct) as well, to be sure you're aware of how we ensure a safe space for everyone! Thank you!
1 reply
Jeffrey Warren
@jywarren
we now have tests running in parallel jobs, in github actions! Woohoo! publiclab/plots2#9001
2 replies
matrixbot
@matrixbot
jywarren (@jywarren:matrix.org) <img src="https://user-images.githubusercontent.com/24359/104966684-875b7980-59af-11eb-8843-693584077e56.png" alt="image"/>
Jeffrey Warren
@jywarren
Image Sequencer now also has parallel tests in Github Actions: publiclab/image-sequencer#1783