Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 10 21:38
    andrewissac opened #124
  • Nov 20 2020 22:28

    punker76 on develop

    Merge branch 'develop' into main Fix using NuGetKeyVaultSignTool (compare)

  • Nov 20 2020 22:25

    punker76 on 2.0.0

    (compare)

  • Nov 20 2020 22:20

    punker76 on main

    Fix using NuGetKeyVaultSignTool (compare)

  • Nov 20 2020 22:13

    punker76 on main

    Fix using NuGetKeyVaultSignTool (compare)

  • Nov 20 2020 22:02
    punker76 closed #120
  • Nov 20 2020 22:01

    punker76 on main

    (GH-80) Drop targeting to frame… Update appveyor script Change all to new csproj format and 45 more (compare)

  • Nov 20 2020 21:44

    punker76 on develop

    Update CI build and dependencies (compare)

  • Nov 20 2020 21:39

    punker76 on develop

    Update CI build and dependencies (compare)

  • Sep 22 2020 20:26
    eliezeralmeida commented #122
  • Sep 22 2020 20:22
    eliezeralmeida closed #107
  • Sep 22 2020 20:22
    eliezeralmeida commented #107
  • Sep 22 2020 07:42
    Josrph opened #123
  • Aug 11 2020 15:48
    CarterAAelect closed #122
  • Aug 08 2020 19:21
    timunie commented #122
  • Aug 08 2020 14:16
    CarterAAelect commented #122
  • Aug 08 2020 09:15
    timunie commented #122
  • Aug 07 2020 20:41
    CarterAAelect opened #122
  • Jul 07 2020 15:05
    realivanjx closed #121
  • Jul 07 2020 15:05
    realivanjx commented #121
juanramirez99
@juanramirez99
Hi, how i can call a SimpleChildWIndow and his own vm from another vm command? there is a sample, thanks.
Darnell Williams
@Seeker1437
Same in here
MarcOnFire
@MarcOnFire
Hello, I have a problem with SimpleChildWindow: it appears in designer, but when i run the application , the childwindow is placed inside a TabControl, when I remove the TabControl the ChilWindow appears while app is running to. Any idea? I need TabControl of course.. Thank you in advance!
MarcOnFire
@MarcOnFire
Solved, sorry.
Darnell Williams
@Seeker1437
@punker76 I am sorry to bother, Is there a way I can prevent IsOpen from closing the childwindow, as an example if there is a validation error present? I only see things for when it already changed.
Jan Karger ツ ☀
@punker76
@Seeker1437 the IsOpen property is the indicator for open and closed. I didn't know what do you mean with this.
Darnell Williams
@Seeker1437
@punker76 as an example, I allow users to edit information about a file in the ChildWindow, the Location Field has Input Validation. I would like to prevent the user from closing the ChildWindow and focus on the field with the validation error.
Keeping in mind user are allowed to close the window via Esc, clicking Modal Area, or clicking the close button
Jan Karger ツ ☀
@punker76
@Seeker1437 this can all be handled by closing event or the closing commands
Darnell Williams
@Seeker1437
Okay, I will dig deeper into this :D thanks
Darnell Williams
@Seeker1437
AFter updating to 1.4.0 of this library now the model is not see through
It used to be
Jan Karger ツ ☀
@punker76
@Seeker1437 Which model?
Jan Karger ツ ☀
@punker76
@Seeker1437 do you mean the overlay?
Darnell Williams
@Seeker1437
@punker76 thanks! I thought I looked at all the docs I missed that
fagenorn
@fagenorn
@punker76 Hey, is it normal that ShowProgressAsync take about ~5 seconds to show the child window?
Jan Karger ツ ☀
@punker76
@fagenorn normaly not. Can you show me your code or is this on GitHub?
fagenorn
@fagenorn
        private static readonly DependencyProperty WindowProperty = DependencyProperty.Register(
            "Window",
            typeof(ChildWindow),
            typeof(SelectedItemsList),
            new UIPropertyMetadata(null));

        public ChildWindow Window
        {
            private get => (ChildWindow)this.GetValue(WindowProperty);
            set => this.SetValue(WindowProperty, value);
        }

        private async void Add(object sender, RoutedEventArgs e)
        {
            var metroWindow = Application.Current.MainWindow as MetroWindow;
            await metroWindow.ShowChildWindowAsync(this.Window);
        }
The DependencyProperty is then binded to plain simpleChildWindow
The funny thing is, it only takes that long to load the first time it opens the child window, after that it's almost instantly even if a different child window is set for the DependencyProperty.
Jan Karger ツ ☀
@punker76
@fagenorn why is your Window dep property private? I think for binding it should be public
public static readonly DependencyProperty WindowProperty = DependencyProperty.Register(
    "Window",
    typeof(ChildWindow),
    typeof(SelectedItemsList),
    new UIPropertyMetadata(null));

public ChildWindow Window
{
    get => (ChildWindow)this.GetValue(WindowProperty);
    set => this.SetValue(WindowProperty, value);
}
fagenorn
@fagenorn
either seems to work for me, but even when set to public the load time is not imrpoved. I actually don't mind the loading, but I am trying to show ShowProgressAsync() while it's loading but it does't seem to show the dialog itself (only the black overlay) because it loads the child window on the same thread maybe?
Jan Karger ツ ☀
@punker76
@fagenorn so, what are you loading which blocks the ui thread?
fagenorn
@fagenorn
Only thing that is loading is await metroWindow.ShowChildWindowAsync(this.Window); I show the progress dialog before calling it, but it doesn't seem to show, only the black overlay.
Jan Karger ツ ☀
@punker76
@fagenorn -> priv chat
Todd Burnside
@toddburnside
SimpleChildWindow 1.4 does not appear to work with MahApps.Metro 1.6 alpha. Is there any easy way for us to fix this locally? Or, could we get an alpha for SimpleChildWindow that works with the MahApps.Metro alpha?
Jan Karger ツ ☀
@punker76
@toddburnside Yeah, I will publish an alpha which will work with it
Todd Burnside
@toddburnside
Great! Many thanks. :clap:
Dejan Nadlacki
@Desomph
Just a MVVM Question: When I want to call (and eventually close) ChildWindow from a ViewModel, there's no other way to control it but to add it as a property in the ViewModel class and call .Close() on it?
Ray Tang
@raytangRT

Hi it seems that visual studio designer cannot show controls inside ChildWindow. Can anyone help?

Imgur

Jan Karger ツ ☀
@punker76
@raytangRT One trick is to set IsOpen="True", the other one , put your content inside a normal UserControl and work with this one.
Chris J
@thatsjohnson
Having an issue with SimpleChildWindow freezing UI during spawning of window. using ShowChildWindowAsync. Seems like its frozen in a sleep state with the UI.
Jan Karger ツ ☀
@punker76
@thatsjohnson Can you separate this in a short sample and put it on GitHub? Thx
Chris J
@thatsjohnson
@punker76 I will work on that. Could it have an issue if there isnt really a mainwindow for the application? I have a taskbar type application that has several secondary windows where the child windows are spawn.
Ray Tang
@raytangRT
@punker76 any plan on releasing simplechildwindow for mahapps.metro 1.6?
Dejan Nadlacki
@Desomph
I noticed something. When I show new Child Window, and within another Child Window, and I use a progress (via ShowProgressAsync) - after the progress finishes, child windows mess up their Z values, so the newly created window stays behind the old one.
Jan Karger ツ ☀
@punker76
@Desomph with which version of MahApps and SimpleChildWindow?
Dejan Nadlacki
@Desomph
MahApps 1.5 and SCW 1.3.0
Todd Burnside
@toddburnside

Hi all. I'm getting an InvalidOperationException when attempting to open a MahApps.Metro dialog while a SimpleChildWindow is open. This appears to be the same as documented in Issue #27 which was opened in Jan 2016 and fixed by a PR. The problem was that ChildWindowManager.ShowChildWindowAsync() was adding it's window directly to the MetroActiveDialogContainer. The PR changed this so that the window as added to the MetroInactiveDialogsContainer. However, later changes to ShowChildWindowsAsync() switched it back to preferentially adding it to the MetroActiveDialogContainer.

Is anyone else having this problem or have suggestions as to how to mitigate it? It seems to me that ShowChildWindowAsync() should be doing the same thing as the MahApps.Metro DialogManager.AddDialog does : if there is something in the active dialog container, move it to the inactive dialog container before putting the ChildWindow in the active dialog container. Of course this means that the ChildWindow ClosingFinished handler would need to deal with popping dialogs out of the inactive container if necessary, too.

Jan Karger ツ ☀
@punker76
@toddburnside which versions do you use of both?
Todd Burnside
@toddburnside
MahApps.Metro 1.6.5 and SimpleChildWindow 1.5.0.
Todd Burnside
@toddburnside
I forked SimpleChildWindow and made the changes I mentioned above. It seems to be working, but the problem was sporadic so it's hard to be sure. The changes work for me, but I don't think they are necessarily a solution you want to merge in. For one thing, I removed a couple of public ShowChildWindowAsync methods that took the dialog container as a parameter. It also doesn't take the MetroWindow.IsAnyDialogOpen into account - but that is not a new issue.
Mallory Nobles
@MalloryNobles_twitter
I'm new to this and am trying to get the SimpleChildWindow working. I want the child window to appear when I press a button inside the root grid in the main Metro window. Currently, the child window has content that shows in the designer, but when I press the button, I get a child window that looks like thisL
This looks similar to the issue @Seeker1437 was having, but I've tried setting my ChildWindowHeight and ChildWindowWidth, and it isn't resolving the issue. Any ideas?
Darnell Williams
@Seeker1437
Oh here
@MalloryNobles_twitter try using ChildWindowWidth and ChildWindowHeight
Oh rightalso also makOOH yeah n