Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Jalaj Patidar
@JalajPatidar
so I narrowed it down a bit more. Commented out one of the two methods and now the build error makes more sense. That test coverage is below 70% which is fine
haven't really added a new test anyway since last successful build
Arcadiy Ivanov
@arcivanov
[DEBUG/unittest] sending (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
[DEBUG/unittest] received (0, None)
[INFO/unittest] process shutting down
[DEBUG/unittest] running all "atexit" finalizers with priority >= 0
[DEBUG/unittest] running the remaining "atexit" finalizers
[INFO/unittest] process exiting with exitcode 0
[DEBUG/MainProcess] received (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
Jalaj Patidar
@JalajPatidar
yeah saw that, strange
Arcadiy Ivanov
@arcivanov
it's a syntax error in the file
Jalaj Patidar
@JalajPatidar
as the method runs in isolation
Arcadiy Ivanov
@arcivanov
but it doesn't compile in isolation :)
Jalaj Patidar
@JalajPatidar
ahh
Arcadiy Ivanov
@arcivanov
the whole file has to pass syntax check before loading
Jalaj Patidar
@JalajPatidar
gotcha
Arcadiy Ivanov
@arcivanov
so the file can't load
but basically it is a bug in PyB
Jalaj Patidar
@JalajPatidar
so does pyb enforce some kind of a syntax check?
Arcadiy Ivanov
@arcivanov
it doesn't pass the error up the chain
it's Python, not PyB
Jalaj Patidar
@JalajPatidar
ok
Arcadiy Ivanov
@arcivanov
the tests you run import the files
to import the modules the module files have to be syntactically correct
Jalaj Patidar
@JalajPatidar
yeah but if you just call the module directly using python <py_filename.py> , it works
actually, somehow , when it was working , the indentation was indeed correct, I just checked and now it's wrong even if I didn't really modify the file. Either way, it's fixed and thanks a TON man
for the prompt response
Arcadiy Ivanov
@arcivanov
no worries, thanks for the report and digging into this. I'll look deeper at it when I have time
could be an artifact of how unittest processes the files
I'll look
Arcadiy Ivanov
@arcivanov
@JalajPatidar fyi #770
Jalaj Patidar
@JalajPatidar
cool
Arcadiy Ivanov
@arcivanov
@/all PyBuilder now has a GitHub Action available: https://pybuilder.io/articles/news/3rd-party/pybuilder-github-action
@/all PyBuilder 0.13.0 has been released! https://pybuilder.io/release-notes/v0.13.x
Arcadiy Ivanov
@arcivanov
@/all PyBuilder 0.13.1 has been released!: https://pybuilder.io/release-notes/v0.13.x
Arcadiy Ivanov
@arcivanov
@/all PyBuilder 0.13.2 has been released!: https://pybuilder.io/release-notes/v0.13.x
It now includes a new flag that controls whether venv needs to be reset between integration tests
Arcadiy Ivanov
@arcivanov
Manuel Bernhardt
@manuelbernhardt

Hi! I have a question around installing dependencies: one of our projects has a dependency on AirFlow, which requires constraints (see https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#installation-tools), i.e. you'd install it with pip like so:

pip install "apache-airflow[celery]==2.2.2" --constraint "https://raw.githubusercontent.com/apache/airflow/constraints-2.2.2/constraints-3.6.txt"

I haven't found a way to specify that type of constraint using one of the depends_on functions -- is there a way to achieve this?

Arcadiy Ivanov
@arcivanov
well, actually constraints are generated based on the dependencies but this is the first time I've heard a project requiring installation constraints as part of installation itself
usually constraints are a feature of installing multiple projects together that may potentially have conflicts
Arcadiy Ivanov
@arcivanov
are you sure you HAVE to use the constraint file?
Manuel Bernhardt
@manuelbernhardt
I've checked this multiple times in various places and it seems like this project really has to be installed that way. there's a detailed description of why this is here: https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html#constraints-files
the way I managed to get the build to work now was by not installing the dependencies of the project with pybuilder but outside of it (in a venv) and disabling pybuilder's venv (pyb -v --no-venvs). but that's not very pretty
Arcadiy Ivanov
@arcivanov
Yep, but also I've never heard of extra constrain files required
That said, this can be added
Could you please add the issue and I'll take a look at it when I have time
Manuel Bernhardt
@manuelbernhardt
thanks a lot
Stephan Stachurski
@stevesta
does anyone know how to find examples of projects using pybuilder? i am evaluating build systems for a python project (packaged as docker images) and wondering if i could consider pybuilder, but i'd like to look at examples
Arcadiy Ivanov
@arcivanov
hi @stevesta