Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Arcadiy Ivanov
@arcivanov
so if everything ran, then what changed? 
Traceback (most recent call last):
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/cli.py", line 476, in main
    environments=options.environments, tasks=arguments)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/reactor.py", line 240, in build
    execution_summary = self.build_execution_plan(tasks, execution_plan)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/reactor.py", line 279, in build_execution_plan
    reactor=self)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/execution.py", line 399, in execute_execution_plan
    summaries.append(self.execute_task(task, **kwargs))
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/execution.py", line 346, in execute_task
    task.execute(self.logger, kwargs, _executable=_executable)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/execution.py", line 185, in execute
    executable.execute(argument_dict)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/execution.py", line 101, in execute
    self.callable(*arguments)
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/plugins/python/unittest_plugin.py", line 71, in run_unit_tests
    run_tests(project, logger, reactor, "unittest", "unit tests")
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/plugins/python/unittest_plugin.py", line 100, in run_tests
    project.get_property("remote_debug"))
  File "/home/jalaj/pipeline/lib/python3.7/site-packages/pybuilder/plugins/python/unittest_plugin.py", line 151, in execute_tests_matching
    result = runner.run(tests)
  File "/home/jalaj/Mx.DataScience.Pricing/.pybuilder/plugins/cpython-3.7.9.final.0/lib/python3.7/site-packages/xmlrunner/runner.py", line 66, in run
    test(result)
this makes little sense
Jalaj Patidar
@JalajPatidar
just added two new functions to the src/main/python/downloders.py file
Arcadiy Ivanov
@arcivanov
the test in question is null?
Jalaj Patidar
@JalajPatidar
yeah looks confusing, let me post the full logs file
Arcadiy Ivanov
@arcivanov
thanks!
Jalaj Patidar
@JalajPatidar
build_logs.txt
the two test cases that were there earlier when the build was running successfully are un-altered.
let me comment out the new code added in the main/python folder and see what happens
Arcadiy Ivanov
@arcivanov
sorry, I messed up with the logs :)
it's pyb -Premote_debug=2 -v -X
Jalaj Patidar
@JalajPatidar
no worries. I actually commented out the new code and the build passed. But it's still confusing as no new test cases were added after adding the new code.
Arcadiy Ivanov
@arcivanov
yeah, but new test cases might be failing in unexpected ways or more likely the modules fail to load
with those new methods
if you run the above
and post the logs
there may be megabytes
thanks!
Jalaj Patidar
@JalajPatidar
yea sec
Arcadiy Ivanov
@arcivanov
no rush
Jalaj Patidar
@JalajPatidar
build_logs.txt
so I narrowed it down a bit more. Commented out one of the two methods and now the build error makes more sense. That test coverage is below 70% which is fine
haven't really added a new test anyway since last successful build
Arcadiy Ivanov
@arcivanov
[DEBUG/unittest] sending (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
[DEBUG/unittest] received (0, None)
[INFO/unittest] process shutting down
[DEBUG/unittest] running all "atexit" finalizers with priority >= 0
[DEBUG/unittest] running the remaining "atexit" finalizers
[INFO/unittest] process exiting with exitcode 0
[DEBUG/MainProcess] received (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
Jalaj Patidar
@JalajPatidar
yeah saw that, strange
Arcadiy Ivanov
@arcivanov
it's a syntax error in the file
Jalaj Patidar
@JalajPatidar
as the method runs in isolation
Arcadiy Ivanov
@arcivanov
but it doesn't compile in isolation :)
Jalaj Patidar
@JalajPatidar
ahh
Arcadiy Ivanov
@arcivanov
the whole file has to pass syntax check before loading
Jalaj Patidar
@JalajPatidar
gotcha
Arcadiy Ivanov
@arcivanov
so the file can't load
but basically it is a bug in PyB
Jalaj Patidar
@JalajPatidar
so does pyb enforce some kind of a syntax check?
Arcadiy Ivanov
@arcivanov
it doesn't pass the error up the chain
it's Python, not PyB
Jalaj Patidar
@JalajPatidar
ok
Arcadiy Ivanov
@arcivanov
the tests you run import the files
to import the modules the module files have to be syntactically correct
Jalaj Patidar
@JalajPatidar
yeah but if you just call the module directly using python <py_filename.py> , it works
actually, somehow , when it was working , the indentation was indeed correct, I just checked and now it's wrong even if I didn't really modify the file. Either way, it's fixed and thanks a TON man
for the prompt response
Arcadiy Ivanov
@arcivanov
no worries, thanks for the report and digging into this. I'll look deeper at it when I have time
could be an artifact of how unittest processes the files
I'll look
Arcadiy Ivanov
@arcivanov
@JalajPatidar fyi #770
Jalaj Patidar
@JalajPatidar
cool