Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Arcadiy Ivanov
    @arcivanov
    ok, I'm here, what's up?
    Lonerider2010
    @Lonerider2010
    Hi, thanks for your time. Just wanted to clarify with you how the change and review workflow is defined for Sphinx.
    Because I did not find any help for that.
    Do you have any information on that topic?
    Arcadiy Ivanov
    @arcivanov
    on how to modify Sphinx documentation?
    Lonerider2010
    @Lonerider2010
    Yes, and how you would put remarks on these modifications?
    Arcadiy Ivanov
    @arcivanov
    you don't put remarks
    you make changes
    commit in your branch
    submit a PR into upstream repo
    and then the changes get reviewed
    one sec
    so rst files are where the documentation is
    some of the documentation is generated from them
    some is auto-generated
    Lonerider2010
    @Lonerider2010
    Yes, I know. So I can follow you on the steps you described. But the last point, how is the review done? On the PDF, on the HTML files?
    Arcadiy Ivanov
    @arcivanov
    neither
    on source files
    on rst files
    you don't review exe files
    you review c/c++ files from which you generate the exe :D
    Lonerider2010
    @Lonerider2010
    Ok, that was not clear to me. The work I made on documentation was always reviewed on the results, never on the sources.
    So that was the missing point for me.
    Arcadiy Ivanov
    @arcivanov
    sorry for the confusion :)
    Lonerider2010
    @Lonerider2010
    No problem. Now I know how to proceed and you will see when I submit the PR. Will take me some days...
    Ok, thanks for now. C U
    Arcadiy Ivanov
    @arcivanov
    super, thanks so much!
    Lonerider2010
    @Lonerider2010
    It's a pleasure for me :-)
    Arcadiy Ivanov
    @arcivanov
    @/all Hello all. There was an issue discovered with generated setup.py that would prevent the projects to correctly install with PyEnv shims from source. Please see pybuilder/pybuilder#601 for details. Remediation includes updating PyB 0.12 to latest and running pyb --update-project.
    Valentin Haenel
    @esc
    @arcivanov master was maybe broken due to flake8 warnings, I am in the process of fixing them and I also setup a cron-job from travis (new feature there) to run the tests on a daily basis, so we should catch this stuff earlier in future.
    Valentin Haenel
    @esc
    @arcivanov also, I just looked at the git history and 0.11 seems to get quite a lot of backported features, whereas master has quite a lot of new features, I can't remember what we decided to do going forward.
    but we should get 0.12.X out soonisch
    Arcadiy Ivanov
    @arcivanov
    yep
    unfortunately I'm very short on time right now
    Arcadiy Ivanov
    @arcivanov
    @/all Just wanted to send everyone a quick update: I'm working on a solution involving venv/virtualenv to decouple pip/setuptools/wheel dependencies from the primary PyB. This will involve both PyB-specific venv and project-specific venvs for reproducibility and will prevent primary venv pollution with project plugins etc.
    the biggest crux is the 2.7 support (as always)
    Valentin Haenel
    @esc
    @arcivanov not much longer, only 9 months till we can drop it
    Arcadiy Ivanov
    @arcivanov
    lol, well 2.7 will hang around for much longer than that, unfortunately :)
    Valentin Haenel
    @esc
    meep
    Arcadiy Ivanov
    @arcivanov
    ?? :)
    Valentin Haenel
    @esc
    still alive huh?
    Arcadiy Ivanov
    @arcivanov
    hanging in there :)
    Valentin Haenel
    @esc
    I'm an oss dev now, the company I work for develops it's own package manager, it is called conda
    but that only solves part of the problem
    I still want to work on pybuilder
    but soooooo much work
    Arcadiy Ivanov
    @arcivanov
    Yep, don't I know it :)
    Valentin Haenel
    @esc
    i see pybuilder slowly dying away
    withering as it were