Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Arcadiy Ivanov
@arcivanov
and post the logs
there may be megabytes
thanks!
Jalaj Patidar
@JalajPatidar
yea sec
Arcadiy Ivanov
@arcivanov
no rush
Jalaj Patidar
@JalajPatidar
so I narrowed it down a bit more. Commented out one of the two methods and now the build error makes more sense. That test coverage is below 70% which is fine
haven't really added a new test anyway since last successful build
Arcadiy Ivanov
@arcivanov
[DEBUG/unittest] sending (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
[DEBUG/unittest] received (0, None)
[INFO/unittest] process shutting down
[DEBUG/unittest] running all "atexit" finalizers with priority >= 0
[DEBUG/unittest] running the remaining "atexit" finalizers
[INFO/unittest] process exiting with exitcode 0
[DEBUG/MainProcess] received (0, IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n')))
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
IndentationError('unexpected indent', ('/home/jalaj/Mx.DataScience.Pricing/src/main/python/downloaders.py', 278, 16, ' all_rvus = pd.concat(all_rvus)\n'
Jalaj Patidar
@JalajPatidar
yeah saw that, strange
Arcadiy Ivanov
@arcivanov
it's a syntax error in the file
Jalaj Patidar
@JalajPatidar
as the method runs in isolation
Arcadiy Ivanov
@arcivanov
but it doesn't compile in isolation :)
Jalaj Patidar
@JalajPatidar
ahh
Arcadiy Ivanov
@arcivanov
the whole file has to pass syntax check before loading
Jalaj Patidar
@JalajPatidar
gotcha
Arcadiy Ivanov
@arcivanov
so the file can't load
but basically it is a bug in PyB
Jalaj Patidar
@JalajPatidar
so does pyb enforce some kind of a syntax check?
Arcadiy Ivanov
@arcivanov
it doesn't pass the error up the chain
it's Python, not PyB
Jalaj Patidar
@JalajPatidar
ok
Arcadiy Ivanov
@arcivanov
the tests you run import the files
to import the modules the module files have to be syntactically correct
Jalaj Patidar
@JalajPatidar
yeah but if you just call the module directly using python <py_filename.py> , it works
actually, somehow , when it was working , the indentation was indeed correct, I just checked and now it's wrong even if I didn't really modify the file. Either way, it's fixed and thanks a TON man
for the prompt response
Arcadiy Ivanov
@arcivanov
no worries, thanks for the report and digging into this. I'll look deeper at it when I have time
could be an artifact of how unittest processes the files
I'll look
Arcadiy Ivanov
@arcivanov
@JalajPatidar fyi #770
Jalaj Patidar
@JalajPatidar
cool